ROOT version 4.03 Development Notes
2005-04-26 16:31 brun
* graf/src/TGraph.cxx:
From Alexandr Malusek <Alexandr.Malusek@imv.liu.se>
Fix a problem in TGraph::Eval in case the point to be
computed is at the edges of the graph.
2005-04-26 15:03 brun
* hist/: inc/TH1.h, src/TH1.cxx:
From Anna Kreshuk:
Add two new functions to TH1:
Double_t TH1::GetSkewness(Int_t axis) const
//Returns skewness of the histogram
//Note, that since third and fourth moment are not calculated
//at the fill time, skewness is computed bin by bin.
Double_t TH1::GetKurtosis(Int_t axis) const
//Returns kurtosis of the histogram. Kurtosis(gaussian(0, 1)) = 0.
//Note, that since third and fourth moment are not calculated
//at the fill time, kurtosis is computed bin by bin.
2005-04-26 14:33 brun
* graf/src/TGraph.cxx:
In the TGraph constructor reading ana scii file, replace the
use of the non portable ifstream::is_open
2005-04-26 11:00 brun
* winnt/src/TWinNTSystem.cxx:
From Axel Naumann:
tiny patch for TWinNTSystem::SetProgname():
gProgPath is not used by ROOT. If it cannot be set (because the program
cannot be found) just quietly set it to $PWD, without warning, as most
people won't use gProgPath. Ref:
http://root.cern.ch/phpBB2/viewtopic.php?p=7061
I've left the Warning() as a comment, because it nicely documents why
things go wrong.
2005-04-25 23:12 rdm
* base/inc/TView.h, base/src/TView.cxx, geom/src/TGeoTube.cxx:
fix unfortunate spelling error (parralel -> parallel).
2005-04-25 19:23 brun
* gpad/src/TPad.cxx, table/inc/TChair.h, table/src/TColumnView.cxx:
From Valeri Fine:
TChair.h:
- Make the "fTable" data-member to be "protected" (it was "private")
to facilitate the class reuse (thanks Y.Fisyak)
TColumnView.cxx:
- extra protection against of zero gPad
TPad.cxx
- initialize the "fPadView3D" data-member
(causes the crash within "table" package occasionally)
2005-04-25 19:21 rdm
* oracle/: inc/TOracleResult.h, inc/TOracleRow.h,
src/TOracleResult.cxx, src/TOracleRow.cxx, src/TOracleServer.cxx:
From Yan Liu:
fixed verion of the Oracle plugin. Should now work as advertised via the
abstract TSQL interfaces.
2005-04-25 18:35 rdm
* unix/src/TUnixSystem.cxx:
From Gerri:
if TMPDIR is not writable fall back to "/tmp".
2005-04-25 15:59 brun
* hist/src/TH2.cxx, histpainter/src/THistPainter.cxx:
From Olivier:
Help improvement: in an expression like [gc1,gc2], "," means logical AND
2005-04-25 12:05 brun
* geom/src/TGeoVolume.cxx:
From Andrei Gheata:
few add-ons in TGeoVolume. When several pads contained
different geometries, moving mouse between them failed because
gGeoManager is still used in TGeoShape::ShapeDistancetoPrimitive. Now
the gGeoManager pointer is correctly set (if altered by a different
geometry/external change) in TGeoVolume::Draw, TGeoVolume::DrawOnly,
TGeoVolume::DistancetoPrimitive, TGeoVolume::Raytrace,
TGeoVolume::RandomPoints and TGeoVolume::RandomRays. It behaves now
correctly.
2005-04-25 12:03 brun
* foam/: inc/TFoamCell.h, src/TFoamCell.cxx:
From Pawel Sawicki
Change member fkDim to fDim
2005-04-25 09:53 brun
* config/rootrc.in, geom/inc/TGeoVolume.h,
geom/inc/TVirtualGeoPainter.h, geom/src/TGeoManager.cxx,
geom/src/TGeoVolume.cxx, geom/src/TVirtualGeoPainter.cxx,
geompainter/inc/TGeoChecker.h, geompainter/inc/TGeoPainter.h,
geompainter/src/TGeoChecker.cxx, geompainter/src/TGeoOverlap.cxx,
geompainter/src/TGeoPainter.cxx:
Implement changes in the TGeoPainter and TGeoChecker such that one
can draw geometries from several TGeoManagers.
The following mods have been made:
-new data member fGeoManager in TGeoVolume.
When a volume is created fGeoManager is set to the current gGeoManager.
When a volume is drawn, a TGeoPainter object is created in its own fGeoManager.
- new function TGeoVolume::GetGeoManager() const
-The TVirtualGeoPainter and TGeoPainter have now a constructor with:
TVirtualGeoPainter(TGeoManager *manager)
TGeoPainter(TGeoManager *manager)
-The TGeoManager::GetGeoPainter is now calling directly the plugin manager
to create a TGeoPainter if necessary.
-In TGeoVolume, all occurences of gGeoManager replaced by fGeoManager.
-In TGeoChecker and TGeoPainter, the existing member fGeom has been
renamed fGeoManager and all occurences of gGeoManager replaced by fGeoManager.
-In TGeoOverlap all occurences of gGeoManager are creplaced by
fVolume->GetGeoManager.
-In rootrc.in mod for calling TGeoPainter with the new argument TGeoManager*.
2005-04-23 17:56 rdm
* config/root-config.in, test/Makefile.arch:
add -Wno-long-double to clfags in root-config since otherwise ROOT includes
will cause many warnings about long-double not being portable.
2005-04-23 13:34 brun
* test/hworld.cxx:
Uncomment one statement
2005-04-23 13:01 brun
* test/: hworld.cxx, hworld2.cxx:
Rename hworld.cxx to hworld2.cxx
Introduce a simplified version of hworld.cxx (Valeriy)
2005-04-23 12:55 brun
* gpad/inc/TCanvas.h, gpad/src/TCanvas.cxx,
gui/src/TRootCanvas.cxx:
From Valeriy Onuchin:
- do not delete TRootCanvas on "File->Quit ROOT" action
when TApplication::SetReturnFromRun() is kTRUE.
- TCanvas::Closed signal added which is emitted when canvas is closed by
either destructor or by "window close button".
2005-04-23 12:27 brun
* win32gdk/src/TGWin32.cxx:
From Bertrand Bellenot:
Restore input focus back to the previous window at the
end of TGWin32::RequestString()
(Thanks to Jean-Marc Linder for reporting the problem).
2005-04-23 08:13 brun
* tree/src/TTree.cxx, treeplayer/src/TTreeFormula.cxx:
From Philippe:
This patch solves a problem with friends of friends when the friends where
chains and contained some branches with the same name.
This issues is now test in roottest/root/tree/friend in test
the FriendOfFriend. (Which includes Marek's test).
2005-04-22 21:29 brun
* tree/src/TBranchBrowsable.cxx:
From Philippe:
fix a compiler warning
2005-04-22 21:04 brun
* tree/inc/TBranchBrowsable.h, tree/src/TBranchBrowsable.cxx,
treeplayer/inc/TFormLeafInfo.h, treeplayer/src/TFormLeafInfo.cxx,
treeplayer/src/TTreeFormula.cxx:
From Philippe:
This updates solves issues when trying to browse (via the TBrowser) branches
which had their top level branchname embedded in their own name (i.e. when
the top level branch has been created with a trailing dot in their name).
Also fix a few problem preventing the drawing of branches containing pointer
to STL collection or some case of STL collection containing pointer to
objects.
2005-04-22 17:32 brun
* matrix/inc/LinkDef.h:
From Eddy Offermann:
small update of the matrix/inc/LinkDef.h because
three vector functions in which they are multiplied with
matrices were missing .
2005-04-22 09:32 brun
* geom/src/TGeoManager.cxx:
From Andrei Gheata:
Un-initialized pointer from my last commit.
2005-04-22 08:29 brun
* histpainter/src/THistPainter.cxx:
Fix a problem in THistPainter::PaintBar in case of a log scale in Y
and the bin content is null.
2005-04-21 20:46 brun
* win32gdk/: inc/TGWin32ProxyBase.h, src/TGWin32.cxx,
src/TGWin32ProxyBase.cxx:
From Bertrand:
Mods in TGWin32ProxyBase and TGWin32 adding the possibility to change
fMaxResponseTime, avoiding timeout in TGWin32ProxyBase::ForwardCallBack
during gVirtualX->RequestString()
2005-04-21 18:05 brun
* graf/src/TGraph.cxx:
A better version of the TGraph constructor creating a TGraph from an input ascii file.
(thanks to Mike Kordoski)
2005-04-21 16:04 brun
* html/src/THtml.cxx:
From Axel Naumann:
THtml tried to access const char* fLine[-1].
This bug prevented the correct generation of TGraph.html
2005-04-21 15:58 brun
* hist/src/TH1.cxx:
From Olivier:
- TH1::TH1() now uses UseCurrentStyle() to initialize the default
histogram "style parameters". In particular it initializes properly the
Histogram Fill Color to 0 which prevent the following three lines to
generate a "X11 Fatal Error".
TH1D h
h.SetBins(5000000,0,1)
h.Draw()
2005-04-21 12:59 rdm
* Makefile, xrootd/Module.mk:
two small corrections.
2005-04-21 11:51 brun
* gpad/src/TPad.cxx:
From Otto Schaile
Fix in TPad::WaitPrimitive such that waiting for a TCutG works again.
This fix was necessary following the restructuring of TPad and
the new class TCreatePrimitives.
2005-04-21 10:13 brun
* g3d/src/TNode.cxx, geompainter/src/TGeoPainter.cxx,
gpad/src/TViewer3DPad.cxx:
From Richard Maunder:
Fix problem with pad zooming (j/k keys). Set AutoRange (frame) once on
TView at creation, not repeatedly each time TViewer3DPad draws via it.
2005-04-21 08:28 brun
* test/stress.cxx:
Change the reference file size in stress2 to reflect the changes
in TStreamerElement (files are now a bit smaller).
2005-04-21 08:24 brun
* meta/: inc/TStreamerElement.h, src/TStreamerElement.cxx:
The new data members "fXmin, fXmax, fFactor" are changed to transient members.
In TStreamerElement::Streamer the function GetRange is called to recompute
the range from the comments field if the bit kHasRange (new enum) is set.
This change makes the ROOT files written by this new version of ROOT readable
without any warning messages by older versions of ROOT.
2005-04-20 21:35 brun
* hist/src/TProfile2D.cxx:
The transient member fScaling must be set to kFALSE in the default constructor.
This is necessary when an object is read in and functions like called after..
(thanks Valeri fine)
2005-04-20 21:29 brun
* hist/src/TH2.cxx, histpainter/src/THistPainter.cxx:
Implement better solution than in previous patch that keeps
case sensitivity for TCutG names.
2005-04-20 19:51 brun
* histpainter/src/THistPainter.cxx:
In THistPainter::MakeCuts TCutGs are now case insensitive.
This solves a problem when a TCutG is created with a name including
capital letters (default is CUTG !)
2005-04-20 19:44 brun
* gpad/src/TCreatePrimitives.cxx:
From Otto Schaile:
Use new GetDefaultX functions also for TCurlyArc and TCurlyLine.
2005-04-20 19:06 brun
* gpad/src/TCreatePrimitives.cxx:
From Otto Schaile:
Use the new TArrow::GetDefaultX functions when creating new TArrow
from the editor.
2005-04-20 17:22 brun
* geom/: inc/TGeoElement.h, inc/TGeoManager.h,
src/TGeoBoolNode.cxx, src/TGeoElement.cxx, src/TGeoManager.cxx,
src/TGeoMaterial.cxx, src/TGeoSphere.cxx:
From Andrei Gheata:
- boundary tolerance introduced for spheres
- few corrections related to boundary tolerance in composite shapes
- fix for the problem reported by Sue: now the element table is not a
singleton anymore - it is owned by each TGeoManager class and has to be
retreived by calling gGeoManager->GetElementTable().
- fix for problem with MANY's observed by Andreas Morsch in Alice ITS : some
topologies of MANY leading to different search hypothesys were not
properly checked, resulting in overlapping regions that became invisible
during tracking: now completely fixed.
2005-04-20 17:15 brun
* graf/inc/: TArrow.h, TCurlyArc.h, TCurlyLine.h:
Unfortunatly the use of a static global member as a default value
for an optional constructor argument is not portable on Windows
when the constructor class is in a different shared lib (well know VC++ problem)
2005-04-20 16:59 brun
* gpad/src/TCreatePrimitives.cxx, graf/inc/TArrow.h,
graf/inc/TCurlyArc.h, graf/inc/TCurlyLine.h, graf/src/TArrow.cxx,
graf/src/TCurlyArc.cxx, graf/src/TCurlyLine.cxx:
From Otto Schaile:
Implement several static members and the corresponding getters
and setters in the following classes:
TArrow
======
static Float_t fgDefaultAngle; //default Arrow opening angle (degrees)
static Float_t fgDefaultArrowSize; //default Arrow Size
static TString fgDefaultOption; //default Arrow shapes
TCurlyArc
=========
static Double_t fgDefaultWaveLength; //default wavelength
static Double_t fgDefaultAmplitude; //default amplitude
static Bool_t fgDefaultIsCurly; //default curly type
TCurlyLine
==========
static Double_t fgDefaultWaveLength; //default wavelength
static Double_t fgDefaultAmplitude; //default amplitude
static Bool_t fgDefaultIsCurly; //default curly type
Modify TCreatePrimitives to take into account these new functions.
2005-04-20 16:08 brun
* base/src/TView.cxx:
In TView::ExecuteRotateView use viewer->IsA()->GetName()
instead of viewer->Class_Name()
2005-04-20 12:29 brun
* hist/src/TH2.cxx:
From Olivier:
- In revision 1.19 the following change was made in TH2::ProjectionX,
TH2::ProjectionY, TH2::ProfileX and TH2::ProfileY:
"[...] When all bins are included, the number of entries in the
projection is set to the number of entries of the 2-D histogram [..]"
This was fine until revision 1.55 in which it is possible to make a
projection according to graphical cuts. This fix makes the two revisions
compatible.
2005-04-20 09:17 brun
* base/src/TBuffer.cxx:
in TBuffer::WriteDouble32 add:
- a reference to the new tutorial double32.C
- the picture produced by this tutorial, see:
http://root.cern.ch/root/htmldoc/TBuffer.html#TBuffer:WriteDouble32
2005-04-20 09:05 brun
* tutorials/double32.C:
Add new tutorial illustrating use and precision of the Double32_t data type
2005-04-19 22:05 brun
* tree/src/TBasket.cxx:
In TBasket::WriteBuffer the total number of bytes written was not
incremented in case the buffer cannot be compressed.
2005-04-19 21:39 brun
* test/dt_DrawTest.C, test/dt_MakeRef.C, tree/src/TTree.cxx,
treeplayer/inc/TTreeFormula.h, treeplayer/src/TTreeFormula.cxx,
treeplayer/src/TTreePlayer.cxx:
From Philippe:
This patch introduces a new special function in TTreeFormula Sum$
described as follow:
// Sum$(formula): return the sum of the value of the elements of the
// formula given as a parameter. For example the mean for all the
// elements in one entry can be calculated with:
// Sum$(formula)/Length$(formula)
The idea comes from http://root.cern.ch/phpBB2/viewtopic.php?p=6943
2005-04-19 18:09 brun
* build/unix/compiledata.sh:
From Philippe:
This patch effectively disable the explicit linking of libraries for ACLiC
on MacOS.
This side-steps the issue with missing dylib but it also disable the
autoload of
dependent library (which anyway has a lot of problems on mac!).
2005-04-19 13:03 brun
* foam/src/TFoam.cxx, foam/src/TFoamMaxwt.cxx,
tutorials/foam_demopers.C, tutorials/foam_kanwa.C:
From Pawel Sawicki
Minor corrections, loading
of Foam library in demo scripts recovered
2005-04-19 12:11 brun
* meta/src/TStreamerElement.cxx:
Added protection against a range where xmin >= xmax
2005-04-19 11:10 brun
* gui/inc/TGTab.h, gui/src/TGTab.cxx, test/guitest.cxx,
tutorials/guitest.C:
From Valeriy Onuchin:
- TGCompositeFrame *TGTab::GetTabContainer(const char *name) const
Bool_t TGTab::SetTab(const char *name)
TGTabElement *TGTab::GetTabTab(const char *name) const
methods added (proposed by Thomas Bretz )
2005-04-19 09:41 brun
* meta/src/TStreamerInfoReadBuffer.cxx:
Add protections against reading arrays bigger than the buffer size
2005-04-19 08:13 brun
* xml/src/TXMLBuffer.cxx:
Comment unused arguments
2005-04-19 07:04 brun
* cint/src/tmplt.c:
From Philippe:
Currently G__declare_template does not properly parse something like:
template <class A,B>
inline MyTemplate<A,B<A> > operator*(...);
because it basically assumes that the return type contains
everything and including the last '*'.
The patch attached solves the problem (and the file andras.tgz
demonstrated the problem).
2005-04-18 23:17 rdm
* unix/src/TUnixSystem.cxx:
TFdSet::GetBits() returns a Long_t and not anymore an Int_t (the bits
member is now an array of longs and not ints).
2005-04-18 21:41 brun
* cont/src/: TEmulatedCollectionProxy.cxx,
TGenCollectionStreamer.cxx:
Remove references to TStreamerElement* aElement when calling
TBuffer::WriteFastArrayDouble32. The case with a range cannot happen in this case.
2005-04-18 21:14 brun
* meta/src/TStreamerInfo.cxx:
From Philippe:
This patch adds a protection in the case where a data member
has been removed from a class (and we are trying to read
the old version)
2005-04-18 18:19 rdm
* build/unix/makelib.sh, cint/iosenum/iosenum.macosx643,
config/ARCHS, config/Makefile.macosx64, config/root-config.in,
test/Makefile.arch:
initial port to MacOS X 64-bit mode. With Tiger Apple supports a 64 bit
compiler (gcc 4.0) and a 64 bit version of the system libraries on G5.
2005-04-18 18:10 brun
* test/Event.h:
In class Track change the number of bits allocated to fVertex[3]
from 10 to 16 bits. With this change, DrawTest.sh works again.
2005-04-18 18:05 rdm
* base/inc/RConfig.h, base/src/TMapFile.cxx, clib/src/Getline.c,
clib/src/mmapsup.c, clib/src/mvalloc.c, unix/src/TUnixSystem.cxx:
finalize port to Linux PPC64 (IBM and Apple hardware with Suse or Yellow Dog
Linux in 64 bit mode).
2005-04-18 17:31 brun
* cint/src/newlink.c, utils/src/rootcint.cxx:
From Philippe:
As you may remember, windows has a crappy way of locking and unlocking
file which lead to intermittent failure when trying to reopen a file
we just closed. The attached patch to newlink.c allow for work-around
more case (not only access error but also rewrites). [With this
we still have intermittent failure in roottest on windows]
2005-04-18 17:15 rdm
* unix/src/TUnixSystem.cxx:
fds_bits in TFdSet was Int_t but must be Long_t. This
to fail on big endian 64 bit machines (PowerPC 64).
2005-04-18 15:16 brun
* tutorials/: fitLinear.C, fitLinear2.C:
From Anna Kreshuk
New tutorials with examples of the Linear Fitter
2005-04-18 15:15 brun
* tutorials/fitMultiGraph.C:
From Anna Kreshuk:
new tutorial showing how to fit a TMultiGraph
2005-04-18 12:54 brun
* base/inc/TBuffer.h, base/src/TBuffer.cxx,
cont/src/TEmulatedCollectionProxy.cxx,
cont/src/TGenCollectionStreamer.cxx, meta/inc/TStreamerElement.h,
meta/src/TStreamerElement.cxx,
meta/src/TStreamerInfoReadBuffer.cxx,
meta/src/TStreamerInfoWriteBuffer.cxx, test/Event.h,
test/stress.cxx, xml/inc/TXMLBuffer.h, xml/src/TXMLBuffer.cxx:
Extend the functionality of the Double32_t data type (see below)
This extension supports higher precision than just a 32 bit float
and it also allows better compression when the range and number of bits
are specified.
New functions in TBuffer
void TBuffer::ReadDouble32 (Double_t *d, TStreamerElement *ele)
void TBuffer::WriteDouble32 (Double_t *d, TStreamerElement *ele)
The following functions of TBuffer have new signatures;
Int_t TBuffer::ReadArrayDouble32(Double_t *&d, TStreamerElement *ele)
Int_t TBuffer::ReadStaticArrayDouble32(Double_t *d, TStreamerElement *ele)
void TBuffer::ReadFastArrayDouble32(Double_t *d, Int_t n, TStreamerElement *ele)
void TBuffer::WriteArrayDouble32(const Double_t *d, Int_t n, TStreamerElement *ele)
void TBuffer::WriteFastArrayDouble32(const Double_t *d, Int_t n, TStreamerElement *ele)
The following data members have been added to TStreamerElement;
Double_t fXmin; //Minimum of data member if a range is specified [xmin,xmax,nbits]
Double_t fXmax; //Maximum of data member if a range is specified [xmin,xmax,nbits]
Double_t fFactor; //Conversion factor if a range is specified fFactor = (1<<nbits/(xmax-xmin)
The static function GetRange has been added to TStreamerElement.cxx.
This function analyzes the range specifier given in the data member
comments field.
The following cases are supported for streaming a Double32_t type
depending on the range declaration in the comment field of the data member:
A- Double32_t fNormal;
B- Double32_t fTemperature; //[0,100]
C- Double32_t fCharge; //[-1,1,2]
D- Double32_t fVertex[3]; //[-30,30,10]
E Int_t fNsp;
Double32_t* fPointValue; //[fNsp][0,3]
In case A fNormal is converted from a Double_t to a Float_t
In case B fTemperature is converted to a 32 bit unsigned integer
In case C fCharge is converted to a 2 bits unsigned integer
In case D the array elements of fVertex are converted to an unsigned 10 bits integer
In case E the fNsp elements of array fPointvalue are converted to an unsigned 32 bit integer
Note that the range specifier must follow the dimension specifier.
the case B has more precision (9 to 10 significative digits than case A (6 to 7 digits).
The range specifier has the general format: [xmin,xmax] or [xmin,xmax,nbits]
[0,1]
[-10,100];
[-pi,pi], [-pi/2,pi/4],[-2pi,2*pi]
[-10,100,16]
if nbits is not specified, or nbits <2 or nbits>32 it is set to 32
TStreamerInfo has been modified to take into account the new facility
when streaming a Double32_t. It
and WriteDouble32 instead of the previous inline code.
Note that the files TEmulatedCollectionProxy.cxx and TGenCollectionStreamer.cxx
must still be modified to pass correctly the TStreamerElement object
to the Double32 conversion routines (for Philippe).
Note also that the class TXMLBuffer must still be changed to support
the Double32_t data type (for Sergei).
The test program Event has been modified to illustrate several combinations
of the range specifier.
The test program stress2 has been changed to take into account the slight
increase in the file size due to the new members in TStreamerElement.
2005-04-17 16:12 brun
* graf/src/TGraph.cxx, graf/src/TMultiGraph.cxx,
hist/inc/Foption.h, hist/src/TGraph2D.cxx, hist/src/TH1.cxx,
minuit/src/TFitter.cxx, minuit/src/TLinearFitter.cxx:
From Anna Kreshuk:
Some fixes for the linear fitter, some cosmetic changes in the
TH1, TGraph, TMultigraph and TGraph2D, and also the new fitting option
"F", which allows to switch to minuit when fitting a polN.
2005-04-16 07:46 brun
* pyroot/src/: Converters.cxx, Converters.h, MethodProxy.cxx:
From Wim Lavrijsen:
o) added specialized array converter for long long, even though no type
code exists in module array; this is to prevent other arrays to resolve
to this converter because they match void*
2005-04-15 19:37 brun
* pyroot/src/: Converters.cxx, Converters.h:
From Wim Lavrijsen:
o) added specialized array convertes for short, ushort, uint, ulong.
2005-04-15 19:26 rdm
* base/inc/RConfig.h, build/rmkdepend/main.c,
config/Makefile.macosx, proof/src/TProofServ.cxx,
rootd/src/rootd.cxx, rpdutils/src/net.cxx, rpdutils/src/netpar.cxx,
rpdutils/src/rpdutils.cxx, rpdutils/src/ssh.cxx,
unix/src/TUnixSystem.cxx, xrootd/src/xrootd-20050328-0656.src.tgz:
finalized and cleaned up port to Tiger (using the golden beta).
2005-04-15 17:27 brun
* gpad/src/TPad.cxx:
Fix a cast problem with strstr on Solaris.
This problem was generated by a previous fix in TPad::Print
replacing a char* by a TString.
2005-04-15 16:49 brun
* graf/src/TMultiGraph.cxx:
Fix a cast problem if a if statement
2005-04-15 16:41 brun
* base/src/TBuffer.cxx:
Activate USE_BSWAPCPY
2005-04-15 16:20 rdm
* rootx/src/rootxx.cxx:
add protection in case needed adobe font is not found and print hint which
package to install to get these fonts.
2005-04-15 15:21 brun
* unix/src/TUnixSystem.cxx:
From Philippe
Add support for .dll, .DLL notation also on Unix (to be consistent with CINT)
2005-04-15 14:39 brun
* foam/inc/TFoam.h, foam/inc/TFoamCell.h, foam/inc/TFoamVect.h,
foam/src/TFoam.cxx, foam/src/TFoamCell.cxx,
tutorials/foam_demopers.C, tutorials/foam_kanwa.C:
From Pawel Sawicki
Changes in member names, char strings
replaced by TString
2005-04-15 09:19 brun
* qt/: inc/TQtApplication.h, inc/TQtClientFilter.h,
inc/TQtClientWidget.h, inc/TQtRConfig.h, src/GQtGUI.cxx,
src/TGQt.cxx, src/TQtApplication.cxx, src/TQtClientFilter.cxx,
src/TQtClientWidget.cxx:
From Valeri Fine
- TQtApplication, TQRConfig
Test the proper Qt package version.
- TGQt
An extra protection against of the dead widgets
- TQtClientFilter, TQtClientWidget, GQtGUI
Fix to manage the ROOT GUI keyboard navigation
The issue is still open.
In fact, the patch may cause some troubles due apparent
clash between ROOT (X11 style) GrabButton and GrabPointer and the way
Qt internally handles the "FocusIn / FocusOut" events.
2005-04-14 23:53 brun
* pyroot/src/: Converters.cxx, Converters.h, MethodHolder.cxx:
From Wim Lavrijsen:
o) check C++ inheritence hierarchy in function overload resolution
2005-04-14 23:30 brun
* tree/src/: TBranchElement.cxx, TChain.cxx, TDSet.cxx, TTree.cxx:
From Philippe,
Replace previous poorly written code like
nextTree = (TTree*)nextFriend->GetTree();
by a more modern and readable style
nextTree = const_cast<TTree*>(nextFriend->GetTree());
::)
2005-04-14 18:42 brun
* tree/src/TChain.cxx:
In TChain::GetEntries remove an obsolete cast to Stat_t
2005-04-14 15:40 brun
* treeplayer/src/TTreeFormula.cxx:
From Philippe:
This patch adds a missing 'continue' statement that was essentually
rendering Length4(xyz) useless when used inside an expression
(eg Length$(xyz)<20)
2005-04-14 12:43 rdm
* xrootd/Module.mk:
remove some spurious blank that causes make to fail.
2005-04-14 12:23 rdm
* asimage/Module.mk, freetype/Module.mk, graf/Module.mk,
win32gdk/Module.mk, x11ttf/Module.mk:
fix dependencies in case not using the builtin, i.e. ROOT provided, freetype.
2005-04-14 11:06 rdm
* pyroot/Module.mk:
link libPyROOT with machine thread library if ROOT is built with thread
support.
2005-04-14 08:52 brun
* graf/: inc/TMultiGraph.h, src/TMultiGraph.cxx:
Add a new function
Option_t *TMultiGraph::GetGraphDrawOption(const TGraph *gr) const
// Return the draw option for the TGraph gr in this TMultiGraph
// The return option is the one specified when calling TMultiGraph::Add(gr,option).
2005-04-13 20:04 rdm
* unix/src/TUnixSystem.cxx, winnt/src/TWinNTSystem.cxx:
in DispatchOneEvent() when in pendingonly mode make one poll on the file
descriptors to see if there are file or socket events waiting. This should
fix a problem of socket events not being handled by TSystem::ProcessEvent().
2005-04-13 18:56 rdm
* proof/src/: TProofPlayer.cxx, TProofServ.cxx:
From Maarten:
comment corrections.
2005-04-13 18:52 rdm
* gpad/src/TPad.cxx:
From Valeriy:
- in TPad::Print
o fix memory leak (thanks to Stan Seibert for reporting it)
o allocate dynamic internal "psname" string (it was only 264 char long)
2005-04-13 18:38 rdm
* xrootd/Module.mk:
fix for MacOS X.
2005-04-13 15:15 brun
* foam/inc/TFoam.h, foam/inc/TFoamCell.h, foam/inc/TFoamMaxwt.h,
foam/inc/TFoamVect.h, foam/src/TFoam.cxx, foam/src/TFoamCell.cxx,
foam/src/TFoamMaxwt.cxx, foam/src/TFoamVect.cxx,
tutorials/foam_demopers.C:
From Pawel Sawicki
Added LinkCells method, more methods const, many text corrections
2005-04-13 12:48 rdm
* configure:
in check_symbol also check optionally in lib32, lib64 or hpux64 directories.
2005-04-13 12:47 rdm
* netx/Module.mk, xrootd/Module.mk, xrootd/src/.cvsignore,
xrootd/src/xrootd-20041124-0752.src.tgz,
xrootd/src/xrootd-20050328-0656.src.tgz:
From Gerri:
use latest stable release of xrootd.
2005-04-13 12:01 brun
* hist/inc/TSpectrum.h:
Fix formatting problems
2005-04-13 10:00 brun
* hist/src/TSpectrum.cxx:
Add a reference to an article in TSpectrum::Deconvolution1
2005-04-13 08:15 brun
* test/RootShower/MyParticle.cxx:
From Bertrand
This fix was forgotten in the previous patch
2005-04-13 07:04 brun
* pyroot/: ROOT.py, src/ClassMethodHolder.h,
src/FunctionHolder.cxx, src/FunctionHolder.h, src/MethodHolder.cxx,
src/MethodHolder.h, src/MethodProxy.h, src/Pythonize.cxx,
src/RootWrapper.cxx:
From Wim Lavrijsen:
this will require some refactoring later (I think the Funtion/MethodHolder
inheritence is wrong), but for now it works just fine and it is a little
urgent:
o) add call to GetGlobalFunction in global lookup
o) protect (TGlobal*)0 returns
o) make TFunction objects callable
New files pyroot/src/FunctionHolder.[cxx][h]
2005-04-12 23:24 brun
* hist/src/TSpectrum.cxx:
Add references to Miroslav documentation files in ROOT ftp site
2005-04-12 19:16 brun
* foam/src/TFoamMaxwt.cxx:
remove a const declaration in one constructor
2005-04-12 18:58 brun
* base/src/TObject.cxx:
One minor change suggested by Eddy in the comments of TObject::GetDrawOption
2005-04-12 18:26 brun
* hist/src/TMultiDimFit.cxx:
From Gilles Quemener <quemener@lpsc.in2p3.fr>
Fix bugs in TMultiDimFit::MakeCorrelation
2005-04-12 15:45 brun
* base/src/TObject.cxx:
Add more comments in TObject::GetDrawOption and TObject::SetDrawOption
In particular, indicate that it does not make sense to call these functions
before drawing the object.
2005-04-12 14:55 rdm
* build/package/debian/control.in:
From Christian:
add alternative dependency on libxpm-dev (in addition to libxpm4-dev).
2005-04-12 14:31 brun
* foam/: inc/TFoam.h, inc/TFoamCell.h, inc/TFoamIntegrand.h,
inc/TFoamMaxwt.h, inc/TFoamVect.h, src/TFoam.cxx,
src/TFoamCell.cxx, src/TFoamIntegrand.cxx, src/TFoamMaxwt.cxx,
src/TFoamVect.cxx:
Change Author line to be compliant with THtml and add the mailto specifier
2005-04-12 14:11 brun
* base/src/TStyle.cxx:
From Olivier:
- In SetPalette: The DeepSea palette is defined only if needed. Without
this protection the following macro went slower and slower.
{
for (int i=0; i<10; i++) {
TStopwatch clock;
clock.Start();
gStyle->SetPalette(51, NULL);
clock.Print();
}
}
2005-04-12 12:01 brun
* foam/: inc/TFoam.h, src/TFoam.cxx, src/TFoamCell.cxx,
src/TFoamMaxwt.cxx, src/TFoamVect.cxx:
Fix style problems with the documentation preventing THtml to run correctly
on the class description.
Replaced mFOAM by FOAM.
2005-04-12 11:29 brun
* gl/src/CsgOps.cxx:
From Timur:
make code more portable replacing ifdefs by typedef
2005-04-12 11:26 brun
* proof/src/TProofDraw.cxx, tree/inc/TVirtualIndex.h,
tree/src/TTree.cxx, treeplayer/inc/TTreeIndex.h,
treeplayer/src/TTreeIndex.cxx:
From Marek Biskup:
- removed obsolete code from TTreeIndex::GetEntryNumberWithIndex and
fixed documentation.
- removed obsolete function TVirtualIndex::GetEntry(Long64_t /*entry*/)
and TTreeIndex::GetEntry(Long64_t /*entry*/).
- cosmetics in TProofDraw
2005-04-12 08:48 brun
* meta/src/TGenericClassInfo.cxx:
In the TGenericClassInfo constructors the members fImplFileName
and fImplFileLine were not initialized. (thanks Marco Cattaneo_
2005-04-12 00:39 rdm
* oracle/src/TOracleServer.cxx:
fix two unused argument warnings.
2005-04-12 00:38 rdm
* base/src/TView.cxx:
fix error in strcmp() checking viewer class name.
2005-04-12 00:33 rdm
* base/src/TView.cxx:
back port of TView fixing erroneous dependency of libCore on libGpad.
2005-04-11 23:57 brun
* foam/src/TFoam.cxx:
Fix URL with gif files
2005-04-11 19:48 brun
* gl/src/CsgOps.cxx:
From Axel
Fix portability problem under VC++7.0
2005-04-11 17:55 brun
* base/src/TSystem.cxx, meta/src/TCint.cxx:
From Philippe:
This patch allows the usage of directory with space in the
list of include directories used by ACLiC.
2005-04-11 16:59 rdm
* xrootd/src/xrootd-20041124-0752.src.tgz:
fix a fatal with anonymous statis struct in gcc4.0:
struct {const char *opname; Access_Operation oper;} optab[] =
to
struct optab_struct {const char *opname; Access_Operation oper;} optab[] =
2005-04-11 16:46 rdm
* configure:
remove some non-portable shell code.
2005-04-11 16:37 rdm
* macros/.cvsignore:
ignore html.C.
2005-04-11 16:35 rdm
* configure, config/html.C.in:
From Christian Holm:
Patch to configure in which I fixed the problem about building the Debian
packages on ia64, and a mistype that prevented Clarens from being build
on Debian. Also, I changed the `check_symbol' function. First of all, it
would always fail if the library was in `/usr/lib' as that was never
prepended to the file name. Secondly, it would always fail if you had a
stripped shared library, which is the common thing if the library is in
`/usr/lib'. I introduced a test that uses the compiler/linker (via
`config/Makefile.<arch>') to do a simple test program that calls the
specified function, and then tries to link to the specified library.
If that succeeds, the test succeeds. Note, this is more or less what
Autoconf does for you.
Plus added the template `build/misc/html.C.in' which will generate
`macros/html.C' according to the optional packages that were built.
2005-04-11 14:25 brun
* graf/inc/TLegend.h:
Remove the specifier *MENU from the following functions:
virtual void EditEntryAttFill();
virtual void EditEntryAttLine();
virtual void EditEntryAttMarker();
virtual void EditEntryAttText();
2005-04-11 13:52 brun
* test/RootShower/: MyEvent.cxx, MyParticle.cxx, RSVersion.h:
From Bertrand Bellenot:
Suppression of a few potential memory leaks.
2005-04-11 12:44 brun
* base/src/TView.cxx:
Remove an explicit dependency on TViewer3DPad
2005-04-11 12:32 rdm
* treeplayer/src/TTreePlayer.cxx:
fix small typo in comment.
2005-04-11 12:31 rdm
* foam/: inc/TFoamVect.h, src/TFoamVect.cxx:
GetDim() instead of returning a "const int &" just return an "int".
2005-04-11 12:15 rdm
* base/src/TSystem.cxx:
support $$ in file names, $$ expands, like in shell, to pid, e.g.:
TFile::Open("aap-$$.root", "recreate");
The $$ was already supported by rootd.
2005-04-11 11:23 brun
* main/src/: g2root.f, g2rootold.f:
From Federico Carminati:
To keep gfortran from complaining. These are reasonable.
2005-04-11 10:40 brun
* gpad/: inc/LinkDef.h, inc/TViewer3DPad.h, src/TViewer3DPad.cxx:
From Richard Maunder:
Added missing ClassImp/ClassDefs.
2005-04-11 08:02 brun
* foam/src/TFoam.cxx, tutorials/foam_demo.C:
From S.Jadach
Some corrections (version number and change of name in foam_demo.C)
2005-04-10 10:05 brun
* base/src/TROOT.cxx:
Modify TROOT::FindObject to automatically call FindObjectAny
when the argument "name" contains at least one "/".
With this change, the comments in TFolder are OK.
2005-04-08 22:57 brun
* README/CREDITS:
Correct Stanislaw Jadach 's email address
2005-04-08 19:11 brun
* tutorials/vavilov.C:
From Anna Kreshuk
New tutorial illustrating teh new TMath::Vavilov function
2005-04-08 18:59 brun
* README/CREDITS:
Add Stanislaw Jadach and Pawel Sawicki for the development of the FOAM classes
2005-04-08 18:45 brun
* base/: inc/TMath.h, src/TMath.cxx:
From Anna Kreshuk
Add the new following functions in TMath:
Double_t TMath::Vavilov(Double_t x, Double_t kappa, Double_t beta2)
//Returns the value of the Vavilov density function
//Parameters: 1st - the point were the density function is evaluated
// 2nd - value of kappa (distribution parameter)
// 3rd - value of beta2 (distribution parameter)
//The algorithm was taken from the CernLib function vavden(G115)
//Reference: A.Rotondi and P.Montagna, Fast Calculation of Vavilov distribution
//Nucl.Instr. and Meth. B47(1990), 215-224
//Accuracy: quote from the reference above:
//"The resuls of our code have been compared with the values of the Vavilov
//density function computed numerically in an accurate way: our approximation
//shows a difference of less than 3% around the peak of the density function, slowly
//increasing going towards the extreme tails to the right and to the left"
Double_t TMath::VavilovI(Double_t x, Double_t kappa, Double_t beta2)
//Returns the value of the Vavilov distribution function
//Parameters: 1st - the point were the density function is evaluated
// 2nd - value of kappa (distribution parameter)
// 3rd - value of beta2 (distribution parameter)
//The algorithm was taken from the CernLib function vavden(G115)
//Reference: A.Rotondi and P.Montagna, Fast Calculation of Vavilov distribution
//Nucl.Instr. and Meth. B47(1990), 215-224
//Accuracy: quote from the reference above:
//"The resuls of our code have been compared with the values of the Vavilov
//density function computed numerically in an accurate way: our approximation
//shows a difference of less than 3% around the peak of the density function, slowly
//increasing going towards the extreme tails to the right and to the left"
Double_t TMath::LandauI(Double_t x)
//Returns the value of the Landau distribution function at point x.
//The algorithm was taken from the Cernlib function dislan(G110)
//Reference: K.S.Kolbig and B.Schorr, "A program package for the Landau
//distribution", Computer Phys.Comm., 31(1984), 97-111
2005-04-08 18:29 rdm
* foam/: Module.mk, inc/TFoam.h, inc/TFoamCell.h,
inc/TFoamIntegrand.h, inc/TFoamMaxwt.h, inc/TFoamVect.h,
src/TFoam.cxx, src/TFoamCell.cxx, src/TFoamIntegrand.cxx,
src/TFoamMaxwt.cxx, src/TFoamVect.cxx:
A number of small changes:
- made many getters const
- changed many includes in the headers to forward declaration
- removed "const" from non- pointer and ref basic types in function arguments
- added //author lines
- corrected cvs ident line to include "root/foam"
2005-04-08 18:11 brun
* foam/: inc/TFoamVect.h, src/TFoamVect.cxx:
Fix a portability problem (solving also a naming problem).
Replace static member fchat by gDebug
2005-04-08 16:48 brun
* config/Makefile.depend:
I forgot to add the lib dependencies for Windows
2005-04-08 16:42 brun
* config/Makefile.depend:
Add dependencies of foam on hist
2005-04-08 16:38 brun
* foam/src/: TFoam.cxx, TFoamMaxwt.cxx:
Fix portability problem (replace fabs by TMath::Abs)
2005-04-08 16:29 brun
* Makefile:
Add the new foam package
2005-04-08 16:29 brun
* tutorials/: foam_README, foam_demo.C, foam_demopers.C,
foam_kanwa.C:
Add new tutorials demonstrating the new package FOAM
2005-04-08 16:27 brun
* foam/: Module.mk, inc/LinkDef.h, inc/TFoam.h, inc/TFoamCell.h,
inc/TFoamIntegrand.h, inc/TFoamMaxwt.h, inc/TFoamVect.h,
src/TFoam.cxx, src/TFoamCell.cxx, src/TFoamIntegrand.cxx,
src/TFoamMaxwt.cxx, src/TFoamVect.cxx:
New package FOAM:
// Authors:
// S. Jadach and P.Sawicki
// Institute of Nuclear Physics, Cracow, Poland
// Stanislaw. Jadach@ifj.edu.pl, Pawel.Sawicki@ifj.edu.pl
//
// What is FOAM for?
// =================
// * Suppose you want to generate randomly points (vectors) according to
// an arbitrary probability distribution in n dimensions,
// for which you supply your own subprogram. FOAM can do it for you!
// Even if your distributions has quite strong peaks and is discontinuous!
// * FOAM generates random points with weight one or with variable weight.
// * FOAM is capable to integrate using efficient "adaptive" MC method.
// (The distribution does not need to be normalized to one.)
for more info, see class TFoam documentation
2005-04-08 15:42 rdm
* net/inc/TUrl.h:
make GetSpecialProtocols() public.
2005-04-07 18:49 brun
* html/src/THtml.cxx:
From Axel:
Fix for a typo
2005-04-07 18:20 brun
* gpad/src/TCreatePrimitives.cxx:
From Olivier:
- Some log scales support was missing
2005-04-07 17:54 brun
* base/inc/RVersion.h, build/version_number:
Start development cycle 4.03/05
2005-04-07 16:43 rdm
* base/inc/Rtypes.h, base/inc/TDatime.h, base/inc/TMD5.h,
base/inc/TStorage.h, base/inc/TTime.h, base/inc/TVirtualGL.h,
base/src/TBuffer.cxx, base/src/TEnv.cxx, gl/inc/TArcBall.h,
gl/src/TGLSceneObject.cxx, graf/inc/TAttImage.h,
gui/inc/TGDimension.h, gui/inc/TGMdiMainFrame.h,
gui/inc/TGNumberEntry.h, matrix/inc/TMatrixDCramerInv.h,
matrix/inc/TMatrixDSymCramerInv.h, matrix/inc/TMatrixDUtils.h,
matrix/inc/TMatrixFCramerInv.h, matrix/inc/TMatrixFSymCramerInv.h,
matrix/inc/TMatrixFUtils.h, netx/inc/TXUnsolicitedMsg.h,
pyroot/inc/TPython.h, rint/inc/TTabCom.h, x3d/inc/TViewerX3D.h:
Fix many warnings generated by the latest gcc 4.0 about classes with
virtual functions (all classes having a ClassDef) that did not have a
virtual dtor.
2005-04-07 16:19 brun
* cint/lib/prec_stl/complex:
Add a missing
#pragma endif"
statement.
As a result geant_vmc cannot compile.
Thanks to Vladimir Volnyhk for reporting the problem
2005-04-07 15:28 brun
* base/src/TKey.cxx, tree/src/TBasket.cxx, tree/src/TBranch.cxx,
tree/src/TBranchElement.cxx, tree/src/TTree.cxx:
From Markus Frank
TTree::Fill returns -1 if an error occurs during Fill
2005-04-07 14:07 brun
* test/RootShower/MyParticle.cxx:
From Bertrand:
Small correction on the last patch.
2005-04-07 12:57 brun
* tree/src/: TNtuple.cxx, TNtupleD.cxx, TTree.cxx:
Add a patch from Chris Roat skipping lines starting with "#"
when creating a Tree from an ascii file.
2005-04-07 09:54 brun
* test/RootShower/: MyEvent.cxx, MyEvent.h, MyParticle.cxx,
MyParticle.h, RSVersion.h, RootShower.cxx:
From Bertrand Bellenot:
Moved fTracks (TObjArray of TPolyline3D) from MyEvent to MyParticle class.
This is a more suitable location, and it allows a better particle energy color rendering.
2005-04-06 17:56 brun
* proof/: inc/TProofDraw.h, src/TProofDraw.cxx:
From Philippe:
Template implementation should be in header files (especially when the
template class contains a ClassDef).
2005-04-06 15:49 rdm
* freetype/Module.mk:
don't use system zlib on aix5.
2005-04-06 15:09 rdm
* xmlparser/inc/TSAXParser.h:
correct date in copyright.
2005-04-06 15:03 brun
* hist/: inc/TGraphDelaunay.h, src/TGraphDelaunay.cxx:
from Olivier
- Postpone the creation of the triangles data structure and the hull
finding. They are now done only when really needed. This increases the
performances in cases where triangles and hull are not useful, for
instance when a TGraph2D is drawn with option "P" only.
2005-04-06 13:03 rdm
* proof/: inc/TProofDraw.h, src/TProofDraw.cxx:
some cosmetics.
2005-04-06 12:55 rdm
* proof/: inc/LinkDef.h, inc/TProofDraw.h, src/TProofDraw.cxx:
Several critical includes were missing. Remain several warnings on Win32,
but no fatals.
2005-04-06 12:29 brun
* asimage/src/libAfterImage.tar.gz:
New version removing debug statements for the alpha version.
2005-04-06 12:12 brun
* gl/src/CsgOps.cxx:
From Richard:
Another fix - I have a nasty feeling this might just reveal another
similar problem - there are a lot of typenames all over the place (which
is correct) but CC seems to be v flakey on them.
2005-04-06 12:01 rdm
* proof/: inc/LinkDef.h, inc/TPacketizer2.h, inc/TProofDraw.h,
inc/TProofVarArray.h, src/TPacketizer.cxx, src/TPacketizer2.cxx,
src/TProofDraw.cxx, src/TProofVarArray.cxx:
From Marek:
- removed TProofVarArray
- introduced TProofVectorContainer<T> which holds an std::vector<T>
and implements Merge(TCollection*)
- made TProofDrawListOfGraphs and TProofDrawListOfPolyMarkers3D use
std::vector and TProofVectorContainer<T>.
- added eventlist handling to TPacketizer2
2005-04-06 11:51 rdm
* winnt/src/TWinNTSystem.cxx:
Fix in ExpandPathName() so that : in URL's are not replaced by ;.
Needed to access rfio:/ and root:// files on Windows.
2005-04-06 11:43 brun
* gl/src/: CsgOps.cxx, TViewerOpenGL.cxx:
From Richard Maunder:
Fix a portability problem on Solaris
2005-04-06 11:32 brun
* qt/src/: GQtGUI.cxx, TGQt.cxx, TQtWidget.cxx:
From Ilka and Valeri:
In the attached patch are the Qt changes sent by Valeri yesterday. The
last modification required by him is also included. The major problem
remains the different font size related to the qt-version 3.1 that
comes with SLC3. Many SegV cases when running guitest.C persist but we
need more time to solve them case by case.
2005-04-06 11:10 rdm
* build/package/lib/makebuilddepend.sh:
From Antonio Amorim:
extend the mysqlclient-dev dependency to include newer versions.
2005-04-06 08:23 brun
* gl/src/CsgOps.cxx:
Comment use of non portable cassert
2005-04-06 08:09 brun
* gui/src/TGMenu.cxx:
From Bertrand Bellenot
Solves the wrongly highlighted rectangle in TGMenuTitle.
2005-04-05 19:12 brun
* base/inc/RVersion.h, build/version_number:
Stamp development version 4.03/04
2005-04-05 18:10 brun
* base/src/TMath.cxx:
From Eddy Offermann
Improve comments in the Gamma functions.
2005-04-05 17:56 rdm
* test/guitest.cxx, tutorials/guitest.C:
From Valeriy:
fix a segv discovered by Ilka.
2005-04-05 15:45 rdm
* asimage/: Module.mk, src/libAfterImage.tar.gz:
add latest libAfterImage and make sure that it uses the ROOT provided
libfreetype if the builtin version is not used.
2005-04-05 15:38 brun
* geom/src/TGeoVolume.cxx, geompainter/src/TGeoPainter.cxx,
tutorials/geodemo.C:
From Andrei Gheata:
- raytracing problem fixed
- extrusions/overlaps now visible in GL
- minor modification in geodemo.C
2005-04-05 15:12 rdm
* gui/src/TGProgressBar.cxx:
From Valeri Fine:
explicitly set the fill style to kFillSolid.
2005-04-05 14:50 brun
* base/src/TView.cxx:
From Richard Maunder:
fix for the 2D pad problems, after 3D box
rotation.
2005-04-05 14:47 brun
* matrix/src/: TDecompLU.cxx, TMatrixD.cxx, TMatrixDCramerInv.cxx,
TMatrixF.cxx, TMatrixFCramerInv.cxx:
From Eddy Offermann
Add a Warning in case of illegal matrix operations.
2005-04-05 12:17 brun
* geom/: inc/TGeoBoolNode.h, src/TGeoBoolNode.cxx,
src/TGeoCone.cxx:
From Andrei Gheata:
- TGeoCone/TGeoConeSeg::ComputeNormal() - fix the Oz component
- TGeoBoolNode: fast computation of normal
2005-04-05 10:54 brun
* geom/src/: TGeoCompositeShape.cxx, TGeoMatrix.cxx,
TGeoVolume.cxx, TGeoXtru.cxx:
From Mihaela Gheata:
some additional fixes. CMS muon is now ok (some rotations in
TGeoCombiTrans were not registered)
I also fixed SavePrimitive for composite shapes - tested for csgdemo.C
(the logic there was not at all working). I hope it works also with lhcb
- if not, please send me the geometry file. There is also a fix in
TGeoXtru::SavePrimitive.
For testing SaveAs, you should regenerate the tested geometries (not
importing the .root file generated before these changes). Otherwise some
matrices can still get wrong.
2005-04-05 07:20 brun
* pyroot/src/: Converters.cxx, RootWrapper.cxx:
From Wim Lavrijsen:
o) allow for non-existing sys.argv (e.g. in apache mod_python)
o) remove wrong buflen checking for void array
2005-04-04 17:00 brun
* geom/src/: TGeoCone.cxx, TGeoManager.cxx, TGeoMatrix.cxx,
TGeoVolume.cxx:
From Mihaela Gheata:
I attached the diffs for few fixes that I made for SavePrimitive:
- fix in TGeoCone::SavePrimitive
- Added support for gsposp in TGeoVolume (now works with ALICE geometry)
- fix in TGeoCombiTrans for correctly registering rotation component.
- modified TGeoManager::Export() to export geometry as C++ macro:
for file names ending with .root work as before
other extensions (e.g. .C) saves as C++ macro
2005-04-04 11:30 brun
* tutorials/: csgdemo.C, geodemo.C:
From Timur;
updates in the composite shapes examples
2005-04-04 11:29 brun
* geom/src/TGeoBoolNode.cxx:
From Timur:
Fix for nested composite shapes (should solve LHCb problem)
2005-04-04 09:06 brun
* gpad/: inc/TViewer3DPad.h, src/TViewer3DPad.cxx:
Move the dummy implementation of the following functions to TViewerPad3D.cxx
virtual void OpenComposite(const TBuffer3D & buffer, Bool_t * addChildren = 0);
virtual void CloseComposite();
virtual void AddCompositeOp(UInt_t operation);
2005-04-02 09:50 brun
* hist/src/TH1.cxx:
Protect the TH1 destructor when deleting objects in the list of functions.
It may happen that one of the objects in this list is also included
in other lists and has already been deleted.
2005-04-01 22:20 brun
* tutorials/csgdemo.C:
From Olivier:
-fix a typo
2005-04-01 19:42 brun
* gpad/: inc/TCreatePrimitives.h, inc/TPad.h,
src/TCreatePrimitives.cxx, src/TPad.cxx:
From Olivier
- New class TCreatePrimitives (in gpad). The functions in this static
class are called by TPad::ExecuteEvent to create new primitives in gPad
from the TPad toolbar.
2005-04-01 18:19 rdm
* proof/src/TProof.cxx:
from Maarten:
Condor related improvement.
2005-04-01 15:56 brun
* tutorials/csgdemo.C:
New tutorial by Timur illustrating graphics (pad & GL) with composite shapes
2005-04-01 15:53 brun
* base/inc/TBuffer3D.h, base/inc/TBuffer3DTypes.h,
base/inc/TVirtualViewer3D.h, base/src/TBuffer3D.cxx,
geom/inc/TGeoBoolNode.h, geom/inc/TGeoCompositeShape.h,
geom/inc/TGeoNode.h, geom/src/TGeoBBox.cxx,
geom/src/TGeoBoolNode.cxx, geom/src/TGeoCompositeShape.cxx,
geom/src/TGeoNode.cxx, geompainter/src/TGeoPainter.cxx,
gl/Module.mk, gl/inc/CsgOps.h, gl/inc/TGLSceneObject.h,
gl/inc/TViewerOpenGL.h, gl/src/CsgOps.cxx,
gl/src/TGLSceneObject.cxx, gl/src/TViewerOpenGL.cxx,
gpad/inc/TViewer3DPad.h, tutorials/geodemo.C, x3d/inc/TViewerX3D.h:
First attempt to introduce new Timur's code supporting composite shapes.
This code must still be validated on non Linux platforms.
2005-04-01 15:51 brun
* gui/src/: TGListBox.cxx, TGMenu.cxx:
From Ilka:
The attached patch of Valeriy O. fixes the side effects introduced by the
last changes in TGListBox.cxx TGMenu.cxx of Valeri Fine.
2005-04-01 07:06 brun
* gui/src/: TGListBox.cxx, TGMenu.cxx:
From Valeri Fine:
Fix a few problems when setting the window background and visible
with the Qt version.
2005-04-01 01:57 rdm
* configure, asimage/Module.mk,
cint/iosenum/iosenum.linuxppc64gcc3, config/ARCHS,
config/Makefile.linuxppc64gcc, config/root-config.in,
base/inc/RConfig.h, freetype/Module.mk, test/Makefile.arch:
Finally made port to Linux PPC 64. This is a big-endian Linux running
on 64bit PowerPC (IBM and Apple G5).
2005-04-01 01:17 rdm
* config/Makefile.linuxx8664gcc:
add -m64 also to linker flags.
2005-03-31 23:36 rdm
* freetype/Module.mk:
make sure to compile in 64bit mode on x86-64.
2005-03-31 23:17 brun
* cint/src/var.c:
From Philippe:
In var.c the function G__getvariable() relies on G__var_type.
However this can be changes in the calls to G__GetSpecialObject
so we need to cache/restore it.
2005-03-31 22:13 brun
* unix/src/TUnixSystem.cxx:
From Philippe:
This patch works around yet another library loading issue on MacOS.
When using PyROOT, the root libraries are linked in as part of
libPyROOT. When executing gSystem->GetLinkedLibraries(), it
executes otool on the current executable. When using python,
this means it finds only the library from the python executable
itself. Since it finds some libraries, this indicates to
GetLibraries that it should __not__ used the default link line.
On MacOS, since there is one library (libSystem.B) linked in
python, this means that the system does not know that it has
already loaded the core libraries (and hence the autoloader
reload them and since MacOS effectively will load the same
library multiple time, this can cause problem).
On linux, it happens to work because GetLinkedLibs only
keeps the library ending in .so, hence filtering the libraries
ending in .so.2 (or any variation). The result is that it looks
like python has no linked libraries and the default list is used
and everything works fine.
2005-03-31 20:56 brun
* meta/src/TStreamerInfo.cxx:
Comment out an illegal assert statement
2005-03-31 19:52 brun
* meta/src/TStreamerInfo.cxx, tree/src/TBranchElement.cxx:
From Philippe:
TStreamerInfo::PrintValue
lookup the TStreamerElement only when needed
add printing of array of fBits (need in MakeClass mode)
TBranchElement::PrintValue
In MakeClass mode, print the char as unsigned char instead
of as strings.
2005-03-31 18:10 brun
* base/src/TSystem.cxx:
From Philippe:
This patch insures that ACLiC first look at the local dependency file
even if it is not writable. It now uses the emergency location if
and only if it needs to write a new dependency file and the local
directory is not writable.
2005-03-31 17:11 rdm
* freetype/src/.cvsignore:
ignore the freetype-2.1.9 directory.
2005-03-31 17:10 rdm
* asimage/Module.mk:
use explicitly the -m64 flag for x86_64.
2005-03-31 16:27 rdm
* freetype/src/win/: freetype.dep, freetype.mak:
From Bertrand:
Win32 makefiles for new freetype library.
2005-03-31 16:25 rdm
* freetype/: Module.mk, src/freetype-2.1.3.tar.gz,
src/freetype-2.1.9.tar.gz:
move to latest freetype version, backward compatible, but providing
better support for MacOS X and PPC64. This version was released last
summer, so quite stable.
2005-03-31 14:51 brun
* gui/src/TRootContextMenu.cxx:
From Ilka:
The attached patch fixes the bug 2803: the test of kNotDeleted was
forgotten in the last changes of TRootContextMenu.cxx.
2005-03-30 23:09 brun
* tree/inc/TBranchElement.h, tree/src/TBranchElement.cxx,
treeplayer/src/TFormLeafInfo.cxx, treeplayer/src/TTreeFormula.cxx:
From Philippe:
TBranch::fOffset stores permanently the offset of the data member in the
object.
When the branch is reloaded without the library, this offset might be
incorrect.
We introduce SetupAddresses (called by GetEntry and TTreeFormula) which
insures
the offset are correctly set.
In case of a fixed size char array nested inside a collection, the indexing
was inconsistent (It is drawn as a string but one of the inner mechanism was
still using the fixed size to calculate the index)
In case of string (like char* or char array) was within a collection,
the TFormLeafInfo 'chain' was incorrectly set (it was not using the
fact the branch has the address of the collection instead of the
addresses of the container of the collection).
2005-03-30 21:20 brun
* pyroot/src/RootWrapper.cxx:
From Wim Lavrijsen,
Fix to run with python 2.2
2005-03-30 19:34 rdm
* proof/etc/proof.conf.sample:
From Maarten:
added comment on new flag for Condor.
2005-03-30 15:23 rdm
* configure:
fix problem with "which" usage (showed up on OpenBSD).
2005-03-30 13:21 rdm
* config/: Makefile.linuxx8664gcc, root-config.in:
use flag -m64 to explicitly compile in 64 bit mode (was default but
make it explicit).
2005-03-30 10:37 rdm
* proof/src/TCondor.cxx:
From Maarten:
small Condor log file naming change.
2005-03-30 09:19 brun
* matrix/src/: TMatrixD.cxx, TMatrixF.cxx:
From Eddy Offermann:
One more fix to support reading matrices stored with the old versions 3.10
2005-03-30 07:16 brun
* pyroot/: inc/TPyReturn.h, src/ClassMethodHolder.cxx,
src/ConstructorHolder.cxx, src/Executors.h, src/MethodHolder.cxx,
src/MethodHolder.h, src/ObjectProxy.cxx, src/ObjectProxy.h,
src/RootWrapper.cxx, src/TPyReturn.cxx:
From Wim Lavrijsen
for the benefit of roottest (and probably for more general use as well):
o) pass cli args on to TApplication
o) textual fixes in comments
In particular, this allows '-b' to propagate. Note though, that the proper
syntax is:
$ python mymacro.py -b
rather than "python -b mymacro.py".
2005-03-30 06:07 rdm
* proof/: inc/TProofPlayer.h, src/TProofPlayer.cxx:
From Maarten:
remove references to gProof.
2005-03-29 22:44 brun
* matrix/src/: TMatrixD.cxx, TMatrixF.cxx:
From Eddy Offermann:
Oops, I had the index offsets switched . The pathch corrects the
current cvs head .
2005-03-29 19:43 brun
* meta/src/TStreamerInfoReadBuffer.cxx:
From Philippe:
This patch insures that objects that did not save a variable size array
eventhough the index is non zero will be read properly.
2005-03-29 19:15 brun
* histpainter/src/THistPainter.cxx:
From Olivier:
- The revision 1.153 in THistPainter::PaintTitle (to take into account the
case of multi-lines title), produced a side effect: histogram titles
"K^{+}" and "K^{-}" had not the same size. This patch fixes the problem.
2005-03-29 17:42 rdm
* configure:
From Gerri:
correct Globus patch handling that got broken in Christian's big patch.
2005-03-29 15:10 rdm
* clib/src/Getline.c, config/Makefile.openbsd:
From Dmytro Kustov:
two more OpenBSD changes.
2005-03-29 14:51 rdm
* base/src/TSystem.cxx:
support TSystem helper plugin for xrootd. TXNetSystem coming soon.
2005-03-29 12:21 rdm
* thread/src/TWin32Mutex.cxx:
From Bertrand:
fix inconsistency in TryLock discovered by Gerri.
2005-03-29 12:11 brun
* win32gdk/src/TGWin32.cxx:
From Bertrand Bellenot:
Added a missing unlock in TGWin32.cxx
2005-03-29 12:06 brun
* graf/src/TPaveStats.cxx:
From Ilka:
changes in TPaveStats::SavePrimitives() for
saving the current Stat and Fit options in the generated C++ code.
2005-03-28 23:17 brun
* meta/src/TStreamerInfoReadBuffer.cxx,
treeplayer/src/TTreePlayer.cxx, utils/src/rootcint.cxx:
From Philippe
The following problems were found while running roottest on MacOS.
rootcint: Insure that the dimensions of
Int_t (*fArray)[3];
are properly recorded by the ShowMembers function
TStreamerInfo: Insure that the wrapper template function see
all modifications to the TStreamerInfo
TTreePlayer: In Scan insures that the entry number is printed
as a long long (aka with %lld).
2005-03-28 23:06 brun
* treeplayer/src/TTreeFormula.cxx:
From Philippe:
The following insure that TTreeFormula properly generate the
accessing code (TFormLeafInfos) in the case of character string
embedded in a an object with an STL collection.
2005-03-28 22:38 brun
* matrix/src/: TMatrixD.cxx, TMatrixDSym.cxx, TMatrixF.cxx:
From Eddy Offermann:
a small patch to correct the matrices for root < 4 :
In previous root versions, the matrix was stored column-wise,
now it is row-wise . With this patch the streamer will
correct column-wise stored matrices .
2005-03-28 22:32 brun
* qt/src/TGQt.cxx:
From Valeri Fine:
TGQt
- an extra protection against of the crash inside of the "destroyed
embedded" TCanvas objects introduced (Thanks M.Nikulin)
2005-03-26 10:48 brun
* base/src/TBuffer.cxx:
In the TBuffer Read functions, replace the test
if(n <=0 || n > fBufSize) return 0;
by a more strict test taking into account the size of the data type)
if(n <=0 ||n*sizeof(datatype) > fBufSize) return 0;
2005-03-26 08:02 brun
* cont/: inc/TRefArray.h, src/TRefArray.cxx:
From Philippe:
Fix for a problem reported by Reiner Hauser
I have a root file with a TBranchRef in it, to support
autoloading objects referenced via a TRef. This seems to work
fine with a single TRef in an object, but not the references
in a TRefArray.
2005-03-26 07:57 brun
* graf/src/TGraph.cxx:
From Axel Naumann:
VC7 has a problem with a method param in TGraph::Sort called greater (it
confuses it with std::greater). Attached patch fixes that.
2005-03-26 07:47 brun
* cont/inc/THashTable.h:
From Axel Naumann:
I need access to THashTable's rehash level (to temporarily disable it
while adding plenty of objects). There's no access to the rehash level
(maximum average collision allowed without rehashing), neither setters
nor getters. The attached patch implements them.
2005-03-26 07:40 brun
* qt/inc/TQtThread.h:
From Valeri Fine
In previous patch , forgot to delete the old function Warp and add
the function with the new signature.
2005-03-25 20:41 brun
* qt/: inc/TGQt.h, inc/TQtThread.h, inc/TVirtualX.interface.h,
src/GQtGUI.cxx, src/GQtGUIThread.cxx, src/TGQt.cxx,
src/TQtWidget.cxx:
From valeri Fine:
TGQt, TQtWidget
- Fixed the crash in the embedded TCanvas dtor (Thanks Maxim Nikulin)
TGQt, TVirtualX.interface.h, TGQtThread, GQtGUI GQtGUIThread
- New method SetBackground (a'la SetForeground) to change
the background color of the ROOT graphical context.
2005-03-24 19:37 brun
* treeplayer/src/: TFormLeafInfo.cxx, TTreeFormula.cxx:
From Philippe:
This update fixes a case where when drawing a collection within
a TClonesArray, the size of the TClonesArray was not properly read.
It also fixes a case where TTreeFormula was trying to drill trhough
a collection when it already has seen 2 variable dimensions.
2005-03-24 18:14 rdm
* build/package/: lib/makebuilddepend.sh, lib/makerpmspec.sh,
rpm/spec.in:
From Christian Holm:
fixes for the rpm build process, which now works.
2005-03-24 17:32 rdm
* proof/: inc/LinkDef.h, inc/TProofDraw.h, inc/TProofNTuple.h,
inc/TProofVarArray.h, src/TDrawFeedback.cxx, src/TProofDraw.cxx,
src/TProofNTuple.cxx, src/TProofVarArray.cxx:
From Marek:
rename TProofNTuple to TProofVarArray.
2005-03-24 15:27 brun
* cont/inc/TGenCollectionProxy.h,
cont/inc/TVirtualCollectionProxy.h,
cont/src/TEmulatedCollectionProxy.cxx,
cont/src/TEmulatedMapProxy.cxx, cont/src/TGenCollectionProxy.cxx,
meta/inc/TClassRef.h, meta/src/TClassRef.cxx:
From Markus Frank:
- Changed collection proxy classes to use the TClassRef structures.
- Removed virtuality for proxy initialization to allow usage in
constructor
2005-03-24 08:16 brun
* qt/src/: GQtGUI.cxx, TQtClientFilter.cxx, TQtWidget.cxx:
From Valeri fine:
TQtWidget:
- Extra documentation about Qt signal /slot available
TQtClientWidget
- Fix the "grab button" implementation. This correction disables
the Qt-based implementation of the X11 man page
the "pointer is not grabbed" clause:
//X11: ButtonPress event is reported if all of the following
// conditions are true:
// * The pointer is not grabbed, and the specified button is
logically
As result the scroll bar of the TGComboBox object is properly
grabbed (from the ROOT Gui point of view);
TGQt:
- Some optimization
use SetEraseColor method instead of setPaletteBackgroundColor
2005-03-24 08:13 brun
* cont/: inc/THashTable.h, src/THashTable.cxx:
From Axel:
a THashTable with a rehash level is incredibly inefficient when calling
AddAll(TCollection* col) on it. It rehashes ever single time an added
object brings it above the rehash level (which in turn adds all elements
added to far to a new THashTable) - this can happen very often, esp if
col->GetEntries()>>GetEntries().
The attached patch adds THashTable's own implementation of
TCollection::AddAll. Before calling TCollection::AddAll, it estimates
whether rehashing will be needed for the combined THashTable. Rehashing
before TCollection::AddAll means less elements will have to be copied to
the rehashed THashTable. The estimate is based on fSize, assuming an
ideal hash. If the collection wasn't rehashed before the call to
TCollection::AddAll, THashTable::AddAll will check for rehashing after
the collections have been merged.
The results should be exactly the same as with the old algorithm, only
the performance is many orders of magnitudes better, noticeable esp when
adding a larger collection.
2005-03-24 08:12 brun
* cont/inc/TCollection.h:
From Axel:
as you're probably aware, there is no common interface to get the number
of entries in collections. It's GetEntries() for all collections which
have a "reserved size", and GetSize() for all others.
The attached tiny patch introduces
virtual TCollection::GetEntries() { return GetSize();}
It returns GetSize() if GetEntries() is not re-implemented by the
derived class. It already is re-implemented for all classes for which
GetSize() returns something different than GetEntries(). Thus,
GetEntries() returns the number of entries for all collections.
2005-03-24 08:11 brun
* hist/src/TProfile2D.cxx:
Remove unused variable
2005-03-23 17:05 brun
* tutorials/: shapes.C, tree2.C, tree2a.C:
From Olivier:
- Now uses TPad::GetViewer3D() instead of the depreciated function
TPad::x3d().
2005-03-23 16:26 brun
* graf/src/TPaveStats.cxx:
From Olivier:
- In TPaveStats::Paint histograms' titles containing the "=" sign were not
displayed like a title but like a statistic parameter.
2005-03-23 13:41 brun
* hist/inc/TH1.h, hist/inc/TH2.h, hist/inc/TH3.h,
hist/inc/TProfile.h, hist/inc/TProfile2D.h, hist/src/TH1.cxx,
hist/src/TH2.cxx, hist/src/TH3.cxx, hist/src/TProfile.cxx,
hist/src/TProfile2D.cxx, proof/src/TProofDraw.cxx,
treeplayer/src/TSelectorDraw.cxx:
From Marek Biskup:
-Added options proofi and proofg to TProfile and TProfile2D
drawn with proof.
-Added support for "ICE" option (see TH1::Reset()) to TH2, TH3,
TProfile and TProfile2D::Reset().
-Rewritten Merge() in TH1, TH2, TH3, TProfile and TProfile2D
to support buffers. Changed the return type from Int_t to Long64_t.
2005-03-23 08:14 brun
* cint/src/newlink.c:
Part of the patch rootcint_8 was necessary to gey fOpenAndSleep in newlink.
2005-03-23 07:16 brun
* utils/src/rootcint.cxx:
From Philippe:
This new patch is a refinement of rootcint_8 and superseeds it.
(the change in newlink.c are the exact same, the change in rootcint
now cover both calls to rename).
2005-03-22 20:53 brun
* hist/inc/TFormula.h, treeplayer/inc/TTreeFormula.h,
treeplayer/src/TTreeFormula.cxx:
From Philippe:
The attached patch protect TTreeFormula against missing leaves.
In case of missing leaf, it evaluate the whole formula at zero value.
This is not ideal, but adding the ability to skip entries with missing
leaves would require significant change in TSelectorDraw (which itself
is likely to be rewritten).
2005-03-22 19:02 brun
* base/src/TBuffer.cxx:
From Philippe
A protection was missing in the previous fix.
2005-03-22 18:10 brun
* base/src/TBuffer.cxx:
From Philippe:
The schema evolution for foreign class in ROOT 3.10.02 was requiring
the user to set its own class version (via RootClassVersion).
In ROOT 4.00 we introduce a checksum to remove the need for the user
supplied class version for foreign class.
However the auto-discovery of the proper TStreamerInfo base on
the checksum was __only__ enabled by file written by ROOT 4.00.00
and above.
This patch includes code to enabled this auto-discovery (when
needed) for older files.
2005-03-22 17:57 brun
* gpad/src/TPad.cxx:
From Otto Schaile
New version of TPad::CreateNewPolyLine that shows correctly
the line segments when a new PolyLine or CutG is created
inside subpads.
2005-03-22 17:23 rdm
* cint/iosenum/iosenum.openbsd, unix/src/TUnixSystem.cxx:
From Dmytro Kustov:
final OpenBSD patch.
2005-03-22 11:00 brun
* treeplayer/src/TSelectorDraw.cxx:
Add support for options "profi" and "profg" also for TProfile2D
2005-03-22 06:58 brun
* pyroot/ROOT.py:
From Wim Lavrijsen
Fix for Solaris.
2005-03-22 06:33 rdm
* gl/Module.mk:
Remove obsolete reference to IVLIB.
2005-03-22 06:33 rdm
* Makefile:
avoid including module gl twice for win32.
2005-03-21 23:17 brun
* treeplayer/src/TTreeFormula.cxx:
From Philippe,
Minor fix to avoid a warning from valgrind
2005-03-21 22:48 rdm
* configure:
small correction.
2005-03-21 22:42 rdm
* Makefile, configure, alien/Module.mk, asimage/Module.mk,
build/misc/root.m4, build/unix/makecintdlls.sh, chirp/Module.mk,
config/Makefile.in, dcache/Module.mk, etc/rootd,
freetype/Module.mk, gl/Module.mk, globusauth/Module.mk,
man/man1/cint.1, man/man1/g2rootold.1, man/man1/makecint.1,
man/man1/memprobe.1, man/man1/olbd.1, man/man1/proofd.1,
man/man1/rlibmap.1, man/man1/root-config.1, man/man1/rootcint.1,
man/man1/rootd.1, man/man1/ssh2rpd.1, man/man1/xrootd.1,
graf/Module.mk, krb5auth/Module.mk, ldap/Module.mk,
mysql/Module.mk, net/Module.mk, netx/Module.mk, pgsql/Module.mk,
pyroot/Module.mk, qt/Module.mk, rfio/Module.mk, rpdutils/Module.mk,
ruby/Module.mk, sapdb/Module.mk, srputils/Module.mk,
win32gdk/Module.mk, x11ttf/Module.mk, xmlparser/Module.mk,
xrootd/Module.mk:
From Christian Holm Christensen:
* New Debian and RedHat rpm packaging scripts.
* Added a description to `build/package/debian/README.Debian' on
how to add a new package. It's not that complicated so it
should be a simple thing to add a new package, even for some
with little or no experience with RPMs or DEBs.
* When searching for the Oracle client libraries, I added the
directories `/usr/lib/oracle/*/client/lib' and
`/usr/include/oracle/*/client' - as these are the paths that the
RPMs install into.
* I added the packages `root-plugin-krb5' and
`root-plugin-oracle'.
* The library `libXMLIO' is in `libroot'.
* The package `root-plugin-xml' contains the XML parser.
* I fixed an cosmetic error in `build/misc/root.m4'. The
definition of `ROOT_PATH' should be quoted, otherwise aclocal
will complain.
* In the top-level `Makefile' I pass an additional argument to
`makecintdlls' - namely `$(ROOTCINTTMP)'. In `makecintdlls' I
use that argument to make the various dictionaries for
`lib...Dict.so'. Originally, the script used plain `rootcint'.
However, as `rootcint' may not be in the path yet, or the one in
the path may be old, this failed. Hence, I use what we know is
there - namely the newly build `rootcint_tmp'. BTW, what are
these shared libraries, and where do they belong? I guess they
are specific to ROOT, and not used by plain `CINT'. For now, I
put them in `libroot'.
* Made the two `virtual' packages `root-db-client' - provided the
DB plugins, and `root-fitter' provided by `root-plugin-minuit'
and `root-plugin-fumili'. Note, the virtual package
`root-file-server' provided by `root-rootd' and `root-xrootd'
already existed in the previous patch.
* Note, I added the directory `build/package/debian/po' which is
for translations of DebConf templates. DebConf is Debians very
advanced package configuration interface. It presents the user
with a set of questions in some sort of `GUI' based on how much
the user would like to change. These `dialogs' can be
translated quite easily. As an example, I translated the
questions used by the `ttf-root-installer' package into Danish.
I'm sure someone can translate them into German, French,
Italien, Spanish, and so on.
2005-03-21 22:34 rdm
* build/package/: common/root-cint.copyright, debian/changelog,
debian/root-bin.menu.in, debian/root-bin.mime, lib/makedebdir.sh,
lib/makerpmspec.sh:
From Christian Holm Christensen:
changed files for the new debian and rpm packaging.
2005-03-21 22:33 rdm
* build/package/: common/libroot-dev.control,
common/libroot-dev.install.in, common/libroot.control,
common/libroot.install.in, common/root-bin.control,
common/root-bin.install.in, common/root-cint.control,
common/root-cint.install.in, common/root-doc.control,
common/root-doc.install.in, common/root-plugin-alien.control,
common/root-plugin-asimage.control,
common/root-plugin-castor.control,
common/root-plugin-chirp.control,
common/root-plugin-clarens.control,
common/root-plugin-dcache.control,
common/root-plugin-fumili.control, common/root-plugin-gl.control,
common/root-plugin-globus.control,
common/root-plugin-hbook.control,
common/root-plugin-hbook.install.in,
common/root-plugin-krb5.control, common/root-plugin-ldap.control,
common/root-plugin-minuit.control, common/root-plugin-mlp.control,
common/root-plugin-mysql.control, common/root-plugin-netx.control,
common/root-plugin-oracle.control, common/root-plugin-peac.control,
common/root-plugin-pgsql.control, common/root-plugin-proof.control,
common/root-plugin-pythia5.control,
common/root-plugin-pythia6.control,
common/root-plugin-python.control,
common/root-plugin-python.install.in,
common/root-plugin-qt.control, common/root-plugin-quadp.control,
common/root-plugin-ruby.control, common/root-plugin-sapdb.control,
common/root-plugin-srp.control, common/root-plugin-venus.control,
common/root-plugin-xml.control, common/root-proofd.control,
common/root-proofd.install.in, common/root-rootd.control,
common/root-rootd.install.in, common/root-xrootd.control,
common/root-xrootd.install.in, common/ttf-root-installer.control,
common/ttf-root.control, common/ttf-root.install.in,
debian/README.Debian, debian/compat, debian/control.in,
debian/copyright, debian/root-cint.copyright, debian/root-doc.docs,
debian/root-proofd.default, debian/root-proofd.init.in,
debian/root-proofd.postinst.in, debian/root-proofd.prerm,
debian/root-rootd.default, debian/root-rootd.init.in,
debian/root-rootd.postinst.in, debian/root-rootd.postrm,
debian/root-rootd.preinst, debian/root-rootd.prerm,
debian/root-xrootd.default, debian/root-xrootd.init.in,
debian/rules, debian/ttf-root-installer.config,
debian/ttf-root-installer.copyright,
debian/ttf-root-installer.postinst.in,
debian/ttf-root-installer.prerm.in,
debian/ttf-root-installer.templates, debian/ttf-root.copyright,
debian/po/POTFILES.in, debian/po/dk.po, debian/po/templates.pot,
lib/makebuilddepend.sh, lib/makelist, lib/makelists.sh,
rpm/libroot.post, rpm/root-cint.post, rpm/root-proofd.post,
rpm/root-proofd.preun, rpm/root-rootd.post, rpm/root-rootd.postun,
rpm/root-rootd.pre, rpm/root-rootd.preun, rpm/spec.in,
rpm/ttf-root-installer.post, rpm/ttf-root-installer.preun:
From Christian Holm Christensen:
new debian and rpm packaging files.
2005-03-21 22:25 rdm
* build/package/: common/README, common/general.dscr,
common/libroot-dev.dscr, common/libroot-dev.files,
common/libroot.conffiles, common/libroot.dscr,
common/libroot.files, common/libroot.shlibs,
common/root-bin.conffiles, common/root-bin.dscr,
common/root-bin.files, common/root-cint.dscr,
common/root-cint.files, common/root-cint.shlibs,
common/root-daemon.dscr, common/root-daemon.files,
common/root-doc.dscr, common/root-doc.files, common/root-gl.dscr,
common/root-gl.files, common/root-gl.shlibs,
common/root-mysql.dscr, common/root-mysql.files,
common/root-mysql.shlibs, common/root-pgsql.dscr,
common/root-pgsql.files, common/root-pgsql.shlibs,
common/root-pythia.dscr, common/root-pythia.files,
common/root-pythia.shlibs, common/root-rootd.dscr,
common/root-sapdb.dscr, common/root-sapdb.files,
common/root-sapdb.shlibs, common/root-shift.dscr,
common/root-shift.files, common/root-shift.shlibs,
common/root-srp.dscr, common/root-srp.files,
common/root-srp.shlibs, common/root-venus.dscr,
common/root-venus.files, common/root-venus.shlibs,
common/root-zebra.dscr, common/root-zebra.files,
common/root-zebra.shlibs, debian/copyright.in,
debian/head.control.in, debian/libroot-dev.control.in,
debian/libroot.control.in, debian/root-bin.control.in,
debian/root-cint.control.in, debian/root-cint.copyright.in,
debian/root-daemon.control.in, debian/root-daemon.postinst.in,
debian/root-daemon.postrm.in, debian/root-daemon.preinst.in,
debian/root-daemon.prerm.in, debian/root-doc.control.in,
debian/root-gl.control.in, debian/root-mysql.control.in,
debian/root-pgsql.control.in, debian/root-pythia.control.in,
debian/root-shift.control.in, debian/root-srp.control.in,
debian/root-venus.control.in, debian/root-zebra.control.in,
debian/rules.in, debian/watch, lib/makedebchangelog.sh,
lib/makedebclean.sh, lib/makedebconffiles.sh,
lib/makedebcontrol.sh, lib/makedebcopyright.sh, lib/makedebdocs.sh,
lib/makedebexamples.sh, lib/makedebfiles.sh, lib/makedebscr.sh,
lib/makedebshlocal.sh, lib/makerpmclean.sh, lib/makerpmfiles.sh,
lib/makerpmspecs.sh, rpm/head.spec.in, rpm/libroot-dev.spec.in,
rpm/libroot.spec.in, rpm/root-bin.spec.in, rpm/root-cint.spec.in,
rpm/root-daemon.spec.in, rpm/root-doc.spec.in, rpm/root-gl.spec.in,
rpm/root-mysql.spec.in, rpm/root-pgsql.spec.in,
rpm/root-pythia.spec.in, rpm/root-sapdb.spec.in,
rpm/root-shift.spec.in, rpm/root-srp.spec.in,
rpm/root-venus.spec.in, rpm/root-zebra.spec.in, rpm/tail.spec.in:
From Christian Holm Christensen:
remove obsolete debian and rpm packaging files. New ones coming.
2005-03-21 18:22 brun
* g3d/src/: TPolyLine3D.cxx, TPolyMarker3D.cxx:
From Olivier:
- Protection added in TPolyLine3D::Paint and TPolyMarker3D::Paint: if the
number of points is less or equal to zero (nothing to paint), these
methods perform a "return" statement. Without this protection we get a
"segmentation violation" TVirtualViewer3D::AddObject.
2005-03-21 17:20 rdm
* tree/: inc/LinkDef.h, inc/TChain.h, inc/TChainProof.h,
inc/TProofChain.h, src/TChain.cxx, src/TChainProof.cxx,
src/TDSet.cxx, src/TProofChain.cxx:
change name of TProofChain to TChainProof, this class does not directly
belong to PROOF but it provides a chain proxy that runs on PROOF.
To compile you need to clean *.d's that reference the old file. To find these
files do: rm `find . -name \*.d -exec grep -l TProofChain {} \;`
2005-03-21 17:14 rdm
* treeplayer/: inc/TTreeDrawArgsParser.h,
src/TTreeDrawArgsParser.cxx:
forgot to change the package in the cvs indentification string.
2005-03-21 16:15 rdm
* meta/: inc/TClassRef.h, src/TClassRef.cxx:
added comments and fixed some typos.
2005-03-21 16:14 rdm
* tree/inc/LinkDef.h, tree/inc/TTreeDrawArgsParser.h,
tree/src/TTreeDrawArgsParser.cxx, treeplayer/inc/LinkDef.h,
treeplayer/inc/TTreeDrawArgsParser.h,
treeplayer/src/TTreeDrawArgsParser.cxx:
Move TTreeDrawArgsParser to the treeplayer module.
2005-03-21 16:01 brun
* html/src/THtml.cxx:
From Philippe;
More fixes for problems reported by valgrind
2005-03-21 13:32 brun
* hist/src/TH1.cxx, hist/src/TH2.cxx, hist/src/TH3.cxx,
hist/src/TProfile.cxx, hist/src/TProfile2D.cxx,
tree/inc/TTreeDrawArgsParser.h, tree/src/TTreeDrawArgsParser.cxx:
From Marek Biskup:
- Changed THX::Merge(). Now an attempt to merge histograms with
overflows and different limits will fail.
- Added GetOptionSame() to TTreeDrawArgsParser.
- removing " " inside a string given to TTreeDrawArgsParser::Parse().
2005-03-21 10:15 brun
* hist/src/TAxis.cxx, histpainter/src/TPaletteAxis.cxx:
From Olivier:
- In TPaletteAxis::ExecuteEvent and TAxis::ExecuteEvent the zoom on
logarithmic Z-Axis didn't work.
2005-03-21 08:56 brun
* treeplayer/src/TSelectorDraw.cxx:
Add support for TProfile options "profi" and "profg" when generating
a TProfile histogram.
2005-03-21 07:16 brun
* cint/lib/dll_stl/vec.h:
From Philippe:
The code currently in CVS fails to generated the proper dictionary for
vector<const char*>:
2005-03-20 22:36 brun
* html/src/THtml.cxx:
From Philippe:
Remove a Warning reported by valgrind
2005-03-20 22:25 brun
* meta/inc/: TClass.h, TClassRef.h:
From Philippe,
Previous patch did not compile on Linux.
2005-03-20 20:35 brun
* cont/inc/LinkDef.h, meta/inc/LinkDef.h, meta/inc/TClass.h,
meta/inc/TClassRef.h, meta/src/TClass.cxx, meta/src/TClassRef.cxx:
New class TClassRef
2005-03-20 20:33 brun
* cont/inc/LinkDef.h, meta/inc/LinkDef.h, meta/inc/TClass.h,
meta/src/TClass.cxx, metautils/src/dequeLinkdef.h,
metautils/src/listLinkdef.h, metautils/src/multimapLinkdef.h:
From Philippe:
This patch introduces the TClassRef methods that can be used to replace a
TClass pointer. TClassRef has the same usage syntax as TClass* but is
guaranteed to always point to the correct 'live' TClass object
corresponding to a class. TClassRef can also be used to store a reference
to a TClass on file.
This patch also contains a couple of cleanup and addition in the linkdef
file of cont, meta and the cintdlls.
2005-03-20 19:20 brun
* metautils/src/TClassEdit.cxx:
From Philippe:
This patch insures that array dimensions are kept part of the type
when parsing template parameters (and hence fixes the THtml
generation).
2005-03-20 00:10 rdm
* cont/src/TGenCollectionProxy.cxx:
From Philippe:
The attached patch allows the generation of emulated collection proxy
for STL collection of void*.
2005-03-20 00:10 rdm
* cint/: inc/G__ci.h, lib/dll_stl/vec.h, lib/prec_stl/README.txt,
lib/prec_stl/memory, lib/prec_stl/vector, src/init.c,
src/newlink.c, src/opr.c, src/pause.c, src/pcode.c, src/value.c:
import of CINT 5.15.169.
For what else is new see http://root.cern.ch/root/Cint.phtml?relnote.
2005-03-19 18:09 brun
* histpainter/src/THistPainter.cxx:
Update a comment indicating how to access the TPaveStats
2005-03-19 17:39 brun
* tree/: inc/LinkDef.h, inc/TBranch.h, inc/TBranchBrowsable.h,
inc/TBranchElement.h, inc/TMethodBrowsable.h, src/TBranch.cxx,
src/TBranchBrowsable.cxx, src/TBranchElement.cxx,
src/TBranchObject.cxx, src/TMethodBrowsable.cxx:
From Axel:
Implement the possibility to histogram members of a class
from the TBrowser, even in the case where the Tree has been built
in no split mode.
2005-03-19 08:26 brun
* cont/src/TGenCollectionProxy.cxx:
From Philippe and Axel:
Fix a bug in the STL Emulation layer
2005-03-19 07:33 brun
* cint/src/Class.cxx:
From Philippe:
The function Class::AddMethod needs to follow the pattern of
G__memfunc_setup
and create a new G__ifunc_table when needed (see attachment my fix).
2005-03-18 23:41 rdm
* g3d/inc/TPolyMarker3D.h, g3d/src/TPolyMarker3D.cxx,
graf/inc/TGraph.h, graf/src/TGraph.cxx, hist/src/TH1.cxx,
hist/src/TH2.cxx, hist/src/TH3.cxx, hist/src/TProfile.cxx,
hist/src/TProfile2D.cxx, proof/inc/TProofDraw.h,
proof/src/TProof.cxx, proof/src/TProofDraw.cxx,
proof/src/TProofPlayer.cxx:
From Marek:
- TH1::Merge() adding overflows even when merging histograms with the
same limits. If the limits are different the overflows are ignored.
The same in TH2::Merge, TH3::Merge, TProfile::Merge and TProfile2D::Merge.
- Cleaning fHistogram (and this kind of) variables, so that the drawn
plots aren't deleted in the TProofDrawXXX's destructor.
- Removed TProofNTuple from TProofDrawTGraph.
- Put the initialization code of fFeedback and fPlayer (=MakePlayer())
in TProof in to Init().
- Added TGraph::Merge(). Added TPolyMarker3D::GetPoint(Int_t, Float&,
Float&, Float&).
- Removed TProofNTuple from TProofDrawPolyMarker3D.
- Fixed cleaning output lists after processing (set option = "nodelete").
Now the objects are on the player outputlist and are removed (but not
deleted) from the selector's outputlist.
- Fixed TPolyMarker3D::Merge() - it seems that nobody has ever tried to
run this function.
- Added setting tree attributes (like MarkerStyle, MarkerSize, LineColor etc.)
to a drawn TGraph and TPolyMarker3D in TProofDrawGraph and
TProofDrawPolyMarker3D.
2005-03-18 23:33 rdm
* base/inc/TTimeStamp.h:
other small OpenBSD fix.
2005-03-18 18:52 rdm
* test/Makefile.arch:
add -Wno-long-double for MacOS X to suppress some warnings.
2005-03-18 17:19 brun
* gpad/src/TViewer3DPad.cxx:
From Richard:
- modified TView to be perspective by default. Revert to
cartesian as in v1.3
2005-03-18 16:15 rdm
* unix/src/TUnixSystem.cxx:
From Dmytro Kustov:
one more fix for the OpenBSD port.
2005-03-18 16:08 rdm
* rpdutils/src/rpdutils.cxx:
From Gerri:
The patch to rpdutils also solve the problem observed by Maarten and Burt
concerning setuid to user and back to root.
2005-03-18 16:07 rdm
* net/src/TAuthenticate.cxx:
fix for Win32 which does not have crypt, now use encryption using rsalib.
2005-03-18 09:46 brun
* geompainter/src/TGeoPainter.cxx:
From Andrei:
Fix for painting overlaps
2005-03-18 09:03 brun
* base/inc/TBuffer3D.h, base/inc/TBuffer3DTypes.h,
base/src/TBuffer3D.cxx, g3d/src/TSPHE.cxx, g3d/src/TTUBE.cxx,
geom/src/TGeoTube.cxx, gl/src/TGLRender.cxx,
gl/src/TGLSceneObject.cxx, gl/src/TViewerOpenGL.cxx,
gpad/src/TViewer3DPad.cxx:
From Richard:
Fixes for
i) Incorrect bounding boxes for g3d shapes and spheres in OGL viewer.
ii) Missed case of TGetCTub - cut tube. Now supported natively in OGL
viewer as before.
2005-03-17 21:49 brun
* utils/src/rootcint.cxx:
From Axel:
patch for GetClassVersion, removing a temporary mem allocation
and an unnecessary sprintf.
2005-03-17 16:00 rdm
* base/inc/TVirtualProof.h, proof/inc/TProof.h,
proof/src/TProof.cxx, tree/src/TProofChain.cxx:
put back DeleteDrawFeedback() because calling the delete directly causes
indeed link time dependencies on several platforms (Alpha, AIX).
2005-03-17 12:39 brun
* proof/src/TProofDraw.cxx, tree/inc/TTreeDrawArgsParser.h,
tree/src/TTreeDrawArgsParser.cxx:
A static global cannot be accessed directly on Windows.
Add a new static function TTreeDrawArgsParser::GetMaxDimension.
This function is called by TProofDraw instead of the direct use
of TTreeDrawArgsParser::fgMaxDimension.
2005-03-17 11:43 rdm
* proof/inc/LinkDef.h, proof/inc/TDrawInfo.h,
proof/inc/TProofDraw.h, proof/inc/TProofNTuple.h,
proof/src/TDrawFeedback.cxx, proof/src/TDrawInfo.cxx,
proof/src/TPacketizer.cxx, proof/src/TProofDraw.cxx,
proof/src/TProofNTuple.cxx, proof/src/TProofPlayer.cxx,
tree/inc/LinkDef.h, tree/inc/TTreeDrawArgsParser.h,
tree/src/TTreeDrawArgsParser.cxx:
From Marek:
renamed TDrawInfo to TTreeDrawArgsParser and moved the files to the
tree directory. Removed TProofNTuple::DrawCopy().
2005-03-17 10:29 rdm
* base/inc/TVirtualProof.h:
Forgot to remove a not used anymore pure virtual method.
2005-03-17 01:31 rdm
* proof/inc/TProof.h, proof/src/TProof.cxx,
tree/src/TProofChain.cxx:
remove TProof::DeleteDrawFeedback(), not needed, use virtual dtor.
2005-03-17 01:30 rdm
* tree/src/TTree.cxx:
remove some very old obsolete PROOF code.
2005-03-16 18:29 rdm
* cint/src/loadfile.c, cint/src/shl.c, rpdutils/src/rpdutils.cxx,
unix/src/TUnixSystem.cxx:
From Dmytro Kustov:
some more OpenBSD changes.
2005-03-16 18:18 brun
* g3d/src/TNode.cxx, geompainter/src/TGeoPainter.cxx,
gl/src/TViewerOpenGL.cxx, gpad/src/TPad.cxx,
gui/src/TRootCanvas.cxx, test/RootShower/RootShower.cxx,
x3d/src/TViewerX3D.cxx:
From Richard Maunder:
More fixes to the external viewer creation/closedown. We now:
i) Always call Modified() and Update() we create an external viewer 3D
(non-pad tyep - x3d or ogl) so that an externally spwaned viewer is
painted automcatically when created. For an internal TViewer3DPad we
asssume this was
ii) No longer paint the pad when the external viewer is closed. This
leaves the pad blank - but this is preferable to causing a double redraw
of the pad as the external viewer is closed - very slow....
This all needs to be revisited as part of supporting multiple viewers
properly on the pad.
2005-03-16 18:00 rdm
* asimage/Module.mk:
disable libAfterimage OpenGL features and therefore its dependence on libGL.
2005-03-16 17:10 rdm
* rfio/src/TCastorFile.cxx:
From Gerri:
When using TCastorFile at CERN we default to the uidgid mode to emulate
rfiod authentication behaviour.
2005-03-16 09:35 brun
* pythia6/src/TPythia6.cxx:
Remove unused #define statements
add pointers to the web page describing the installation of ROOT with Pythia6
2005-03-16 07:25 brun
* gpad/inc/TPad.h:
The pointer fViewer3D is only transient.
2005-03-16 07:22 brun
* win32gdk/src/TGWin32.cxx, winnt/src/TWinNTSystem.cxx,
winnt/src/Win32Splash.cxx:
From Axel:
VC8 (beta, but still) found some "inconsistencies" in the windows
department of root:
* TWinNTSystem::SetProgname changes const char*s. The patch properly
allocates and cleans memory for that. Also, the "." of the prog name
extension was searched using strchr instead of strrchr.
* TWinNTSystem::DirName illegal conversion from const char* to char*
* Win32Splash's OlePathName must be wchar_t, as that is what mbstowcs
takes (and not unsigned shorts).
* TGWin32::DrawPolyMarker had no type given for lastn.
2005-03-16 07:15 brun
* pyroot/: ROOT.py, src/Converters.cxx, src/Converters.h,
src/Executors.cxx, src/RootWrapper.cxx:
From Wim Lavrijsen:
the way that CINT handles Long64_t has been changed. This patch
makes Pyroot in phase with the new CINT.
2005-03-15 23:13 brun
* base/src/TProcessID.cxx:
From Philippe:
When the number of processIds is greater than 255 and an address
is re-used, we should not issue an error, just update the pids
registered in fObjPIDs.
2005-03-15 15:02 brun
* ged/: inc/TH1Editor.h, src/TH1Editor.cxx:
From Ilka
In TH1Editor.h, there are two private members violating the naming conventions:
Bool_t make; // Veto Variable
Bool_t makeB; // avoid execution of Bar
2005-03-15 13:13 brun
* minuit/src/TLinearFitter.cxx:
From Anna kreshuk:
some changes in the TLinearFitter class for the case of hyperplane fitting.
2005-03-15 12:07 rdm
* configure:
several more fixes for different "which" behaviour.
2005-03-15 11:41 brun
* test/RootShower/RootShower.cxx:
From Richard Maunder:
Fix RootShower 3D view - update x3d to GetViewer3D and ensure new view
is painted.
2005-03-15 11:27 rdm
* configure:
added protection in check_symbol in case symbol file is not set.
2005-03-15 11:09 rdm
* xmlparser/src/TSAXParser.cxx:
fix warnings on Solaris CC5.
2005-03-15 10:54 rdm
* tutorials/h1analysis.C:
no need for special CINT ifdef anymore since CINT now supports native Long64_t.
2005-03-15 10:38 rdm
* gui/: inc/TGTab.h, src/TGComboBox.cxx, src/TGTab.cxx:
From Daniel Sigg and Ilka:
TGTab was setting the input mask for button press for its entire window.
This then interferes with combo boxes that are located inside a TGTab
and makes it that none of the mouse clicks outside the pop-up are sent
to the combo box. This is particular annoying if you have a tabbed
application.
2005-03-14 23:19 rdm
* proof/src/: TProofDraw.cxx, TProofPlayer.cxx:
From Maarten:
The reserved/standard prefix for PROOF objects in the input and output
is "PROOF" (not _PROOF or __PROOF). Here is a quick patch.
2005-03-14 21:02 rdm
* xmlparser/inc/TXMLParser.h:
removed exception, not used and conflicting with std:exception.
2005-03-14 18:45 brun
* cint/inc/G__ci.h, cint/src/end.c, cint/src/value.c,
meta/src/TCint.cxx:
From Philippe:
end.c: fix for the following AIX problem:
"cint/src/end.c", line 760.41: 1506-068 (S) Operation between types
"char*" and "int" is not allowed.
G__ci.h: expose G__int_cast (but it also needs to be update for the
G__MULTITHREADLIBCINT case).
value.c: revert the ROOT repository to the version in CINT 167 (which was
correct).
TCint.cxx: use G__int_cast when converting the experssion down to a long
We still may want to consider updating the ProcessLine interface to
return
a Long64_t
2005-03-14 18:40 brun
* geompainter/src/TGeoPainter.cxx:
From Richard Maunder:
Fix to TGeoPainter - should be creating TView object on pad if none
exists in various Draw routines. Caused crash in RootShower which always
expects pad to have view.
2005-03-14 18:23 rdm
* base/src/TROOT.cxx:
move PROOF session up in browser, previous change was only in folder list
not in browsables.
2005-03-14 18:22 rdm
* xmlparser/: inc/TSAXParser.h, src/TSAXParser.cxx:
fixing some portability issues.
2005-03-14 18:09 brun
* tree/src/TTree.cxx, treeplayer/src/TTreePlayer.cxx:
From Philippe:
improved documentation for TTree::MakeProxy
2005-03-14 18:08 brun
* cint/src/opr.c:
From Philippe:
The problem on solaris and alpha is essentially due to the fact
that CINT was handling
#if !(G__GNUC_VER>3001)
incorrectly. Instead of being true when G__GNUC_VER, it had the
same value as #if !(3001).
#if !(G__GNUC_VER>=3001)
was also incorrectly handled (it had the value of #if !(0>=3001).
This patch insures that when the macro is not defined,
the result of using it in an expression with <,>,==,<= or >=
is false and the result using it in an expression with != is true.
2005-03-14 16:43 rdm
* README/CREDITS:
added Jose Lo for the XML parser interface classes.
2005-03-14 16:38 rdm
* gpad/inc/TCanvas.h:
minor cosmetic.
2005-03-14 16:37 rdm
* build/: unix/makedist.sh, win/makedist.sh:
add the saxexample.xml file to the distribution files.
2005-03-14 16:36 rdm
* Makefile, configure, config/rootrc.in, xml/Module.mk:
rename libRXML.* to libXMLIO.* to make more clear what it used for.
2005-03-14 16:34 rdm
* tutorials/: SAXHandler.C, saxexample.xml:
SAX interface example.
2005-03-14 16:33 rdm
* xmlparser/: Module.mk, inc/LinkDef.h, inc/TSAXParser.h,
inc/TXMLParser.h, src/TSAXParser.cxx, src/TXMLParser.cxx:
Simple API for XML (SAX) interface using libxml2 as low level parser
library. SAX is event driven and the ROOT interface uses its signal/slots
to have handler functions being registered and called. For an example see
tutorials/SAXHandler.C. This module is only build when libxml2 is found
by ./configure.
2005-03-14 11:09 brun
* cint/lib/prec_stl/: README.txt, memory:
From Gerri ganis;
Fix required to compile with gcc2.95, 2.96
2005-03-14 09:22 brun
* cint/src/value.c:
In functions long G__int(buf and unsigned long G__uint(buf)
comment the lines (4 places)
G__fprinterr(G__serr,"Warning: conversion from 64bit to 32bit integer");
G__printlinenum();
The warnings are printed when they should not be in the TTreeViewer
2005-03-14 01:11 rdm
* base/: inc/RQ_OBJECT.h, src/TQObject.cxx:
try to solve long string literal problem by splitting RQ_OBJECT.
2005-03-13 23:04 rdm
* build/unix/makecintdlls.sh:
now also build the complex.dll (on popular request by Jacek).
2005-03-13 23:03 rdm
* cint/lib/dll_stl/vec.h:
one fix from Philippe was forgotten.
2005-03-13 22:47 rdm
* cint/: inc/CallFunc.h, inc/G__ci.h, inc/fproto.h,
lib/dll_stl/str.h, lib/dll_stl/vec.h, src/CallFunc.cxx,
src/Type.cxx, src/cast.c, src/end.c, src/func.c, src/ifunc.c,
src/init.c, src/memtest.c, src/newlink.c, src/pause.c,
src/sizeof.c, stl/_iterator.h:
import of CINT 5.15.168.
Incorporates Philippe most recent fixes.
For what else is new see http://root.cern.ch/root/Cint.phtml?relnote.
2005-03-13 16:06 rdm
* proof/: inc/TProofPlayer.h, src/TProof.cxx, src/TProofPlayer.cxx:
use EmitVA() for signal/slot of Progress(Long64_t,Long64_t).
2005-03-13 16:05 rdm
* base/inc/RQ_OBJECT.h, base/inc/TQConnection.h,
base/inc/TQObject.h, base/inc/Varargs.h,
base/src/TPluginManager.cxx, base/src/TQConnection.cxx,
base/src/TQObject.cxx, meta/inc/TMethodCall.h,
meta/src/TMethodCall.cxx:
add support for native long long handling. Also added new emit method:
EmitVA() which allows a variable length argument list which makes
multi argument signal and slot methods with float and double arguments
possible (was not possible in the past).
2005-03-13 16:01 rdm
* asimage/src/libAfterImage.tar.gz:
latest version from Sasha, should fix Alpha prolem.
2005-03-13 08:38 brun
* tree/src/TTree.cxx, treeplayer/src/TTreePlayer.cxx,
tutorials/hsimpleProxy.C:
From Philippe:
a first pass at some documentation for MakeProxy.
I also attached yet another (simplistic) example of usage (hsimpleProxy.C).
(Note that there is already tutorials/h1analysisProxy*)
2005-03-12 18:40 rdm
* cint/: lib/dll_stl/str.h, lib/dll_stl/vec.h, src/cast.c,
src/iccstrm.cxx, src/newlink.c, src/sun5strm.cxx, stl/_iterator.h:
From Philippe:
this patch is needed for cint 167. There are basically 4 issues:
a. Some of the changed made to port the cintdll to GCC 4 were lost
b. Modification to newlink.c and to some xxxstrm.cxx
c. Can't create a dictionary for vector<const char*> on linux.
d. Int_t I = (Int_t)long64 inside a loop was still issuing a warning (see
change in cast.c).
2005-03-12 18:39 brun
* Makefile:
Remove reference to xmlparser
2005-03-12 18:21 rdm
* cint/: inc/CallFunc.h, inc/G__ci.h, inc/Method.h, inc/Type.h,
inc/bc_exec_asm.h, inc/fproto.h, inc/global.h, inc/typesym.h,
include/_complex, include/_iostream, lib/Makefile,
lib/dll_stl/cmplx.h, lib/dll_stl/makestr, lib/dll_stl/makevec,
lib/dll_stl/setup, lib/dll_stl/str.h, lib/dll_stl/vec.h,
lib/longlong/longdbl.h, lib/longlong/make.bat,
lib/prec_stl/complex, lib/prec_stl/deque, lib/prec_stl/iterator,
lib/prec_stl/list, lib/prec_stl/map, lib/prec_stl/memory,
lib/prec_stl/multimap, lib/prec_stl/multiset, lib/prec_stl/set,
lib/prec_stl/string, lib/prec_stl/vector, lib/pthread/Makefile,
lib/vc7strm/iostrm.h, lib/win32api/Makewin, lib/win32api/make.bat,
lib/win32api/setup.bat, src/Api.cxx, src/CallFunc.cxx,
src/Class.cxx, src/Method.cxx, src/Type.cxx, src/auxu.c,
src/cast.c, src/decl.c, src/disp.c, src/end.c, src/expr.c,
src/fread.c, src/func.c, src/g__cfunc.c, src/global2.c,
src/iccstrm.cxx, src/ifunc.c, src/inherit.c, src/init.c,
src/loadfile.c, src/macro.c, src/new.c, src/newlink.c, src/opr.c,
src/parse.c, src/pause.c, src/pcode.c, src/scrupto.c, src/shl.c,
src/sizeof.c, src/struct.c, src/stub.c, src/sun5strm.cxx,
src/sunstrm.cxx, src/tmplt.c, src/typedef.c, src/val2a.c,
src/value.c, src/var.c, stl/_iterator.h:
import of CINT 5.15.167.
This version has native long long and long double support.
Also new support for complex.h. In additional many other issues
have been fixed since version .159. For what else is new see
http://root.cern.ch/root/Cint.phtml?relnote.
2005-03-12 16:52 brun
* rint/src/TRint.cxx:
In TRint::Run add support for file paths including one or more backslashes.
2005-03-11 22:48 brun
* cont/src/TClonesArray.cxx:
From Philippe:
This patch update TClonesArray::Streamer so that it properly clear the
(potential) unused part of fCont. Without this fix, the value of
TClonesArray::GetEntries returns by a series of TClonesArray object stored
non-split in a TTree, will be equal to the max size of the TClonesArray so
far (instead of the current size)!.
2005-03-11 22:46 brun
* treeplayer/src/TFormLeafInfo.cxx:
From Philippe:
Fix compiler warnings
2005-03-11 22:25 brun
* cont/src/TEmulatedCollectionProxy.cxx, hist/src/TFormula.cxx,
test/dt_DrawTest.C, test/dt_MakeRef.C, test/dt_RunDrawTest.C,
tree/src/TTree.cxx, treeplayer/inc/TFormLeafInfo.h,
treeplayer/inc/TTreeFormula.h, treeplayer/src/TFormLeafInfo.cxx,
treeplayer/src/TTreeFormula.cxx, treeplayer/src/TTreePlayer.cxx:
From Philippe:
This patch implements support for the accessing the collection object in
TTreeFormula:
// Accessing collection objects
// ============================
//
// TTree::Draw default's handling of collections is to assume that any
// request on a collection pertain to it content. For example, if fTracks
// is a collection of Track objects, the following:
// tree->Draw("event.fTracks.fPx");
// will plot the value of fPx for each Track objects inside the collection.
// Also
// tree->Draw("event.fTracks.size()");
// would plot the result of the member function Track::size() for each
// Track object inside the collection.
// To access information about the collection itself, TTree::Draw support
// the '@' notation. If a variable which points to a collection is
prefixed
// or postfixed with '@', the next part of the expression will pertain to
// the collection object. For example:
// tree->Draw("event.@fTracks.size()");
// will plot the size of the collection refered to by fTracks (i.e the
number
// of Track objects).
2005-03-11 19:36 rdm
* base/inc/RConfig.h:
added case for Fujitsu compiler on Solaris based Fujitsu mainframe.
Provided by Fujitsu when porting the ROOT based SPEC suite.
2005-03-11 19:33 rdm
* unix/src/TUnixSystem.cxx, net/src/DaemonUtils.cxx,
rpdutils/src/net.cxx, rpdutils/src/netpar.cxx,
rpdutils/src/ssh.cxx:
From John Henning:
added special case for _AIX43.
2005-03-11 18:57 brun
* treeviewer/src/TTreeViewer.cxx:
From Ilka.
Fix to the following problem reported at the Forum by Richard Dubois:
On windows, I'm finding that the command line dialogue box in the TreeViewer does not clear the text after I hit <cr>. The command does echo in the console session. Is there a way to get the command line to clear in the gui? It's a bit of a pain to have to delete all the characters.
2005-03-11 18:22 brun
* g3d/src/TNode.cxx, geompainter/src/TGeoPainter.cxx,
gpad/src/TViewer3DPad.cxx, x3d/src/TViewerX3D.cxx:
From Richard Maunder:
Incorrect TView projection settings - cartesian by default. Set to
perspective if TGeoPainter/TNode as required by 3D geometry.
x3d: Raise dialog if no valid content and shutdown the viewer again.
2005-03-11 16:32 brun
* base/src/TROOT.cxx:
Move the list of PROOF sessions up in the browser, such that
the list of files always appear last as before
2005-03-11 16:02 brun
* g3d/src/TPolyMarker3D.cxx, gpad/inc/TViewer3DPad.h,
gpad/src/TPad.cxx, gpad/src/TViewer3DPad.cxx,
gui/src/TRootCanvas.cxx:
From Richard Maunder
Fixes to TViewer3DPad and TView creation - causing 3D histogram plots
etc in pad to be incorrectly scaled.
Also added brief class descriptions etc.
2005-03-11 12:51 brun
* proof/: inc/TDrawInfo.h, src/TDrawInfo.cxx:
Fix fatal errors when compiling on Solaris
2005-03-11 12:44 brun
* g3d/: inc/TShape.h, src/TShape.cxx:
From Richard Maunder:
Remove enforcing of pure virtual GetBuffer3D, and move SetPoints back to
original definition to avoid external dep. problems.
2005-03-11 12:06 rdm
* net/src/TNetFile.cxx:
From Gerri:
correction of my mistake ;-)
2005-03-11 12:05 brun
* geom/: inc/TGeoShape.h, src/TGeoShape.cxx:
From Richard Maunder
Implement a dummy version of TGeoShape::GetBuffer3D for back compatibility
in case one derives from TGeoShape.
2005-03-11 11:22 brun
* tutorials/multidimfit.C:
Add an additional test in the tutorial multidimfit.C.
The generated function MDF.C is loaded and the function MDF
is evaluated at one point and the result compared with a reference value.
2005-03-11 11:21 brun
* hist/src/TMultiDimFit.cxx:
Fix bugs in TMultiDimFit::MakeRealCode
2005-03-11 09:39 rdm
* gl/src/TGLSceneObject.cxx:
in TGLSceneObject members were initialized in wrong order.
2005-03-11 09:28 rdm
* proof/src/TProofServ.cxx:
initialize uninitialized pointers.
2005-03-11 09:25 rdm
* proof/: inc/TDrawFeedback.h, src/TDrawFeedback.cxx,
src/TPerfStats.cxx:
From Maarten:
fix some things in the feedback histograms that got broken in Marek's
big patch.
2005-03-11 01:49 rdm
* net/src/TNetFile.cxx, rootd/src/rootd.cxx:
From Gerri:
allow anonymous user to read a directory.
2005-03-11 01:48 rdm
* rpdutils/src/rpdutils.cxx:
From Gerri:
allow anonymous users to also list the directory contents.
2005-03-11 01:04 rdm
* Makefile:
accidentally checked in development Makefile.
2005-03-11 00:53 rdm
* proof/src/TProofPlayer.cxx:
cosmetics.
2005-03-10 23:26 rdm
* cont/src/TEmulatedCollectionProxy.cxx,
cont/src/TGenCollectionProxy.cxx,
cont/src/TGenCollectionStreamer.cxx, gl/src/TGLCamera.cxx,
gl/src/TGLSceneObject.cxx, gl/src/TX11GL.cxx:
remove several not needed "#include <iostream>" and replace several
by "Riostream.h".
2005-03-10 22:48 rdm
* Makefile:
don't remove test/Makefile but do remove rootd/misc/rootd.rc.d
when doing maintainer-clean.
2005-03-10 20:19 rdm
* gui/src/TGListTree.cxx:
From Joe Chuma:
protection against dangling fSelected.
2005-03-10 20:17 rdm
* gui/src/TGFSContainer.cxx:
From Ilka:
To avoid the case when .root directory is treated as a .root file
I've added additional check.
2005-03-10 20:15 rdm
* proof/: inc/TDrawInfo.h, src/TDrawInfo.cxx:
correct typo in class description.
2005-03-10 19:33 rdm
* config/Makefile.solarisCC5:
add comment on how to link F90 on Solaris 10.
2005-03-10 19:30 rdm
* README/CREDITS:
add Marek and Richard for their contributions.
2005-03-10 19:25 rdm
* config/Makefile.depend, proof/inc/TDrawInfo.h,
proof/src/TDrawInfo.cxx, proof/src/TProofDraw.cxx:
libProof now depends on libGraf3d and libGraf. Also const members are not
properly supported on VC7.1 yet.
2005-03-10 18:57 rdm
* base/inc/MessageTypes.h, base/inc/TROOT.h,
base/inc/TVirtualProof.h, base/src/TROOT.cxx, hist/inc/TH1.h,
hist/inc/TProfile.h, hist/inc/TProfile2D.h, hist/src/TH1.cxx,
hist/src/TH2.cxx, hist/src/TH3.cxx, hist/src/TProfile.cxx,
hist/src/TProfile2D.cxx, proof/inc/LinkDef.h,
proof/inc/TDrawFeedback.h, proof/inc/TDrawInfo.h,
proof/inc/TEventIter.h, proof/inc/TPacketizer.h,
proof/inc/TProof.h, proof/inc/TProofDraw.h,
proof/inc/TProofNTuple.h, proof/inc/TProofPlayer.h,
proof/src/TDrawFeedback.cxx, proof/src/TDrawInfo.cxx,
proof/src/TEventIter.cxx, proof/src/TPacketizer.cxx,
proof/src/TProof.cxx, proof/src/TProofDraw.cxx,
proof/src/TProofLimitsFinder.cxx, proof/src/TProofNTuple.cxx,
proof/src/TProofPlayer.cxx, proof/src/TProofServ.cxx,
rpdutils/src/rpdutils.cxx, tree/inc/LinkDef.h, tree/inc/TBranch.h,
tree/inc/TChain.h, tree/inc/TChainElement.h, tree/inc/TDSet.h,
tree/inc/TProofChain.h, tree/inc/TTree.h, tree/src/TBranch.cxx,
tree/src/TChain.cxx, tree/src/TDSet.cxx, tree/src/TProofChain.cxx,
tree/src/TTree.cxx, tree/src/TVirtualTreePlayer.cxx,
treeplayer/src/TSelectorDraw.cxx:
From Marek Biskup:
major new PROOF developments:
- access to PROOF directly via the TChain interface (creating a TDSet
in the background).
- access to PROOF based trees via the TTreeViewer
- fully implemented the TChain/TDSet::Draw() interface.
- PROOF sessions can now be browsed via the TBrowser
2005-03-10 18:30 brun
* base/src/TView.cxx:
From Philippe:
This patch makes sure that fAutoRange is always initialized.
With this patch, valgrind has no complain about Ilka's test2.cpp
2005-03-10 15:06 rdm
* base/inc/TBuffer3DTypes.h, gpad/inc/TViewer3DPad.h,
gpad/src/TViewer3DPad.cxx:
added cvs tag lines.
2005-03-10 14:46 brun
* hist/inc/TF3.h, hist/src/TF3.cxx,
histpainter/src/THistPainter.cxx:
From Olivier:
- Option BB and FB was not correctly handled for TF3. This causes a crash
in TF3 drawing.
- TF3::SavePrimitives implemented
2005-03-10 10:51 brun
* gpad/src/TPad.cxx:
From Richard Maunder:
Remove automatic creation of TViewerPad3D from the TPad constructor
2005-03-10 09:56 brun
* table/src/: TVolume.cxx, TVolumeView.cxx:
From Richard Maunder:
Fixes the build problem with the table package
2005-03-10 09:47 brun
* x3d/src/TViewerX3D.cxx:
From Richard maunder
Fix a compiler error on Solaris
2005-03-09 23:41 brun
* tutorials/multidimfit.C:
In tutorial multidimfit.C compare results with results of a standard run
and prints the standard OK or fail line.
2005-03-09 23:40 brun
* meta/src/TStreamerElement.cxx:
From Philippe:
This prevents a spurrious message when the type inside an STL collection is
templated and its dictionary is not available. This achieve by looking up
the TClass before looking up a G__ClassInfo.
2005-03-09 19:19 brun
* base/inc/TBuffer3D.h, base/inc/TBuffer3DTypes.h,
base/inc/TVirtualPad.h, base/inc/TVirtualViewer3D.h,
base/src/TBuffer3D.cxx, base/src/TVirtualViewer3D.cxx,
g3d/inc/TBRIK.h, g3d/inc/TCONE.h, g3d/inc/TCONS.h, g3d/inc/TCTUB.h,
g3d/inc/TGTRA.h, g3d/inc/THelix.h, g3d/inc/TMarker3DBox.h,
g3d/inc/TPARA.h, g3d/inc/TPCON.h, g3d/inc/TPGON.h, g3d/inc/TSPHE.h,
g3d/inc/TShape.h, g3d/inc/TTRAP.h, g3d/inc/TTRD1.h,
g3d/inc/TTRD2.h, g3d/inc/TTUBE.h, g3d/inc/TTUBS.h, g3d/inc/TXTRU.h,
g3d/src/TBRIK.cxx, g3d/src/TCONE.cxx, g3d/src/TCONS.cxx,
g3d/src/TCTUB.cxx, g3d/src/TGTRA.cxx, g3d/src/TMarker3DBox.cxx,
g3d/src/TNode.cxx, g3d/src/TPARA.cxx, g3d/src/TPCON.cxx,
g3d/src/TPGON.cxx, g3d/src/TPolyLine3D.cxx,
g3d/src/TPolyMarker3D.cxx, g3d/src/TSPHE.cxx, g3d/src/TShape.cxx,
g3d/src/TTRAP.cxx, g3d/src/TTRD1.cxx, g3d/src/TTRD2.cxx,
g3d/src/TTUBE.cxx, g3d/src/TTUBS.cxx, g3d/src/TXTRU.cxx,
geom/inc/TGeoArb8.h, geom/inc/TGeoBBox.h, geom/inc/TGeoBoolNode.h,
geom/inc/TGeoCompositeShape.h, geom/inc/TGeoCone.h,
geom/inc/TGeoEltu.h, geom/inc/TGeoHalfSpace.h, geom/inc/TGeoHype.h,
geom/inc/TGeoNode.h, geom/inc/TGeoPara.h,
geom/inc/TGeoParaboloid.h, geom/inc/TGeoPcon.h,
geom/inc/TGeoPgon.h, geom/inc/TGeoShape.h, geom/inc/TGeoSphere.h,
geom/inc/TGeoTorus.h, geom/inc/TGeoTrd1.h, geom/inc/TGeoTrd2.h,
geom/inc/TGeoTube.h, geom/inc/TGeoXtru.h, geom/src/TGeoArb8.cxx,
geom/src/TGeoBBox.cxx, geom/src/TGeoBoolNode.cxx,
geom/src/TGeoCompositeShape.cxx, geom/src/TGeoCone.cxx,
geom/src/TGeoEltu.cxx, geom/src/TGeoHype.cxx,
geom/src/TGeoNode.cxx, geom/src/TGeoPara.cxx,
geom/src/TGeoParaboloid.cxx, geom/src/TGeoPcon.cxx,
geom/src/TGeoPgon.cxx, geom/src/TGeoShape.cxx,
geom/src/TGeoSphere.cxx, geom/src/TGeoTorus.cxx,
geom/src/TGeoTrd1.cxx, geom/src/TGeoTrd2.cxx,
geom/src/TGeoTube.cxx, geom/src/TGeoXtru.cxx,
geompainter/inc/TGeoPainter.h, geompainter/src/TGeoChecker.cxx,
geompainter/src/TGeoPainter.cxx, gl/inc/TGLRender.h,
gl/inc/TGLSceneObject.h, gl/inc/TViewerOpenGL.h,
gl/src/TGLRender.cxx, gl/src/TGLSceneObject.cxx,
gl/src/TViewerOpenGL.cxx, gpad/inc/TPad.h, gpad/inc/TViewer3DPad.h,
gpad/src/TPad.cxx, gpad/src/TViewer3DPad.cxx,
gui/src/TRootCanvas.cxx, x3d/inc/TViewerX3D.h,
x3d/src/TViewerX3D.cxx:
From Richard Maunder:
Changes to viewer infrastructure (TBuffer3D,TVirtualViewer3D) to
support:
i) Proper shape specific (sphere, tube, etc) descriptions in TBuffer3D
derived classes - c.f. abuse of raw tesselation blocks before.
ii) On demand filling of buffer sections as required by viewer.
iii) Support for local/master frame shapes descriptions & child object
rejection.
iv) Template/placed shapes ids - enabling viewer to detect/receive
common shapes once and just obtain the new position and id of the
duplicate.
Cleans up all producer (g3d/geom) code so no longer has an viewer
specific knowledge - Paint() methods replaced with
GetBuffer3D/FillBuffer3D methods which complete requested sections of
the buffer.
All viewer specific code now sits on the viewer implementation side of
TVirtualViewer3D. Added a TViewer3DPad class for performing the 3D draws
into pad. In future this should be merged with TView/TView3D possibly.
TBuffer3D is now stripped of functional code (aside from memory
management) and various viewer passback options there previously.
Enforced one way passing a const & to viewer.
Buffers (various types) are held as single static inside producer
function e.g. TGeoShape::GetBuffer3D (c.f. single generic buffer type
fetched from pad previously).
For g3d and geom shapes the top level geometry painter (TNode /
TGeoPainter) controlls painting process, requesting shapes to fill
buffer and passing to 3D viewer.
Exceptions are g3d's TPolyLine3D, TPolyMarker3D & TMarker3DBox. These
are 'standalone' shapes - no controlling 'painter' object. They still
implement Paint(), fill buffer and add to viewer directly.
3D viewer still held / created by pad - and pad has it's own viewer
object (TViewer3DPad).
NOTE:
1. Current scheme supports one 3D viewer only - pad, x3d or OpenGL. This
means that pad goes blank when x3d/OGL is spawned, and is updated again
when it is closed. To be revisited - need to support multiple viewers,
of multiple types - which implies explicit naming or pad controlling
enumeration.
2. OGL viewer now responds correct to modifications in pad, without
having to be reinvoked (as previously). x3d is still decoupled (as
previously) so does not rebuild - too difficult to get working.
2005-03-09 18:28 brun
* histpainter/src/THistPainter.cxx:
From Olivier:
- In THistPainter::PaintColorLevels the colored boxes might be drawn
outside gPad if their upper limits were smaller than the gPad lower
limits or if their lower limits were bigger than the gPad higher limits.
The following example shows the problem:
void colzsame ()
{
TCanvas * c0 = new TCanvas("c0","c0",600,600);
TH2D * base = new TH2D("base","base",10,-1,1,10,0.,1.5);
base->Draw();
TH2D * h2d = new TH2D("h2d","h2d",10,0.,1.,10,0.,1.);
gStyle->SetPalette(1);
for (int i=0; i<10; i++) {
for (int j=0; j<10; j++) {
h2d->SetBinContent(i+1,j+1,(i+1)*10.+j+1);
}
}
h2d->Draw("samecolz");
base->SetAxisRange(0.5,0.7,"X");
base->SetAxisRange(0.5,0.7,"Y");
}
2005-03-08 22:53 brun
* hist/src/TMultiDimFit.cxx:
From Eddy Offermann:
When using the tutorial multidimfit.C, 3 issues were observed and
they are solved with this patch:
1)
- a: Warning in <TMatrixD::Invert(Double_t *)>: Determinant
under/over-flows double....
-------------------------------------------------------------------------
In this case the determinant becomes > 2^52 or < 2^-52 and is
therefore starting to over/under flow . So possibly some loss
of precision in the inversion .
The change from TMatrixD to TMatrixDSym only highlighted the fact
that a warning was missing in TMatrixDSym.Invert (now added) .
It is a good idea to scale the matrix . Since this particular
matrix is a symmetric positive definite one , the following
scaling is appropriate:
A(i,j) = A(i,j)/Sqrt(A(i,i)*A(j,j))
This is now installed in the code through (plus a better way to
notice that the matrix is singular) :
const TVectorD diag = TMatrixDDiag_const(curvatureMatrix);
curvatureMatrix.NormByDiag(diag);
TDecompChol chol(curvatureMatrix);
if (!chol.Decompose())
Error("MakeCoefficientErrors", "curvature matrix is singular");
chol.Invert(curvatureMatrix);
curvatureMatrix.NormByDiag(diag);
- b: Warning in <TMultiDimFit::MakeCoefficientErrors>: curvature
matrix is singular
-------------------------------------------------------------------
Before 18-Dec-2004, Invert(*det) returned a zero determinant in case
of over/under-flow.
However, this was removed on the 18th so I do not undertand that
Gilles had this problem with 4.03/02 .
2)
It was noted that the tutorial multidimfit.C gave different results
on different platforms .
--------------------------------------------------------------------------
One obvious reason were the "#ifndef R__MACOSX" statements that have
now been removed .
A more subtle bug/issue was that the function
TMultiDimFit::EvalControl gave results that depended on platform-specific
rounding issues . The control number is used to decide which functions to
use AND in which order .
I had to think of a change that would keep the control number such
that old results could (besides the rounding issues) be reproduced .
My solution is
control[numberFunctions-1] = Int_t(1.0e+6*s);
instead of
control[numberFunctions-1] = s;
Indeed MacOSX and Linux give now identical results .
2005-03-08 22:23 brun
* cont/: inc/TGenCollectionProxy.h, src/TGenCollectionProxy.cxx:
From Markus Frank
1) Remove "const " for STL value_type name (if present)
2) In case TClass of the value_type has no generated
destructor, call TClass::Destructor.
2005-03-08 18:43 brun
* hist/src/THStack.cxx:
From Olivier:
- Improvement in THStack::Paint in 1d histograms stacks drawing: The
background of each level is erased with the TFrame color and pattern
before drawing it.
2005-03-08 18:28 rdm
* rootd/src/rootd.cxx:
From Gerri:
I have found that rootd fails to start
when ROOTSYS is undefined and no config dir is given as last
argument. This is some remnant from the first hour. Now
the defaults are such that this is non strictly necessary
(the config dir is there to define bindir and etcdir, which
however, can also be set by setenv ROOTBINDIR and ROOTENVDIR).
So I suggest to change the ErrFatal in debug message.
2005-03-08 17:56 brun
* ged/: inc/LinkDef.h, inc/TFrameEditor.h, src/TFrameEditor.cxx:
From Ilka:
New class TFrameEditor. it provides the GUI for changing fill, line and border attributes of TFrame objects.
2005-03-08 11:32 brun
* geom/src/: TGeoManager.cxx, TGeoTube.cxx:
From Andrei Gheata:
I attached 2 small fixes: TGeoManager::FindNextBoundary(): fixed un-initialized
fIsOnBoundary flag (safety was not computed anymore after the first step on
boundary made by the MC)
from Mihaela: fix in TGeoCtub::SavePrimitive()
2005-03-08 10:19 rdm
* proof/etc/proof.conf.sample, proof/inc/TCondor.h,
proof/inc/TPacketizer.h, proof/inc/TProof.h,
proof/src/TPacketizer.cxx, proof/src/TPacketizer2.cxx,
proof/src/TProof.cxx, proof/src/TProofPlayer.cxx,
proof/src/TProofServ.cxx, tree/inc/TDSet.h, tree/src/TDSet.cxx:
From Kris Gulbrandsen:
several cleanups and consolidation of the creation of the different
PROOF players.
2005-03-08 08:27 brun
* hist/src/TMultiDimFit.cxx:
From Christian Holm Christensen
Use a TMatrixDSym instead of a TMatrixD.
2005-03-08 06:57 brun
* gpad/src/TCanvas.cxx:
In TCanvas::Streamer use the new function TBuffer::CheckObject
to check if the list of colors is already in the buffer
instead of using one of the internal TBuffer bits.
2005-03-08 06:48 brun
* qt/inc/TQtEventQueue.h, qt/src/TQtClientFilter.cxx,
qt/src/TQtClientGuard.cxx, qt/src/TQtEventQueue.cxx,
qtroot/Module.mk:
From Valeri Fine:
More protections in several places (event queue in particular)
2005-03-08 06:38 brun
* tutorials/: benchmarks.py, demo.py, demoshelp.py, fildir.py,
file.py, fillrandom.py, first.py, fit1.py, formula1.py,
framework.py, geometry.py, gerrors.py, graph.py, h1draw.py,
hsimple.py, hsum.py, mrt.py, multifit.py, na49geomfile.py,
na49view.py, na49visible.py, rootmarks.py, shapes.py, surfaces.py,
tornado.py, zdemo.py:
From Wim Lavrijsen:
o) removed setup of SEAL environment
o) improved "pythonization"
o) added optimization trick for inner loops (10% effect), with comments
o) removed a few remaining differences between .py and .C examples
o) new files to complete "demo.py":
- benchmarks.py
- geometry.py
- na49geomfile.py
- na49view.py
- na49visible.py
- rootmarks.py
- zdemo.py
Note: rootmarks.py executes rootmarks.C, such that benchmark calibration
numbers are contained to one file only, and geometry.py executes na49.C,
which is not converted because it is a generated file.
2005-03-08 06:33 brun
* proof/src/TProofDraw.cxx, treeplayer/inc/TTreeFormula.h,
treeplayer/src/TSelectorDraw.cxx, treeplayer/src/TTreeFormula.cxx,
treeplayer/src/TTreeIndex.cxx,
treeplayer/src/TTreeProxyGenerator.cxx:
From Philippe:
This patch solves a problem where the sizes of a collection
within a split-collection where not properly loaded (i.e.
TTreeFormula::LoadCurrentDim was not calling GetEntry on
the branch containing the collection within a collection).
Also (and independently):
To support for the cases where the user do
tree->GetEntry(entry);
// modify the event
tree->GetEntry(entry);
// User expect the event to have reverted to
// the same state as after the first GetEntry
we insured that TBranch::GetEntry always re-stream the
data from the basket. Similarly, TTreeFormula::EvalInstance
needs to also insure that it always re-stream the data
from the basket (Some developer uses TTreeFormula directly).
However in case, when we are guaranteed that the data pointed
to by the tree will not modified and we need to call GetEntry
several times on the same branch for the same entry,
this is a waste of time.
We are in this case for the TTreeFormula handled by
TProofDraw, TSelectorDraw and TTreeIndex.
The case where we currently have the inefficiencies are
the cases for the same branch is listed in several
distinct formulas (for example in the 1 dimension and
the selection or as an index) and the cases of
variable dimensions formulas (GetEntry called at least
once in LoadCurrentDim and once more in EvalInstance).
The attached patch solve the issue for TProofDraw,
TSelectorDraw and TTreeIndex by adding a new data member
to TTreeFormula (fQuickLoad), this can be set to tell
TTreeFormula to assume that the data is really read-only
(and hence it does not need to read the branch again is
br->GetReadEntry()==tree->GetReadEntry().
We can not solve the issue in the general case since we
can not guarantee that that data pointed will not be
modified between the call to GetNdata (hence LoadCurrentDim)
and EvalInstance. The cost of not properly insuring is
high since it involves silently displaying incorrect data.
However LoadCurrentDim could still be improved since it does
not use the optimization used by EvalInstance which insures
that itself reads each branch only once (Fixing this for
LoadCurrentDim would no be trivial)
Note that without the fQuickLoad flag set to true, branches
that are used several time in the same formula are loaded
several times. (With fQuickLoad set to true, they are loaded
only once). Solving this inefficiency is a difficult tasks,
since we would need to insure that the branch is read exactly
once not matter what the value of branch->GetReadEntry is.
In addition, this could only take in consideration the formulas
within the same TTreeFormulaManager. And this would have to
be done without any significant loss for the simple case and
for the case where we can do Boolean optimization (i.e. case
where the content of the branch is not needed to know the
final result of the formula).
2005-03-07 23:45 rdm
* base/src/TBuffer.cxx:
add some more protections in CheckObject() in case fMap = 0.
2005-03-07 22:46 brun
* pyroot/src/MethodProxy.cxx:
From Wim Lavrijsen:
one minor change, for something I found while updating the tutorial files:
Allow re-try of the other overload methods when the call to the method
from a successful hash lookup fails. The hash is based on argument types,
but python type behaviour is not fixed. Hence, a call failure may be
because of an "out-of-date" hash, and the full overload must be re-tried.
2005-03-07 19:48 brun
* treeplayer/src/TTreePlayer.cxx:
From Philippe:
In MakeClass/MakeSelector, update the code so that the
index of a split collection has its "BranchCount"'s
address properly set.
Also avoid generating a data member that we are not
going to use (Case of the top of a split object).
This object are not useable (since the TTree is in
MakeClass mode) and can actually be damageable
(the class name is possibly not known at the time
the MakeClass/MakeSelector is run).
This is needed to properly generate MakeClass/MakeSelector
on the new CMS data files.
2005-03-07 19:08 brun
* tree/src/TTree.cxx:
From Philippe
Remove the print of a Warning in case the top level branch cannot be split
2005-03-07 18:00 brun
* treeplayer/src/TTreeFormula.cxx:
From Philippe
This patch adds a missing protection in TTreeFormula::LoadBranch (called
when a formula includes a boolean expression and an index which contains
reference to a branch, for
example tt->Draw("iCell","iCell>900&&iClus[iCellClus-1]==10").
This fixes the bug report #2766 and is tested by indexLoad in
roottest/root/treeformula/array
2005-03-07 17:18 rdm
* base/: inc/TBuffer.h, src/TBuffer.cxx:
Added
CheckObject(const TObject*)
CheckObject(const void *, const TClass *)
these functions return kTRUE if the specified object is already in
the TBuffer. The buffer must be in writing mode.
2005-03-07 14:41 rdm
* configure:
use libmysqlclient_r.so when building ROOT with thread support.
2005-03-07 10:15 brun
* fumili/src/TFumili.cxx, graf/inc/TGraph.h,
graf/inc/TGraphAsymmErrors.h, graf/inc/TGraphBentErrors.h,
graf/inc/TGraphErrors.h, graf/src/TGraph.cxx,
graf/src/TGraphAsymmErrors.cxx, graf/src/TGraphBentErrors.cxx,
graf/src/TGraphErrors.cxx, minuit/src/TFitter.cxx:
For back compatibility change names of some recently introduced functions.
virtual Double_t GetErrorXhigh(Int_t bin) const;
virtual Double_t GetErrorXlow(Int_t bin) const;
virtual Double_t GetErrorYhigh(Int_t bin) const;
virtual Double_t GetErrorYlow(Int_t bin) const;
virtual Double_t *GetEXhigh() const
virtual Double_t *GetEXlow() const
virtual Double_t *GetEYhigh() const
virtual Double_t *GetEYlow() const
2005-03-07 08:44 brun
* qt/: inc/TGQt.h, inc/TQtWidget.h, src/GQtGUI.cxx, src/TGQt.cxx,
src/TQtApplication.cxx, src/TQtWidget.cxx:
From Valeri Fine:
TGQt:
* Comments clean up
* 2 news protected static methods:
static Int_t RegisterWid(QPaintDevice *wid);
static void UnRegisterWid(QPaintDevice *wid);
to resolved the potential 64-bits platform problems
* Some extra fixes to facilitate the 64-bits platforms
* TQtWidget
- new Qt signal:
RootEventProcessed(TObject *selected, unsigned int event,TCanvas
*canvas)
where
"selected" - is a TObject has been selected
by the current TPad
"event" - ROOT event processed by TCanvas.
This Qt signal allows forward the "ROOT signal" to Qt "slot".
By default, TQtWidget emits no "RootEventProcessed" for sake
of the performance.
Any user-code can activate the signal emitting with a bunch
of the new methods. See next point
* A bunch of the methods to facilitate the new Qt Signal:
void EnableSignalEvents (UInt_t f);
void DisableSignalEvents (UInt_t f);
Bool_t IsSignalEventEnabled(UInt_t f) const;
where "f" is logical combination of the bits to activate
the emitting the RootEventProcessed Qt signal as soon as
TCanvas ROOT event forwarded by Qt-layer
kMousePressEvent = BIT(0), // mousePressEvent QMouseEvent
kMouseMoveEvent = BIT(1), // mouseMoveEvent QMouseEvent
kMouseReleaseEvent = BIT(2), // mouseReleaseEvent QMouseEvent
kMouseDoubleClickEvent = BIT(3), // mouseDoubleClickEvent QMouseEvent
kKeyPressEvent = BIT(4), // keyPressEvent QKeyEvent
kEnterEvent = BIT(5), // enterEvent QEvent
kLeaveEvent = BIT(6) // leaveEvent QEvent
* TQtApplication
A special DISPLAY env varaible value QT_BATCH
to use Qt layer with "non-gui" mode
(in case when no X11 connection is provided)
2005-03-06 16:46 rdm
* rpdutils/src/rpdutils.cxx:
From Gerri:
Another backward-non-compatibility in the error message codes
making possible out-of-range accesses in gRootStrErr.
2005-03-06 16:46 rdm
* rootd/src/rootd.cxx:
From Gerri:
fix backward compatability problem introduced during a fix for the
new stat() functionality in November 04.
2005-03-06 09:43 brun
* tree/src/TBranch.cxx:
Replace refernces to TBasket::kNotDecompressed by TBuffer::kNotDecompressed
2005-03-06 08:29 brun
* base/inc/TBuffer.h, tree/inc/TBasket.h, tree/src/TBasket.cxx:
Move the enum kNotDecompressed=BIT(15) from TBasket to TBuffer
where it belongs logically.
2005-03-05 23:59 brun
* base/inc/TBuffer.h:
Ise BIT(16) instead of BIT(15) in TBuffer.
2005-03-05 23:17 brun
* gpad/src/TCanvas.cxx:
Fix in TCanvas::Streamer to prevent streaming twice (or more) the table
of colors in case one streams two or more canvases to the same buffer.
The algorithm uses the new bit TBuffer::kUser3
2005-03-05 23:15 brun
* base/: inc/TBuffer.h, src/TBuffer.cxx:
Fix a potentially dangerous bomb for the future in TBuffer.h.
The enum kIsOwner (protected) and kStreamedMemberWise (public)
were both set to BIT(14) !!
I moved kIsOwner to public and set it to BIT(15) because
kStreamedMemberWise is already used for forward compatibility.
I added 3 user bits enum kUser1, kUser2, kUser3.
These bits can be used by the application to mark special cases when streaming.
For example, kUser3 is used by TCanvas::Streamer to avoid writing
twice the table of colors in case two or more canvases are streamed
to the same buffer (case seen by Marek in PROOF).
~
~
2005-03-05 15:20 brun
* pythia6/src/TPythia6.cxx:
In the TPythia6 constructor change the way the common block addresses are passed to C++ from Fortran. The previous method did not work on AMD64.
In case you run with Pythia6, take the new tar file
from ftp://root.cern.ch/root/pythia6.tar.gz
and run one of the makePythia6.xxxx installation script where
xxx is linux, win32, etc.
2005-03-04 21:30 brun
* tree/src/TTree.cxx:
Fix a typo in an example in TTree::ReadFile
2005-03-04 21:11 brun
* treeplayer/src/TBranchProxyDescriptor.cxx:
From Philippe:
This patch insures that the data member generated by MakeProxy are (in more
cases)
valid C++ symbols. The needed modifications made to the branch names are
now
expressed in the documentation of TTreePlayer::MakeProxy.
2005-03-04 20:41 brun
* pyroot/src/: MethodProxy.cxx, ObjectProxy.cxx, PropertyProxy.cxx,
RootModule.cxx, RootWrapper.cxx:
From Wim Lavrijsen
Fix cast problems on Solaris
2005-03-04 20:37 brun
* hist/src/TFormula.cxx, treeplayer/src/TTreeFormula.cxx:
From Philippe:
TFormula and TTreFormula's calculation of the modulo requires to cast double
precision values into integral value before executing the modulo. The
previous implementation was casting the value down to a Int_t this leads to
the value being incorrect if the original data was an unsigned int greater
than 2^31. We now cast to a Long64_t. Short
of both opererands and handling all 4 cases separately, we have to cast to a
sign intergral.
Hence, in order to not penalize in run-time the most used case, we accept
the fact that the modulo operation will still give an incorrect value if the
originial data is an unsigned
64 bits value and is greater than 2^63.
2005-03-04 19:59 brun
* pyroot/src/MethodDispatcher.h:
I forgot to remove this obsolete file
2005-03-04 19:44 brun
* pyroot/inc/TPyException.h:
From Philippe:
Fix a portability problem on Solaris when using exceptions.
2005-03-04 19:38 brun
* hist/src/TFormula.cxx:
From Anna Kreshuk:
I've changed the TLinearFitter and TFormula and hope that this will remove the
warnings on Solaris.
The changes in TFormula also address the issue raised by Philippe, and his two
formulas are now the same.
2005-03-04 18:46 brun
* treeplayer/src/TTreePlayer.cxx:
From Philippe:
This patch insures that the data member generated by MakeProxy are (in more
cases)
valid C++ symbols. The needed modifications made to the branch names are
now
expressed in the documentation of TTreePlayer::MakeProxy.
2005-03-04 16:32 rdm
* minuit/: inc/TLinearFitter.h, src/TLinearFitter.cxx:
the header was lacking multiple inclusion protection ifdef's and the
source was full of <TABS>.
2005-03-04 10:32 brun
* hist/src/TFormula.cxx:
Fix portability problems on Solaris
2005-03-04 10:29 brun
* graf/src/TGraph.cxx, graf/src/TMultiGraph.cxx,
hist/src/TFormula.cxx, hist/src/TGraph2D.cxx:
Fix several portability problems on Solaris
2005-03-04 10:26 brun
* hist/src/TH1.cxx:
Fix portability problem on Solaris
2005-03-04 10:24 brun
* minuit/src/TLinearFitter.cxx:
Fix a portability problem on Solaris
2005-03-04 10:21 brun
* config/Makefile.depend, minuit/src/TLinearFitter.cxx:
Fix a portability problem on Windows.
Add library dependency of Minuit on libMatrix
2005-03-04 10:14 brun
* minuit/: inc/TLinearFitter.h, src/TLinearFitter.cxx:
Fix portability problems
2005-03-04 10:06 brun
* fumili/src/TFumili.cxx, graf/inc/TGraph.h,
graf/inc/TGraphAsymmErrors.h, graf/inc/TGraphBentErrors.h,
graf/inc/TGraphErrors.h, graf/inc/TMultiGraph.h,
graf/src/TGraph.cxx, graf/src/TGraphAsymmErrors.cxx,
graf/src/TGraphBentErrors.cxx, graf/src/TGraphErrors.cxx,
graf/src/TMultiGraph.cxx, hist/inc/Foption.h, hist/inc/TFormula.h,
hist/src/TFormula.cxx, hist/src/TGraph2D.cxx, hist/src/TH1.cxx,
minuit/inc/LinkDef.h, minuit/inc/TLinearFitter.h,
minuit/src/TFitter.cxx, minuit/src/TLinearFitter.cxx:
From Anna Kreshuk:
- TLinearFitter class: Linear fitter is used to fit a set of data points with a linear
combination of specified functions (with or without weights). The "linear" in the name
stands for "linear in parameters", not variables. The main advantages,
compared to a general non-linear fitter, is that the linear fitter is considerably
faster and doesn't require setting the initial values of parameters.
The linear fitter can be used directly or through TH1::Fit and TGraph::Fit functions
When it's used directly, functions of more than 3 dimensions can be fitted.
- TFormula: a new data member fLinearParts and methods to process it are added. Now
one can create a function of the type that can be fit by the linear fitter.
Example: TFormula f("f", "x++sin(x)") is equivalent to
TFormula f("f","[0]*x + [1]*sin(x)"), but if a TH1::Fit or a TGraph::Fit is performed
with the 1st formula, it goes through the linear fitter, if it's performed with the
2nd formula, it goes through Minuit.
- TMultiGraph class: the Fit method is implemented, allowing to fit all the graphs
of a multigraph simultaneously
- TGraph, TGraphErrors, TGraphAsymmErrors, TGraphBentErrors - functions GetEXhigh(),
GetEXlow(), GetEYhigh(), GetEYlow() implemented to simplify the GraphFitChisquare()
function of the TFitter class
- TH1, TGraph, TGraph2D, TMultiGraph - changes in the Fit functions, allowing to use
the linear fitter. Fitting with "polN" functions redirected to use the linear fitter,
in cases where no options, except "range", are specified.
2005-03-04 08:44 brun
* pyroot/: ROOT.py, inc/LinkDef.h, inc/TPyException.h,
inc/TPyReturn.h, inc/TPython.h, src/ClassMethodHolder.cxx,
src/ClassMethodHolder.h, src/ConstructorDispatcher.cxx,
src/ConstructorDispatcher.h, src/ConstructorHolder.cxx,
src/ConstructorHolder.h, src/Converters.cxx, src/Converters.h,
src/Executors.cxx, src/Executors.h, src/MemoryRegulator.cxx,
src/MemoryRegulator.h, src/MethodDispatcher.cxx,
src/MethodHolder.cxx, src/MethodHolder.h, src/MethodProxy.cxx,
src/MethodProxy.h, src/ObjectHolder.cxx, src/ObjectHolder.h,
src/ObjectProxy.cxx, src/ObjectProxy.h, src/PropertyHolder.cxx,
src/PropertyHolder.h, src/PropertyProxy.cxx, src/PropertyProxy.h,
src/PyBufferFactory.cxx, src/PyBufferFactory.h, src/PyCallable.h,
src/Pythonize.cxx, src/Pythonize.h, src/RootModule.cxx,
src/RootWrapper.cxx, src/RootWrapper.h, src/TPyClassGenerator.cxx,
src/TPyClassGenerator.h, src/TPyException.cxx, src/TPyReturn.cxx,
src/TPython.cxx, src/Utility.cxx, src/Utility.h:
From Wim Lavrijsen:
The core of PyROOT has been rewritten to:
1) reduce layers for performance,
2) refactor code (not completely done), and
3) follow the ROOT coding conventions
Along the way, a few loose ends have been wrapped up. Most notable of
these are: class static data, global builtin types, method doc strings,
mangled private member functions, and the addition of a C++ exception
to report python errors.
2005-03-04 08:11 brun
* qt/: inc/TGQt.h, inc/TQtThread.h, inc/TQtThreadStub.h,
inc/TVirtualX.interface.h, inc/TWaitCondition.h, src/GQtGUI.cxx,
src/GQtGUIThread.cxx, src/TGQt.cxx, src/TGQtDummy.cxx:
From Valeri Fine:
1. Better handling the 64-bits ROOT widget IDs ("Widnows_t" type)
and the integer TCanvas IDs ("Int_t" type).
2. Adjust TGQt.h interface in respect with the current version of
TVirtualX
Disable the redundant "OpenGL method"
3. Some fixes to provide the "pseudo-widget" support
2005-03-04 03:46 rdm
* Makefile, build/unix/makelib.sh, build/unix/wingcc_ld.sh,
config/Makefile.win32gcc, test/Makefile.arch:
From Axel:
since about 6 months, cygwin's ld works (again) without import
libraries. The attached patch skips that part, and instead creates a
soft link from the import library (.dll.a) to the .dll. This drastically
reduces build time, build memory usage, and disk usage.
The other patch will only work with the newest version of cygwin. They
finally fixed a problem with shared memory, so cygwin now relocates
libraries properly. This means the cyg_heap error is gone, and there is
no need to rebase binaries anymore. The difference in load time between
root with and without rebased binaries is about 10%, i.e. 1 second when
cygwin needs to relocate the libs during load time, and 0.9 seconds when
the libraries have been rebased already.
To protect against older cygwin versions, I have introduced a
CYGWINVERSION variable in makefile.win32, which is tested against the
newest release to ensure that rebase can really be skipped. I have moved
the definition of the POSTBIN variable into Makefile.win32gcc; the value
is specific to win32gcc and should not appear in the main Makefile. I
did leave the target itself in there, as the config/Makefile.* don't
contain targets, only variable definitions.
-enable-soversion is now working under win32gcc, too. It creates dlls in
the form libCore.4.03.03.dll plus the necessary symlinks. It sets the
dll header's major version to 4 ($MAJOR), and the minor version to 303
($MINOR$REVIS).
I have fixed the -soname flag for the linker, and updated the
test/Makefile.arch flags to correspond with what's in
config/Makefile.win32gcc.
On a side note: for cygwin, I had to adjust the minor version for the
dll to not start with a "0", as ld will interpret that number to be
octal otherwise. The same will probably be true for all other platforms
using ld.
2005-03-04 02:43 rdm
* cint/src/loadfile.c:
From Philippe:
This patch corrects the problem seen by Jacek, by insuring that when a file
is closed and G__ifile points to this file, we properly reset G__ifile.fp
to 0.
2005-03-03 23:06 brun
* base/inc/TVirtualPadEditor.h, base/src/TVirtualPadEditor.cxx,
ged/inc/TGedEditor.h, ged/src/TAttLineEditor.cxx,
ged/src/TGedEditor.cxx, gui/src/TRootCanvas.cxx:
From Ilka:
TVirtualPadEditor.h, cxx
- new methids IsGlobal(), SetGlobal()
- setting of globel editor in Show() method
TGedEditor.h, cxx
- new data member:Bool_t fGlobal; //true if editor is global
- new methods: IsGlobal(), SetGlobal(), SetCanvas(), GetCanvas(),
DisconnectEditors()
TRootCanvas.cxx
- code changes that allow only one editor (embedded or global) to be activated
per canvas
- activating the global editor via the context menu of another canvas will
connect this canvas to it and will close the embedded editor if it was opened
- the global editor works for any embedded canvas
2005-03-03 23:01 brun
* graf/src/TLatex.cxx:
From Olivier:
- After Revision 1.18 (to have a better adjustment of the bar above text)
TLatex vertically centered was not positioned correctly (text was too
high).
2005-03-03 12:45 rdm
* clib/src/Demangle.c:
remove compiler warning.
2005-03-03 12:45 rdm
* oracle/: inc/TOracleResult.h, src/TOracleResult.cxx,
src/TOracleServer.cxx:
some cosmetics.
2005-03-03 12:37 brun
* eg/inc/TParticle.h:
From Kirill.Shileev@cern.ch
Added the following functions in TParticle
IsPrimary()
R() (cylindrical system)
Rho() (spherical system)
2005-03-03 11:40 brun
* hist/src/TH1.cxx:
In TH1::Chi2Test allways normalize histograms before computing the chisquare
2005-03-03 09:19 brun
* hist/: inc/TH1.h, src/TH1.cxx:
Move TH1::GetIntegral from TH1.h to TH1.cxx.
TH1::GetIntegral automatically calls TH1::ComputeIntegral
if fIntegral is null.
2005-03-03 09:06 brun
* oracle/: inc/TOracleResult.h, src/TOracleResult.cxx,
src/TOracleServer.cxx:
From Yan Liu:
1. implemented TOracleServer::GetColumns() using occi
MetaData instead of original SQL select statement. This
implementation works for any Oracle 10 databases without
constraints on user granted priveleges.
2. implemented TOracleServer::GetTables(). The TSQLServer::GetTables()
is MySQL oriented. In Oracle, table is accessed in "schema.table" format.
The implementation handles two cases: with and without schema name.
The return value conforms TSQL spec, i.e. a TSQLResult pointer.
3. fixed a critical bug in TOracleResult::Next().
2005-03-03 09:04 brun
* graf/inc/TAttImage.h, meta/src/TDataMember.cxx:
From Ilka:
fix for the context submenu appearence when the menu entries are of enum type defined in the class scope.
- TAttImage.h: for fImageQuality added // *OPTION...; for SetImageQuality // *SUBMENU*
- TDataMember.cxx: added the case when an option data member has enum type defined in the class scope
2005-03-02 18:51 brun
* cint/src/: Type.cxx, val2a.c:
From Philippe:
On windows we encounter a fatal (but semi-random) problem which is directly
due to the fact that the buffer used in Type.cxx (G__buf) to hold the result
of G__type2string is under-sized (only G__ONELINE instead of G__LONGLINE as
in G__type2string).
Also I (re)notice that there __no__ protection or warnings in case of buffer
over-run in G__type2string. The consequence of this missing test is that a
user will discover that his class name are too long (and hence that he needs
to increase G__LONGLINE) only when he stumble upon some random crashes due
to the buffer run (assuming that he is patient enough to actually discover
that this is the problem).
I corrected the problem in Type.cxx AND I added a
test in G__type2string to print an error message if there is a buffer
over-run. Alternatively,
we could actually terminate the program in the failing case.
2005-03-02 08:30 brun
* main/src/hadd.cxx:
In MergeRootFile function delete the local object globChain.
This function is used as a prototype in several applications.
When the function is called many times, a substantial memory leak
is happening if globChain is not deleted.
2005-03-01 18:05 rdm
* rpdutils/src/: net.cxx, netpar.cxx, ssh.cxx:
Fix typo in MACOSX_VERS define (should be R__MACOSX_VERS).
2005-03-01 15:53 rdm
* test/Makefile.arch, thread/Module.mk, utils/src/rlibmap.cxx:
From Dmytro Kustov:
some more OpenBSD fixes.
2005-03-01 10:33 brun
* graf/src/TGraphBentErrors.cxx:
From Olivier:
- In TGraphBentErrors::Paint the TStyle parameter EndErrorSize was not
taken into account.
2005-03-01 08:24 brun
* qt/: Module.mk, inc/LinkDef.h, inc/TGQt.h, inc/TQMimeTypes.h,
inc/TQtApplication.h, inc/TQtBrush.h, inc/TQtClientFilter.h,
inc/TQtClientWidget.h, inc/TQtMarker.h, inc/TQtSymbolCodec.h,
inc/TQtTermInputHandler.h, inc/TQtTimer.h, inc/TQtWidget.h,
src/GQtGUI.cxx, src/TGQt.cxx, src/TQMimeTypes.cxx,
src/TQtApplication.cxx, src/TQtBrush.cxx, src/TQtClientFilter.cxx,
src/TQtClientWidget.cxx, src/TQtMarker.cxx, src/TQtSymbolCodec.cxx,
src/TQtTermInputHandler.cxx, src/TQtTimer.cxx, src/TQtWidget.cxx:
From Valeri Fine:
version of Qt tailored to create RootCint dictionary
In addition there are a few corrections for
TGQt:
- Remove the redundant TVirtualGL dependency
- Qt font size calculation has been improved.
- Env variable ROOTFONTFACTOR to facilitate the debugging of the font-size-related problem was added
TQtApplication:
- Remove the redundant TQtApplicationThread dependency
2005-02-28 21:52 brun
* geom/src/: TGeoArb8.cxx, TGeoBBox.cxx, TGeoCone.cxx,
TGeoEltu.cxx, TGeoHalfSpace.cxx, TGeoHype.cxx, TGeoMaterial.cxx,
TGeoMatrix.cxx, TGeoPara.cxx, TGeoParaboloid.cxx,
TGeoPatternFinder.cxx, TGeoPcon.cxx, TGeoPgon.cxx, TGeoSphere.cxx,
TGeoTorus.cxx, TGeoTrd1.cxx, TGeoTrd2.cxx, TGeoTube.cxx,
TGeoXtru.cxx:
In calls to SavePrimitive replace comments in arguments such as
*/*option*/
by
* /*option*/
2005-02-28 20:11 rdm
* Makefile, configure, config/Makefile.in, oracle/Module.mk,
oracle/inc/LinkDef.h, oracle/inc/TOracleResult.h,
oracle/inc/TOracleRow.h, oracle/inc/TOracleServer.h,
oracle/src/TOracleResult.cxx, oracle/src/TOracleRow.cxx,
oracle/src/TOracleServer.cxx:
From Yan Liu and Shaowen Wang:
This is the first version of the new oracle plugin.
To build this plugin one needs to install the following
Oracle InstantClient rpms:
oracle-instantclient-basic-10.1.0.3-1
oracle-instantclient-devel-10.1.0.3-1
And the following environment variables in your .[bash_]profile:
export ORACLEINCDIR=/usr/include/oracle/10.1.0.3/client
export ORACLELIBDIR=/usr/lib/oracle/10.1.0.3/client/lib
export LD_LIBRARY_PATH=$ORACLELIBDIR:$LD_LIBRARY_PATH
2005-02-28 18:39 rdm
* hist/src/TF1.cxx:
revert to previous version.
2005-02-28 18:31 rdm
* README/CREDITS:
Added Dmytro Kustov for the OpenBSD port.
2005-02-28 18:28 rdm
* configure, alien/src/TAlienFile.cxx, base/inc/RConfig.h,
base/src/TMapFile.cxx, base/src/TTimeStamp.cxx,
build/unix/makelib.sh, cint/Module.mk, cint/include/platform.h,
cint/lib/ipc/ipcif.h, cint/lib/posix/posix.h, config/ARCHS,
config/Makefile.openbsd, config/root-config.in,
cint/lib/pthread/setup, cint/src/init.c,
dcache/src/TDCacheFile.cxx, eg/inc/cfortran.h,
net/src/DaemonUtils.cxx, net/src/TAuthenticate.cxx,
proofd/src/proofd.cxx, rfio/src/TRFIOFile.cxx, rootd/src/rootd.cxx,
rootx/src/rootx.cxx, rpdutils/src/daemon.cxx, rpdutils/src/net.cxx,
rpdutils/src/netpar.cxx:
From Dmytro Kustov:
OpenBSD port.
2005-02-28 18:24 rdm
* hist/src/TF1.cxx:
From Axel:
the attached diff makes TFx issue a warning when the user is trying to
save an interpreted or compiled func, which doesn't work as the streamer
cannot guess what that func might be.
2005-02-28 17:40 rdm
* graf/src/TAttImage.cxx:
fColorAlpha[i] should be initialized to 0xffff.
2005-02-28 16:42 rdm
* graf/src/TAttImage.cxx:
changed:
fColorAlpha[i] = 1 << 16;
to
fColorAlpha[i] = 1 << 15;
since fColorAlpha[i] is a UShort_t.
2005-02-28 16:42 rdm
* graf/inc/TAttImage.h:
typo in comment.
2005-02-28 15:16 brun
* hist/src/TH1.cxx:
TH1::Merge could not merge histograms with a resulting number
of entries > 2*10^9
2005-02-28 09:09 rdm
* build/: unix/makedist.sh, win/makedist.sh:
change worldmap.xpm to worldmap.jpg.
2005-02-25 22:49 brun
* treeplayer/src/: TFormLeafInfo.cxx, TTreeFormula.cxx:
From Philippe:
This patch removes warnings about unused variables.
2005-02-25 20:14 brun
* meta/src/TStreamerInfoReadBuffer.cxx:
From Philippe:
This patch insure that ReadBufferSTL and WriteBufferSTL are symetrical in
regard to empty collection (the reading was incorrect). This solves the
problem describe at
http://root.cern.ch/phpBB2/viewtopic.php?t=1437&highlight=&sid=4c28f9c455a5b
48ac9f9175ac838edf41
2005-02-25 20:13 brun
* treeplayer/: inc/TFormLeafInfo.h, src/TFormLeafInfo.cxx,
src/TTreeFormula.cxx:
From Philippe:
This correct the support for nested collections. Previously, those nested
collection were silently wrongly handled.
We now properly draw collections nested inside one collection (i.e. 2 levels
of variable size). We explicitly do not support collection nested inside a
collection nested inside a collection (i.e. we can not support 3 levels of
variable size). For those case, the user needs to use the script drawing
mechanism (or MakeProxy directly).
The nesting can be direct (vector<vector<classX> > or vector<vector<int> >)
or indirect vector<classX> which classX containing a vector<classY> or
vector<int>.
2005-02-25 18:06 brun
* cont/inc/LinkDef.h, cont/inc/TCollectionProxy.h,
cont/inc/TEmulatedCollectionProxy.h, cont/inc/TEmulatedMapProxy.h,
cont/inc/TGenCollectionProxy.h, cont/inc/TGenCollectionStreamer.h,
cont/src/TGenCollectionProxy.cxx, meta/src/TClass.cxx,
metautils/src/vectorLinkdef.h:
From Philippe:
This patch expose most of the TVirtualCollectionProxy classes to CINT. This
allow for some debugging of the collection proxy from the CINT prompt (for
example being able to tell whether the collection proxy is the emulated
proxy or not).
This patch also insures that TClass::BuildRealData do not attempt to build
for an STL collection.
This patch also adds default compiled proxy for the vector of unsigned
numerical types.
2005-02-25 17:01 rdm
* asimage/src/libAfterImage.tar.gz:
latest version with corrections from Valeriy and Sasha.
2005-02-24 16:32 rdm
* cint/Module.mk, config/Makefile.linuxia64ecc,
config/Makefile.linuxicc, config/Makefile.linuxx8664icc:
port to icc 9.0 beta.
2005-02-24 16:30 rdm
* xml/src/TXMLBuffer.cxx:
don't use <> around Riostream.h.
2005-02-24 12:29 brun
* histpainter/src/THistPainter.cxx:
From Olivier:
- In case of gStyle->SetOptStat(0), statistic boxes containing fits
parameters were not correctly drawn. The following macro showed the
problem:
gStyle->SetOptFit(1); gStyle->SetOptStat(0);
TH1D* h=new TH1D("asdf","asdf",100,0,100);
h->Fill(50,430); h->Fit("gaus");
2005-02-24 11:35 rdm
* rpdutils/src/rpdutils.cxx:
From Gerri:
Fix for a badly placed ')' in the open statement for
.rootdpass introduced in version 1.71.
2005-02-23 23:05 brun
* base/inc/RVersion.h, build/version_number:
Increment dev version number to 4.03/03
2005-02-23 21:00 brun
* hist/src/TH1.cxx:
From Philippe:
When copying an histogram into another one, one likely side effect is a
change in the name of the histogram and hence in its hash value.
Before making this change we need to make sure that the histogram has
been removed from its directory (or we will never be able to remove it
and hence could have a dangling pointer!).
This is related to the bug report at
http://root.cern.ch/phpBB2/viewtopic.php?t=1655
2005-02-23 12:47 brun
* gpad/src/TPad.cxx:
From Olivier:
- In TPad::ExecuteEvent the signal RangeChanged() is emitted after
ResizePad() when the left mouse button comes back to "up". This allows
to get the new TPad size in the function connected to RangeChanged().
After this change all the tests and tutorials have been executed and no
side effects have been noticed so far.
2005-02-23 12:46 brun
* xml/src/: TXMLBuffer.cxx, TXMLEngine.cxx, TXMLPlayer.cxx:
From Sergei Linev
1. My TXMLEngine does not correctly treat quote symbol ("), which may appear
in comments to any data member.
I fix this simple problem.
2. Somewhere between ROOT 4.01 and 4.03 algorithm how elements of STL
containers like vector<>,
set<>, deque<> are stored in TBuffer was changed. Before each element was
stored individually, now they will
be written simultaniousely by WriteFastArray operation. On binary level
it looks ok, but for xml
format it brakes compatibility with previous versions. Hopefully, this
will not affect any users.
3. In connection with previous problem I modify TXMLPlayer class to have a
propper support of STL containers
in external readers. I also add in class description link to example how
TXMLPlayer class can be used.
This example inludes additional TXmlFile class (differ from ROOT
TXMLFile) which is now also integrates own
xml parser and does not require libxml2 library.
2005-02-22 18:14 rdm
* README/README.GLOBUS, etc/hostcert.conf, rpdutils/src/globus.cxx,
rpdutils/src/rpdutils.cxx:
From Gerri:
Writing the documentation I realized that the way GSI certificates
were tested on the server side was non-optimal.
This patch fixes this; in particular it allows non-fully-privileged
servers to use GSI service certificate (ROOT-specific, ldap, ...) if
read permissions are set (before this was possible only for privileged
daemons).
2005-02-22 17:21 rdm
* build/unix/makecintdlls.sh:
some white space and alignment mods.
2005-02-22 17:19 rdm
* build/rmkdepend/main.c:
remove spurious ).
2005-02-22 17:14 rdm
* build/rmkdepend/main.c:
fix in ifdef.
2005-02-22 17:03 rdm
* build/rmkdepend/main.c, config/Makefile.macosx,
rpdutils/src/net.cxx, rpdutils/src/netpar.cxx,
rpdutils/src/ssh.cxx, unix/src/TUnixSystem.cxx:
changes needed for MacOS X 10.4 (Tiger) using g++ 4.00.
2005-02-22 07:19 brun
* build/unix/makecintdlls.sh, metautils/src/dequeLinkdef.h,
metautils/src/listLinkdef.h, metautils/src/mapLinkdef.h,
metautils/src/multimapLinkdef.h, metautils/src/multisetLinkdef.h,
metautils/src/setLinkdef.h, metautils/src/stlLoader.cc,
metautils/src/vectorLinkdef.h, utils/src/rootcint.cxx:
From Philippe:
This updates insures that when the cintdlls are loaded (for via #include
<vector> on the command line), the appropriate compiled CollectionProxy are
also loaded. Without this patch, after doing #include <vector>, if you do
tree->Branch("myarr","vector<int>",&vecptr);
then the TTree uses an EmulatedProxy instead of a compiled macro when writing
the file. EmulatedProxy are not designed to handle access to the
real collection. This causes problem especially on the platform (for
example Windows) where the memory footprint of the compiled stl container is
different from the memory footprint used by the emulation layer.
There are several new files:
metautils/src/dequeLinkdef.h
metautils/src/listLinkdef.h
metautils/src/mapLinkdef.h
metautils/src/multimapLinkdef.h
metautils/src/multisetLinkdef.h
metautils/src/setLinkdef.h
metautils/src/vectorLinkdef.h
metautils/src/stlLoader.cc
Their actual location do not matter as long as it is reflected in
makecintdll.sh (and that stlLoader.cc is NOT compile directly as part of any
library (hence the .cc extension).
stlLoader.cc is using CINT to look up if the library is loaded in pure CINT
or in ROOT (by checking for the existence of TSystem) and uses (when
available) an indirect call to TSystem::Load. This call is necessary to
avoid a compile time dependency of the cintdll libraries on the ROOT
libraries. The library loaded by stlLoader is
$ROOTSYS/libSTLDict.so
where STL is replaced by the appropriate stl container name (eg.
libvectorDict.so).
2005-02-21 19:00 brun
* hist/src/TMultiDimFit.cxx:
From Christian Holm
Fix a bug in the code generator
2005-02-21 18:58 brun
* cont/src/TGenCollectionProxy.cxx:
From Philippe:
In the case where we have an emulated class, if the class is nested (in a
class or a namespace), calling G__TypeInfo ti(inside.c_str()); might fail
because CINT does not known the nesting scope, so let's first look for an
emulated class when looking up the content of a collection.
2005-02-21 17:57 brun
* graf/inc/TGraph.h, graf/src/TGraph.cxx, hist/inc/TGraph2D.h,
hist/src/TGraph2D.cxx:
Remove references to the unused kFitInit bit
2005-02-21 16:58 rdm
* build/unix/makecintdlls.sh:
use portable expr command instead of $(()).
2005-02-21 13:04 brun
* graf/src/TFrame.cxx:
From Olivier:
- In TFrame::ExecuteEvent the margin might get small negative values. In
a such case the functions gPad->SetxxxMargin reset the margin to 0.1.
This produced weird results during interactive frame resizing. Now, if
a margin is negative in TFrame::ExecuteEvent, it is reset to 0.
2005-02-21 12:13 rdm
* rpdutils/src/rpdutils.cxx:
From Gerri:
In the patch to fix the potential problem with NFS
I have forgot to set uid back to 'root' in case of
failure with test-existence/reading/opening .rootdpass .
This makes the daemon unable to access, for example,
its own rpdauthtab for the remaining operations, and
may result in failures, especially in PROOF.
2005-02-21 11:07 rdm
* asimage/src/libAfterImage.tar.gz:
new version fixing a divide 0 in transform.c. Discovered by Reiner Rohlfs.
2005-02-21 10:44 rdm
* tree/: inc/LinkDef.h, inc/TSelectorScalar.h,
src/TSelectorScalar.cxx:
From Maarten:
Named scalar type, based on Long64_t, streamable, storable and
mergable. Ideally to be used in tree selectors in the PROOF
environment due to its merge fucntionality which allows a single
merged value to be returned to the user.
2005-02-21 10:42 rdm
* base/inc/: LinkDef3.h, TParameter.h:
From Maarten:
add SetVal() method and correct return type of GetVal().
2005-02-21 10:41 rdm
* tree/: inc/TSelector.h, inc/TSelectorCint.h, src/TSelector.cxx,
src/TSelectorCint.cxx:
package name in cvs tag was not correct.
2005-02-20 17:11 brun
* tutorials/: WorldMap.C, worldmap.jpg, worldmap.xpm:
From Valeriy Onuchin:
Replace worldmap.xpm by worldmap.jpg
2005-02-20 11:31 brun
* tree/src/TChain.cxx:
Thanks to Axel for reporting a typo in the doc of TChain::Merge
"Input File" changed to "Output File"
2005-02-19 19:48 rdm
* cint/src/ifunc.c:
From Philippe:
This patch tells G__add_templatefunc that if the user specified arguments,
those have to match even if (s)he also specified an explicit template
arguments.
2005-02-19 19:37 rdm
* hist/src/TFormula.cxx:
From Philippe:
A couple of missing ==0 are needed to prevents the issuance of wrong error
messages when creating some TFormulas (this actually appear when doing
TTree::Draw).
2005-02-18 18:16 rdm
* hist/src/TFormula.cxx:
From Philippe:
This patch adds an error message if the user tries to create a formula name
the reserved names x,y,z or t.
It also prevents this function to be added to the list of functions
(because it would lead to an infinite recursion when any other function
is created).
2005-02-18 18:11 rdm
* test/dt_RunDrawTest.C:
From Philippe:
This update improves the error message in case of failure.
2005-02-18 15:44 rdm
* net/inc/TSecContext.h, net/src/TAuthenticate.cxx,
net/src/TSecContext.cxx, rpdutils/src/rpdutils.cxx:
From Gerri:
We made some progres in understanding Marek's problem with AFS.
In fact the problem is not the lack of transmission of the token
between proofd and proofserv/slave, but the fact that different
proofds on the same machine cannot share a token, they must
initialize all their own token.
So, the problem is due to the fact that the master was tring to
re-use a token not actually reusable.
A solution for this (implemented in the patch attached) is to
switch-off the "reuse" option in case of AFS authentication.
A better one would be to export the token as we do for kerberos
or globus, but for the moment I could not find documentation
on the way to do this ... I'll probably need to dig into the
code.
2005-02-18 15:42 rdm
* proof/src/TProofServ.cxx:
correct incorrect replacing of warning message.
2005-02-18 15:27 rdm
* proof/src/: TProofServ.cxx, TSlave.cxx:
From Kris Gulbrand:
Added for both TProofServ and TSlave error-checking (for the startup phase)
in case a socket communication fails. Then TProofServ shuts down and TSlave
appropriately reacts. However, since old TProofServ's don't have the new
code, they exit because of a segv since it is early though, the net effect
will only be a printout in the proofd log and the TProofServ still shuts down.
2005-02-18 12:22 rdm
* asimage/src/TASPaletteEditor.cxx, gui/src/TGFrame.cxx,
gui/src/TGTextEdit.cxx, guibuilder/src/TGuiBldDragManager.cxx,
guibuilder/src/TRootGuiBuilder.cxx:
From Ilka:
In this patch are the necessary changes for Save dialog according to the
last TGFileDialog code with overwrite support.
2005-02-18 10:51 rdm
* rpdutils/: inc/rpdp.h, src/rpdutils.cxx:
From Gerri:
This patch does what we said, changing to target ugid before accessing
.rootdpass. I have also arranged things in such a way that the file is
accessed only once (it was two).
I have tried with NFS/root_squash on my local setup and it seems to work fine.
I have set the requirement of the permissions back to 0600.
The patch also fixes the error message logging related to Philippe problem
(it was already supposed to send the correct message, but an otherwise-harmless
assignment of pass before return was wrongly redefining it ...).
2005-02-18 10:26 rdm
* gui/: inc/TGFileDialog.h, src/TGFileDialog.cxx,
src/TRootCanvas.cxx:
Frol Ilka:
class TGFileInfo:
- a new data member: Bool_t fOverwrite (if true overwrite the file with
existing name on save without the confirmation message)
class TGFileDialog:
- added a new data member TGCheckButton *fOverWR for setting file
overwriting on/off via the GUI; setting the check box ON will
suppress the confirmation message for overwriting an existing file;
the user choice is saved for the next time the Save dialog is shown
- layout changes
- code cleaning
2005-02-18 10:15 rdm
* hist/src/TFormula.cxx, test/dt_DrawTest.C, test/dt_MakeRef.C,
tree/src/TTree.cxx, treeplayer/inc/TTreeFormula.h,
treeplayer/src/TTreeFormula.cxx:
From Philippe:
This patch extends the notion of TTree variable aliases to allow
them to be used as part of single data name.
For example, you can now do:
tree->SetAlias("theGoodTrack","event.fTracks[3]");
tree->Draw("theGoodTrack.fPx"); // same as "event.fTracks[3].fPx"
This patch includes a little clean-up in TTreeFormula::DefinedVariable
to better separate the different phases of the parsing (dimension requests,
leaf finding and exploration into the user class).
This patch also includes an update to DrawTest to test for the new alias
feature and in case of failure to print the corresponding Draw command.
2005-02-17 15:35 rdm
* mysql/src/TMySQLServer.cxx:
Fix mysql_shutdown() which changed API for versions >=50001 or
version<50000 and version>=40103 (a mess).
2005-02-17 12:59 rdm
* graf/src/TPaveText.cxx:
From Olivier:
- In PaintPrimitives, the variable "textsize" was sometimes too large. The
text was drawn outside of the pave frame and when the frame was close
to the pad border it was not drawn in PostScript files.
2005-02-16 21:30 brun
* cint/src/ifunc.c:
From Philippe:
fix (my previous change to the while condition was incorrect)
2005-02-16 21:18 brun
* treeplayer/src/TTreeProxyGenerator.cxx:
From Philippe:
This update adds the ability to create the tree proxy in a subdirectory
(previously the full pathname was used as the class name!)
2005-02-16 20:57 brun
* cint/src/ifunc.c:
From Philippe:
In the function G__add_templatefunc, the handling for an explicit template
argument was insufficient. After find a first possible match, the old code
was basically removing the request for an explicit instantiation. In
addition the last template function was never looked at.
2005-02-16 19:45 rdm
* configure:
small typo.
2005-02-16 19:32 rdm
* Makefile, build/unix/makecintdlls.sh:
Gcc 4.0 does not support the -I- option anymore, now replaced by -iquote.
Was used in makecintdlls.sh. Also added command echo to makecintdlls.sh
for easier build debugging.
2005-02-16 19:23 rdm
* cint/lib/prec_stl/iterator:
fix typo and some more G__GNUC>=4 stuff.
2005-02-16 16:22 brun
* gui/src/TRootContextMenu.cxx:
From Ilka:
fix in the TRootContextMenu::ProcessMessage method.
keeping gPad to point to the pad where a context menu was popped up.
(Thanks to Mathieu de Naurois for reporting thsi problem)
2005-02-16 15:28 rdm
* cint/: lib/dll_stl/str.h, lib/dll_stl/vec.h, lib/prec_stl/deque,
lib/prec_stl/iterator, lib/prec_stl/list, lib/prec_stl/map,
lib/prec_stl/multimap, lib/prec_stl/multiset, lib/prec_stl/set,
lib/prec_stl/string, lib/prec_stl/vector, stl/_iterator.h:
add case for G__GNUC>=4 so now ROOT compiles with gcc 4.0.
2005-02-16 11:31 brun
* hist/inc/TH1.h:
Add new function TH1::GetSumw2
2005-02-16 11:24 brun
* win32gdk/gdk/src/gdk/win32/gdkdrawable-win32.c:
From Bertrand
- On wingdk the polygons were always drawn with an outline and the fill
patterns were not transparent.
2005-02-16 09:39 brun
* graf/: inc/TGraph.h, src/TGraph.cxx:
n the previous version of TGraph::Fit, points were assumed to be given in increasing order along X. This restriction is removed in this new version.
The new implementation forces a change in the API of the following functions.
virtual void InitExpo(Double_t xmin=0, Double_t xmax=0);
virtual void InitGaus(Double_t xmin=0, Double_t xmax=0);
virtual void InitPolynom(Double_t xmin=0, Double_t xmax=0);
virtual void LeastSquareFit(Int_t m, Double_t *a, Double_t xmin=0, Double_t xmax=0);
virtual void LeastSquareLinearFit(Int_t n, Double_t &a0, Double_t &a1, Int_t &ifail, Double_t xmin=0, Double_t xmax=0);
2005-02-16 02:29 rdm
* treeplayer/src/: TBranchProxyClassDescriptor.cxx,
TTreeProxyGenerator.cxx:
From Philippe:
This fixes the support for branch formed from a leaflist with more than one
leaf!
2005-02-16 02:27 rdm
* utils/src/rootcint.cxx:
From Philippe:
when rootcint is using the rootmap file (CINT's autoloading), it can not
properly understand the template instantiation listed in the rootmap file.
This is because the autoloading assumes that the dictionary will be loaded
and do not do the template instantiation. The right solution is likely to
be to load the shared library. However in the meantime, we work around the
issue by not loading TImpProxy in CINT's autoload map. (Without this patch
some MakeProxy file can not have their dictionary generated by ACLiC because
CINT mistakenly call the operator= for the selector).
2005-02-15 18:01 brun
* gui/src/TGMenu.cxx, test/guitest.cxx, tutorials/guitest.C:
From Ilka:
- fix in the TGPopupMenu::HandleButton method to allow submenu creation in the context menu (thanks to Mathieu de Naurois)
- fix in the guitest.C, guitest.cxx examples of the context menu entries according to the menu ids
2005-02-15 17:19 brun
* gpad/src/TPad.cxx:
From Olivier:
- PaintFillAreaHatches should be called only when the fill style is
greater than 3100 AND smaller than 4000. The test against 4000 was
missing in two places.
2005-02-15 17:17 brun
* matrix/inc/TMatrixDEigen.h, matrix/inc/TMatrixDSymEigen.h,
matrix/src/TDecompBK.cxx, matrix/src/TDecompChol.cxx,
matrix/src/TDecompLU.cxx, matrix/src/TDecompQRH.cxx,
matrix/src/TDecompSVD.cxx, matrix/src/TDecompSparse.cxx,
matrix/src/TMatrixDEigen.cxx, matrix/src/TMatrixDSymEigen.cxx,
test/stressLinear.cxx:
From Eddy Offermann
Here a patch to remove some inconsistencies/bugs in the indexing of the
decomposed matrices and eigen-vectors/-values in case the row/column
index
did not start 0 .
The tests in stressLinear were modified/extended to check these cases .
2005-02-15 16:39 brun
* histpainter/src/TPaletteAxis.cxx:
From Olivier:
- In case of (LogZ && zmax > 0 && zmin <= 0), zmin was set to 0.001*zmax
whereas it is set to min(1,0.001*zmax) in THistPainter::TableInit.
Now zmin is set like in TableInit.
2005-02-15 14:45 brun
* hist/src/TH1.cxx:
from Marek Biskup;
This is the patch for TH1 solving Rebin problem.
Now I'll start working on THx::Merge.
2005-02-15 10:57 rdm
* meta/src/TCint.cxx:
AddIncludePath() is now first calling ExpandPathName() on the path argument.
2005-02-14 17:43 brun
* meta/src/TStreamerElement.cxx:
From Philippe:
This patch insures backward compatibility for file created with 'bool' as
type 11 (we already introduced the same change for 'Bool_t' stored as type
11).
2005-02-14 16:59 brun
* hist/src/TProfile.cxx:
In TProfile::ProjectionX, binEntries was never set to kTRUE when option "b"
was given.
2005-02-14 16:12 brun
* graf/src/TGraph.cxx:
From Olivier:
- When an histogram with negative content only was painted as a filled
area, the drawing exited the pad.
2005-02-14 16:07 brun
* base/inc/TStyle.h, base/src/TStyle.cxx, gpad/src/TPad.cxx:
From Olivier:
- SetHatchesSpacing allow to modify the spacing between hatches for hatch
styles greater than 3100.
2005-02-14 13:54 rdm
* treeplayer/src/TSelectorDraw.cxx:
From Bertrand:
fix compilation error on MSVC6.
2005-02-12 20:45 brun
* config/rootrc.in:
From Bertrand Bellenot:
Use Net* API functions by default, since they
are not called at startup time anymore.
2005-02-12 10:52 brun
* config/rootrc.in, winnt/inc/TWinNTSystem.h,
winnt/src/TWinNTSystem.cxx:
From Bertrand Bellenot:
Added ROOT Environment variable UseNetAPI, allowing users to choose to use Net*
API functions or not.
Note that if UseNetAPI is set to false, it is not possible to get infos on any
group or any user on the local machine :
Any call to gSystem->GetUserInfo() will return only current user infos.
In order to be able to collect informations on any local user /
group,UseNetAPI must be set to true.
Mods in TWinNTSystem to collect local users and groups infos only at first call
to a user/group related method, and only if UseNetAPI ROOT Environment variable
is set to true.
I would advise to keep Net* API functions enabled, as now they are used only if
needed, i.e when calling gSystem->GetUserInfo().
2005-02-12 03:14 rdm
* test/ProofBench/: Run_Simple_Test.C, make_tdset.C:
From Maarten:
Run_Simple_Test.C changed to take max number of files into account.
2005-02-12 03:14 rdm
* proofd/src/proofd.cxx, rootd/src/rootd.cxx:
From Maarten:
Added "-h" rootd/proofd, print usage also on bad option.
2005-02-11 22:48 brun
* utils/src/rootcint.cxx:
From Philippe:
This patch avoid a buffer overflow due to CINT's m.MaxIndex returning
-429496729.
2005-02-11 21:51 brun
* hist/src/TProfile.cxx:
New option "B" in TProfile::ProjectionX
//
// if option "E" is specified, the errors are computed. (default)
// if option "B" is specified, the content of bin of the returned histogram
// will be equal to the GetBinEntries(bin) of the profile,
// otherwise (default) it will be equal to GetBinContent(bin)
2005-02-11 20:06 rdm
* Makefile:
remove warnings for not yet existing .d files.
2005-02-11 19:40 rdm
* base/src/TQCommand.cxx, cint/Module.mk, gl/Module.mk,
gui/src/TGFrame.cxx, gui/src/TGToolBar.cxx, meta/src/TCint.cxx,
mlp/src/TMultiLayerPerceptron.cxx, net/src/TAuthenticate.cxx,
netx/src/TXProtocol.cxx, physics/src/TRolke.cxx,
proofd/src/proofd.cxx, pyroot/src/MemoryRegulator.cxx,
pyroot/src/PropertyHolder.cxx, pyroot/src/Pythonize.cxx,
rootd/src/rootd.cxx, table/src/TDataSet.cxx,
table/src/TVolumeView.cxx, thread/src/TThread.cxx,
tree/src/TLeafO.cxx, x11/src/GX11Gui.cxx:
remove warnings reported by gcc 4.0.0. Everything compiles without warnings
except for an error in G__Base2.cxx.
2005-02-11 17:42 brun
* treeplayer/src/TSelectorDraw.cxx:
From Marek Biskup
Fix a few problems when drawing 3-d or 4-d plots with option COL
2005-02-11 17:38 brun
* x11/src/TGX11.cxx:
From Marek Biskup
Fix a loop overflow problem in TGX11::DrawPolyMarker
This problem is showing up when using PROOF on a large data sample.
2005-02-11 13:41 brun
* postscript/src/TPostScript.cxx:
From Olivier:
- Help improvements (output type description added).
2005-02-11 11:38 brun
* gpad/src/TPad.cxx:
From Olivier:
- PaintFillAreaHatches was not called in PaintBox in batch mode (fill
style > 3100 were not visible in PostScript files in that case).
2005-02-11 11:26 brun
* postscript/src/TPostScript.cxx:
Move the class description at the right place at the start of the class.
2005-02-11 00:02 brun
* tree/src/TBranch.cxx:
From Philippe:
This patch adds a missing CheckByteCount for Tbranch version 6 through 8.
2005-02-10 21:44 brun
* hist/src/TF1.cxx:
From Philippe:
This patch protect against calling TF1::GetXaxis before a pad is created
2005-02-10 14:01 brun
* tree/src/TTree.cxx:
From Olivier:
- Option COL is now documented in TTree::Draw
2005-02-10 13:51 rdm
* proof/src/TSlave.cxx:
From Kris Gulbrand:
add code to check against not supported remote versions. Now the client,
master and workers should be >= version 4, due to the massive
multi-level-master changes.
2005-02-10 13:49 rdm
* proof/: inc/TProof.h, src/TProof.cxx:
document why protocol was changed from version 3 to 4.
2005-02-10 13:48 rdm
* config/rootrc.in:
change TPProof to TProofPEAC.
2005-02-10 13:47 rdm
* krb5auth/src/TKSocket.cxx:
explicitly include errno.h, needed on some platforms.
2005-02-10 08:32 brun
* base/src/TApplication.cxx:
From Axel Naumann:
with this patch, TApplication issues a warning if its name is "Rint" (to allow applications to implement their own params) and the macro-argument cannot be found.
2005-02-10 08:29 brun
* meta/src/TStreamerInfo.cxx:
From Philippe:
If the user's comment for a TClonesArray pointer contains a set of
parenthesis, we need to take the last set of paranthesis to lookup
the TClonesArray's content name.
2005-02-10 08:26 brun
* treeplayer/src/TTreeProxyGenerator.cxx:
From Philippe:
This patch improves the support for classes with multiple level of
inheritance and embedded split object (From Dzero TopTree example).
2005-02-10 08:24 brun
* table/src/TTable.cxx:
From Valeri Fine:
a minor correction for "table/src/TTable.cxx". It replaces the
message that scares my users with more modest one.
2005-02-10 08:22 brun
* qt/src/TGQt.cxx:
From Valeri Fine:
a minor correction of TGQt.cxx
It is essentally to document the Fons's advice hwo to make RPPT fomts
available for Qt-layer. However I have to play a little bit with this new
feature to make it up to resolve the issue.
2005-02-09 22:05 brun
* rpdutils/src/net.cxx:
From Maarten:
Add fallback port numbers to rootd/proofd so these can be run without
entries in /etc/service.
2005-02-09 17:59 brun
* test/stress.cxx:
Change the reference number of lines in stress5 (following the new box algorithm)
2005-02-09 17:47 brun
* tree/src/TTree.cxx:
From Philippe:
In TTree::Bronch generalize the Warning in case the object's class is
not-splittable and the requested splitlevel is greater than 0. In this
case the split level is reset to 0. (This extend the previous warning to
TRefs, TArray, TVectorF, etc..
2005-02-09 17:33 brun
* base/inc/RVersion.h:
Version 4.03/02 ready
2005-02-09 17:31 brun
* build/version_number:
make version 4.03/02
2005-02-09 15:33 brun
* geom/src/TGeoVolume.cxx:
A TGeoVolume object drawn in a canvas can be saved via TCanvas::SaveAs.
2005-02-09 14:30 brun
* geom/inc/TGeoAtt.h, geom/inc/TGeoManager.h,
geom/inc/TGeoMaterial.h, geom/inc/TGeoMatrix.h,
geom/inc/TGeoMedium.h, geom/inc/TGeoPatternFinder.h,
geom/inc/TGeoVolume.h, geom/src/TGeoAtt.cxx,
geom/src/TGeoCache.cxx, geom/src/TGeoCompositeShape.cxx,
geom/src/TGeoCone.cxx, geom/src/TGeoManager.cxx,
geom/src/TGeoMaterial.cxx, geom/src/TGeoMatrix.cxx,
geom/src/TGeoMedium.cxx, geom/src/TGeoNode.cxx,
geom/src/TGeoPatternFinder.cxx, geom/src/TGeoPcon.cxx,
geom/src/TGeoPgon.cxx, geom/src/TGeoTube.cxx,
geom/src/TGeoVolume.cxx, geom/src/TGeoXtru.cxx,
geompainter/src/TGeoPainter.cxx:
From Mihaela Gheata;
- divisions supporting SavePrimitive
- main SavePrimitive loop implemented at level of TGeoVolume
- user interface: TGeoVolume::SaveAs(const char *filename); having *MENU*
- can be called from the browser for any volume:
the resulting file will have a geometry starting with the selected
volume as TOP.
- should work with TPad::SavePrimitive(ofstream out, Option_t *option)
- not tested however
From Andrei:
I did some changes in TGeoCombiTrans to support a shared rotation matrix.
I also fixed a bug in TGeoTube::GetMakeRuntimeShape (and tube segment)
that produced wrong shapes in case one of the initial parameters was negative.
2005-02-09 12:47 brun
* treeviewer/src/TTreeViewer.cxx:
Remove a debug printf statement in TTreeViewer::ExecuteCommand.
Do not show the inactive branches in the browser.
2005-02-09 11:19 brun
* treeplayer/src/TTreeFormula.cxx:
Add a protection in TTreeFormula::ResetDimensions.
Found a case (Vivek Jain file) where gcut was null.
2005-02-09 08:55 brun
* test/eventa.cxx:
Remove the call to event->Clear in the event loop.
This call is not necessary anymore with the current or relative recent
versions of ROOt
2005-02-09 08:26 brun
* tree/src/TTree.cxx:
In TTree::Bronch print a Warning in case the pointer to the class is
a ROOT collection and the splitlevel > 0. In this case the split level is reset to 0.
2005-02-09 07:19 brun
* qt/src/TGQt.cxx:
From Valeri Fine:
Clean solution for 64-but platform for TCanvas's. However I
am realizing I have to check some other objects (fonts, pixmaps) also. I am
keeping checking things. They are casted to Window_t ROOT type, that I hope
is safe in 64-bit env to hold the pointers.
2005-02-08 23:49 rdm
* config/rootrc.in:
change name of TProofSMaster -> TProofSuperMaster.
2005-02-08 23:45 rdm
* proof/src/TProofServ.cxx:
From Maarten:
Fix for running in sequential mode on the master. Need to do something
about statistics, feedback and progress info.
Note that running sequential with one master and one slave works fine.
2005-02-08 23:40 rdm
* peac/src/TProofPEAC.cxx, proof/inc/TProofServ.h,
proof/inc/TSlave.h, proof/src/TProof.cxx,
proof/src/TProofPlayer.cxx, proof/src/TSlave.cxx:
Change so that GetOrdinal() returns a "const char *" instead of a
"const TString &". This is more inline with the rest of the code where
getters of TString data members return a const char*.
2005-02-08 23:38 rdm
* test/ProofBench/: Run_Simple_Test.C, make_event_trees.C,
make_tdset.C:
From Maarten:
Cleanup and fix some test scripts. Run_Simple_Test.C is worth using!
2005-02-08 23:38 rdm
* proof/src/: TPacketizer.cxx, TPacketizer2.cxx:
From Maarten:
This brings the two packetizers in sync, as far as bug fixes goes.
2005-02-08 19:04 brun
* base/src/TSystem.cxx:
From Axel Naumann:
when rootcint fails in Aclic, the compiler is invoked to check the code. This
did not work when the macro to be compiled is a header, as the compiler refuse
to compile headers. This happens e.g when compiling MakeProxy generated code
(yes, Philippe warned me :-).
The attached patch fixes that. A temporary gSystem->Link() is created to a
*.check.cxx file if the filename is a header, and the compiler is then invoked
on this *check.cxx file. I also attached a test case (.L TestHeader.h+).
2005-02-08 17:35 brun
* histpainter/src/THistPainter.cxx:
Fix a compiler warning about possible uninitialized variable
2005-02-08 17:33 brun
* histpainter/src/THistPainter.cxx:
From Olivier:
- Option BOX Improvements: a box is drawn for each cell with surface
proportional to the content's absolute value. A negative content is
marked with a X.
- New option BOX1: a button is drawn for each cell with surface
proportional to content's absolute value. A sunken button is drawn for
negative values a raised one for positive.
2005-02-08 16:47 brun
* ged/src/TPadEditor.cxx:
From Ilka:
fixes a typo in a label of the pad editor (thanks to Olivier).
2005-02-08 15:34 brun
* treeplayer/: inc/TTreePlayer.h, src/TTreePlayer.cxx:
Implement TTreePlayer::RecursiveRemove to cleanup pointers like fHistogram
in case fHistogram is deleted outside the TTreePlayer.
2005-02-08 14:34 brun
* gui/src/TGButton.cxx:
From Valeriy Onuchin:
- add switching on/off check/radio buttons highlighting on crossing event
2005-02-08 12:58 rdm
* proof/src/TProofPlayer.cxx:
added some comments. Still many missing.
2005-02-08 12:20 brun
* vmc/: inc/TVirtualMC.h, src/TVirtualMC.cxx:
From Ivana:
- Removed default implementation for the recent functions
and made them pure anstract (=0)
- Removed fIsRootGeometrySupported data member;
this info should be returned via IsRootGeometrySupported() function
2005-02-08 12:16 rdm
* Makefile:
avoid deleting rootd/misc/rootd.rc.d during distclean.
2005-02-08 12:11 brun
* gui/src/TGButton.cxx:
From Valeriy (test by Ilka)
I added "check/dradio buttons highlighting".
I'll add correspondent changes to HandleCrossEvent
2005-02-08 12:07 brun
* proof/src/TProofPlayer.cxx:
Previous fix by Bertrand was not correct for gcc.
2005-02-08 12:02 brun
* proof/src/: TProof.cxx, TProofPlayer.cxx:
From Bertrand,
Solves compilation errors on windows.
2005-02-08 12:00 brun
* ged/src/TGraphEditor.cxx:
From Ilka:
an additional fix in TGraphEditor following a recent change in the GUI button classes: signal Clicked(Int_t) is replaced by Pressed(Int_t) in the method TGraphEditor::ConnectSignals2Slots()
2005-02-08 09:27 rdm
* cont/: inc/THashTable.h, src/THashTable.cxx:
From Axel Naumann:
New methods:
TList *GetListForObject(const char *name)
TList *GetListForObject(const TObject *obj)
return the TList corresponding to object's name or pointer based hash value.
One can iterate this list "manually" to find, e.g. objects with
the same name or pointer. Be warned that also other objects that have the
same hash but a different name or ptr may be in the list.
2005-02-08 08:36 brun
* qt/: inc/TGQt.h, inc/TQtSymbolCodec.h, inc/TQtTermInputHandler.h,
inc/TQtThread.h, inc/TQtThreadStub.h, inc/TQtTimer.h,
inc/TQtWidget.h, src/TGQt.cxx, src/TQtSymbolCodec.cxx,
src/TQtTermInputHandler.cxx, src/TQtThread.cxx, src/TQtTimer.cxx,
src/TQtWidget.cxx:
From Valeri Fine:
Optimization:
------------------
- Change the default value for "quality" parameters of TGQtWidget::save method
- Add the "maxTime" parameter to "processQtEvents "method with the default value "maxtime=300"
- some comments clean up
- new CPP macros for the threaded version of TVirtualX
Fixes:
--------
TQtSymbolCodec class introduced to treat the ROOT font 12 in the case of the system lack of "symbol.ttf" installed
New:
-------
TQtWidget - Introduce a Qt QTimer to manage ROOT events from within Qt event loop
for Qt main applications
TGQt - Introduce a ROOT TTimer to manage Qt events from within ROOT event loop
2005-02-08 01:57 rdm
* krb5auth/src/TKSocket.cxx:
include <sys/types.h> is needed on MacOS X.
2005-02-07 23:47 brun
* gui/: inc/TGButton.h, src/TGButton.cxx, src/TGButtonGroup.cxx:
From valeriy Onuchin:
- corrections for TGCheckButton, TGRadioButton IsDown, IsOn methods.
- protection against possible recursivity in TGButtonGroup::SetButton method
2005-02-07 19:12 rdm
* configure:
fix check for xmlrpc-c-config.
2005-02-07 19:02 rdm
* Makefile, configure, README/CREDITS, base/inc/MessageTypes.h,
base/inc/TVirtualPerfStats.h, base/inc/TVirtualProof.h,
base/src/TROOT.cxx, clarens/Module.mk, clarens/inc/LinkDef.h,
clarens/inc/TClProxy.h, clarens/inc/TClSession.h,
clarens/inc/TClarens.h, clarens/inc/TEcho.h, clarens/inc/TGM.h,
clarens/inc/TLM.h, clarens/inc/TSAM.h, clarens/inc/TXmlRpc.h,
clarens/src/TClProxy.cxx, clarens/src/TClSession.cxx,
clarens/src/TClarens.cxx, clarens/src/TEcho.cxx,
clarens/src/TGM.cxx, clarens/src/TLM.cxx, clarens/src/TSAM.cxx,
clarens/src/TXmlRpc.cxx, config/Makefile.depend,
config/Makefile.in, config/rootrc.in, krb5auth/inc/LinkDef.h,
krb5auth/inc/TKSocket.h, krb5auth/src/TKSocket.cxx, peac/Module.mk,
peac/inc/LinkDef.h, peac/inc/LinkDefGui.h, peac/inc/TPEAC.h,
peac/inc/TProofPEAC.h, peac/inc/TProofStartupDialog.h,
peac/src/TPEAC.cxx, peac/src/TProofPEAC.cxx,
peac/src/TProofStartupDialog.cxx, krb5auth/Module.mk,
net/src/TFTP.cxx, net/src/TSocket.cxx, proof/etc/proof.conf.sample,
proof/inc/LinkDef.h, proof/inc/TCondor.h, proof/inc/TPerfStats.h,
proof/inc/TProof.h, proof/inc/TProofLimitsFinder.h,
proof/inc/TProofPlayer.h, proof/inc/TProofServ.h,
proof/inc/TSlave.h, proof/src/TCondor.cxx,
proof/src/TPacketizer.cxx, proof/src/TPacketizer2.cxx,
proof/src/TPerfStats.cxx, proof/src/TProof.cxx,
proof/src/TProofLimitsFinder.cxx, proof/src/TProofPlayer.cxx,
proof/src/TProofServ.cxx, proof/src/TSlave.cxx,
rpdutils/src/rpdutils.cxx, test/ProofBench/Draw_Slave_Access.C,
test/ProofBench/EventTree_NoProc.h,
test/ProofBench/EventTree_Proc.h,
test/ProofBench/EventTree_ProcOpt.h,
test/ProofBench/Run_Simple_Test.C,
test/ProofBench/make_event_trees.C, test/ProofBench/make_tdset.C,
tree/inc/TDSet.h, tree/src/TDSet.cxx,
treeplayer/inc/TFriendProxyDescriptor.h,
treeplayer/src/TFriendProxy.cxx, unix/src/TUnixSystem.cxx:
From Maarten and Kristjan Gulbrandsen:
Here is the patch with the restructured PROOF code. It parameterizes
PROOF startup, currently implementing "Standard", Condor, MLM and PEAC.
It can easily be extended with other "TProof" classes, e.g. AliEn Proof.
Or what ever next Grid implementation or scheduler comes along.
The MLM, Multi Level Master, code uses a basic packetizer, based on a
MSD (massstorage domain) tag. In MLM mode we have multi-tier client
server setup, like:
client -> super master -> sub master 0 -> slave[0..N]
...
-> sub master M -> slave[0..N]
It also contains a large number of smaller fixes. Credit for most of
the work goes to Kris!
We have tested this on multipe platforms (RH7.3, RH9, SL3) and in
multiple configurations. Should be stable.
2005-02-07 18:23 brun
* treeplayer/: inc/TTreeFormula.h, src/TTreeFormula.cxx,
src/TTreeIndex.cxx:
From Philippe:
This patch insures that TTreeFormula only call GetEntry once per branch
per entry (This speeds up evaluating formula where the same branch is use
several times).
Update TTreeIndex (and hence TTree::BuildIndex) to be able to
work correctly independently of the state of the TTree object (It previously
__required__ TTree::fReadEntry to be equal to -1).
Make TTreeIndex::Print platform independent (it was not
printing correctly on windows).
2005-02-07 15:55 brun
* ged/src/TGraphEditor.cxx:
From Ilka:
Fix in TGraphEditor following a recent change in the GUI functions
2005-02-07 15:35 brun
* graf/src/: TCurlyArc.cxx, TCurlyLine.cxx:
Remove CRTL/M characters
2005-02-07 15:34 brun
* graf/src/: TGraphAsymmErrors.cxx, TGraphBentErrors.cxx,
TGraphErrors.cxx:
From Olivier:
- The errors boxes attributes (option E2) were not right when the graph
was painted in an existing TFrame.
2005-02-05 18:04 brun
* winnt/src/TWinNTSystem.cxx:
From Bertrand:
Solves the missing break in long lines on windows command prompt.
2005-02-05 08:27 brun
* meta/src/TStreamerElement.cxx:
From Philippe:
TStreamerElement::fSize is set to the actual size of the element. Since it
already takes into account the number of element of the array (if any),
there is no need to remultiply (and this leads to very large number if the
array is large!). This can be a problem only in the case of emulated
classes.
2005-02-05 02:33 rdm
* base/src/TApplication.cxx:
in ProcessFile() fix the comment (/* */) parsing so we can handle
cases like: /* */ /*. Bug was reported by Pedro Miguel Esteves Ramalhete.
2005-02-04 23:40 rdm
* metautils/Module.mk:
rootcint_tmp was not correctly specified for windows where it is
rootcint_tmp.exe.
2005-02-04 23:37 brun
* metautils/Module.mk:
From Philippe:
This patch corrects the dependency of rootcint_tmp for the metautils
dictionary. It was wrong for windows and was breaking (surprisingly enough
:) ) only the parallel build.
2005-02-04 23:34 brun
* base/src/TMath.cxx:
From Victor:
Fix a bug in TMath::Hash reported by Mathieu de Naurois
2005-02-04 14:07 brun
* gpad/src/TUtilPad.cxx, hist/src/TH1.cxx:
Change TH1::DrawPanel such that invoking DrawPanel will automatically
draw the histogram in a canvas and invoke the editor.
2005-02-04 13:53 brun
* histpainter/src/TPainter3dAlgorithms.cxx:
From Olivier:
- The protections added in revision 1.16 in LegoFunction must be after the
logarithms computation (ab[..]) because the limit values stored in
Hparam (xmin, xmax etc ...) are already logarithmic.
2005-02-04 08:57 brun
* gpad/src/TInspectCanvas.cxx:
In TInspectCanvas::Inspector do not set the bit kMustCleanup for
the inspected object.
In the TInspectcanvas destructor do not delete the objects in the list
of objects in the inspector. Deleting objects with the kCanDelete bit set
had side-effects for objects in the stack.
2005-02-03 21:35 rdm
* gl/Module.mk:
clean GLO1 too.
2005-02-03 21:32 brun
* mlp/src/TMLPAnalyzer.cxx:
From Axel:
forgot to remove a work-around in mlp, for a problem that was fixed by the
previous patch.
2005-02-03 17:58 brun
* geom/: inc/TGeoShape.h, src/TGeoArb8.cxx, src/TGeoBBox.cxx,
src/TGeoCompositeShape.cxx, src/TGeoCone.cxx, src/TGeoEltu.cxx,
src/TGeoHalfSpace.cxx, src/TGeoHype.cxx, src/TGeoPara.cxx,
src/TGeoParaboloid.cxx, src/TGeoPcon.cxx, src/TGeoPgon.cxx,
src/TGeoSphere.cxx, src/TGeoTorus.cxx, src/TGeoTrd1.cxx,
src/TGeoTrd2.cxx, src/TGeoTube.cxx, src/TGeoXtru.cxx:
Fix from Andrei to fix a compilation problem on Solaris.
2005-02-03 15:25 brun
* tree/src/TTree.cxx:
From Philippe:
update to the documentation specifiying the actual result of the
TTree::Draw in case of 2 variables.
2005-02-03 14:03 brun
* hist/src/TH1.cxx:
From Jonathan Hays (confirmed by Christos Leonidopoulos)
In TH1::GetAsymmetry the compuation of the bin errors was not correct
From the Jonathan's original mail
"Calculation of histogram errors in TH1::GetAsymmetry appears to be incorrect:
error = 2*TMath::Sqrt(a*a*c2*c2*db*db + c2*c2*b*b*da*da+a*a*b*b*dc2*dc2)/(a+b);
Should read:
error = 2*TMath::Sqrt(a*a*c2*c2*db*db + c2*c2*b*b*da*da +
a*a*b*b*dc2*dc2)/bot/bot;
a) Factor (a+b) in denominator should take into account weight c2. So should be
(a+c2*b) or simply "bot"
b) Factor (a+b) in denominator should also be squared
A = (a - c2*b) / (a + c2*b);
dA/da = 2*c2*b/(a+c2*b)2 ; dA/db = -2*c2*a/(a+c2*b)2; dA/dc2 = -2*a*b/(a+c2*b)2;
Which gives:
error = (2 / (a+c2*b)2 ) * sqrt( c2*c2*b*b*da*da + c2*c2*a*a*db*db +
a*a*b*b*dc2*dc2);
2005-02-03 12:40 brun
* geom/: inc/TGeoArb8.h, inc/TGeoBBox.h, inc/TGeoCompositeShape.h,
inc/TGeoCone.h, inc/TGeoEltu.h, inc/TGeoHalfSpace.h,
inc/TGeoHype.h, inc/TGeoMaterial.h, inc/TGeoMatrix.h,
inc/TGeoMedium.h, inc/TGeoPara.h, inc/TGeoParaboloid.h,
inc/TGeoPcon.h, inc/TGeoPgon.h, inc/TGeoShape.h, inc/TGeoSphere.h,
inc/TGeoTorus.h, inc/TGeoTrd1.h, inc/TGeoTrd2.h, inc/TGeoTube.h,
inc/TGeoVolume.h, inc/TGeoXtru.h, src/TGeoArb8.cxx,
src/TGeoBBox.cxx, src/TGeoCompositeShape.cxx, src/TGeoCone.cxx,
src/TGeoEltu.cxx, src/TGeoHalfSpace.cxx, src/TGeoHype.cxx,
src/TGeoMaterial.cxx, src/TGeoMatrix.cxx, src/TGeoMedium.cxx,
src/TGeoPara.cxx, src/TGeoParaboloid.cxx, src/TGeoPcon.cxx,
src/TGeoPgon.cxx, src/TGeoSphere.cxx, src/TGeoTorus.cxx,
src/TGeoTrd1.cxx, src/TGeoTrd2.cxx, src/TGeoTube.cxx,
src/TGeoVolume.cxx, src/TGeoXtru.cxx:
From Andrei Gheata:
The diffs for the changes from Mihaela. They implement the SavePrimitive method for:
- all shapes
- materials, mixtures and media
- matrices
- TGeoVolume - just a first version
What is missing:
Divisions + manager metod to save:
- all geometry
- just the branch corresponding to one volume
The differences compared to g2root are that:
- when saving just a a branch just materials/media/matrices for that branch are created (module encapsulation)
- instead of creating objects with numerical arguments, the coresponding variables are defined and used.
e.g. instead of :
new TGeoBBox("name", 10.,20.,30); the generated code is:
dx = 10.;
dy = 20.;
dz = 30.;
pShape = new TGeoBBox("name", dx,dy,dz);
The diffs contain also 2 shapes with boundary-safe algorithms: TGeoPara and TGeoTrap
2005-02-03 09:46 brun
* minuit/src/TFitter.cxx:
Fix in Graph2DFitChisquare. The call to InitArgs must be inside the loop.
2005-02-03 09:01 brun
* gpad/src/TCanvas.cxx:
From Otto Schaile
Fix in TCanvas::Streamer to correctly save the colors created
via the color widget and when there is a gap in the list of colors.
2005-02-03 08:31 brun
* tutorials/mlpRegression.C:
From Axel Naumann:
I've created a tutorial macro showing the use of an ANN for regression analysis: given a set {i} of input vectors i and a set {o} of output vectors o, one looks for the unknown function f with f(i)=o. The ANN can approximate this function; the DrawTruthDeviation methods can be used to evaluate the quality of the approximation.
Most people know ANNs only as classification tools, not for regression, that's why I though it might be useful.
2005-02-03 08:29 brun
* mlp/: inc/TMLPAnalyzer.h, src/TMLPAnalyzer.cxx,
src/TMultiLayerPerceptron.cxx:
From Axel Nauman & Christophe Delaere
This patch fixes a bug in DrawNetwork, where the hists' upper edge was smaller than the lower edge (this was causing the corrupted histos in the mlpHiggs tutorial). I updated the new regression methods (some null pointer checks, better labels) and their doc. I added the following comment to the doc of TMultiLayerPerceptron: "(One should still try to pass normalized inputs, e.g. between [0.,1])", and added labels for the output nodes in Draw.
2005-02-03 07:27 brun
* gl/Module.mk:
From Axel Naumann;
win32gcc needs the x11 inc path, otherwise it'll pick up the wrong headers.
2005-02-02 19:24 brun
* hist/inc/TGraph2DErrors.h:
Fix a typo in GetZ. (was returning fEy instead of fEZ)
2005-02-02 18:45 brun
* ged/src/TGedEditor.cxx, gui/src/TRootCanvas.cxx:
From Ilka:
With this patch an embedded editor can be activated via View/Editor menu
in any canvas created in a root session.
2005-02-02 18:42 brun
* matrix/: inc/TVectorD.h, inc/TVectorF.h, src/TVectorD.cxx,
src/TVectorF.cxx:
From Eddy:
patch for a special case in matrix-vector multiplication:
The following scenario does the wrong memory management :
Double_t *a = new Double_t[n];
TVector v; v.Use(n,a)
TMatrixD m(5,5);
.
.
v *= a;
The vector v has the same length after the matrix multiplication, so
in principle there is no need for allocation of new space .
Nevertheless, the previous code did it and failed in the case the
vector
storage was used and not owned .
Now we have the correct behavior:
- if the vector is using another array for storage and the
multiplication
would mean a resizing, an error message is produced (as before)
- if the vector is using another array for storage and the
multiplication
keeps the vector length/indexing the same, the multiplication
can proceed !
2005-02-02 18:37 brun
* globusauth/src/GlobusAuth.cxx:
From Gerri
The problem was due to a non-orthodox splitting of a line in a debug
statement.
2005-02-02 16:16 brun
* cont/src/TGenCollectionProxy.cxx:
From Markus Frank,
Fix in TGenCollectionProxy::PopProxy to correctly initialize fEnv.
2005-02-01 16:25 rdm
* asimage/Module.mk:
make sure builtin libungif is used.
2005-02-01 15:43 rdm
* cont/: inc/TExMap.h, src/TExMap.cxx:
some cosmetics.
2005-01-31 23:14 brun
* hist/src/: TH2.cxx, TH3.cxx:
Undo previous changes in the TH2 and TH3 constructors activating
the automatic binning from the buffer. These changes affect
the correct running of DrawTest.sh. To be investigated.
2005-01-31 18:20 brun
* asimage/src/TASImage.cxx, base/src/TQObject.cxx,
gui/inc/TGButton.h, gui/src/TGButton.cxx,
gui/src/TGButtonGroup.cxx:
From Valeriy and checked by Ilka:
- emit signals and change button state on release
2005-01-31 15:23 brun
* gl/src/TViewerOpenGL.cxx:
Replace variable sort by sortgl.
sort is ambiguous with a variable in one include on Alpha
2005-01-31 14:40 brun
* hist/src/: TH2.cxx, TH3.cxx, TProfile2D.cxx:
In TH2, TH2, TH3 add support for SetBuffer when one of the lower limits
is greater or equal to the upper limit.
In TProfile2D constructors force an additional call to SetBuffer.
Because SetBuffer is called from the TH2 constructors, TH1::setBuffer
was called instead of TProfile2D::SetBuffer.
Fix a bug in TProfile2D::BufferEmpty.
2005-01-30 08:16 brun
* gpad/src/TCanvas.cxx:
From Bertrand,
fUpdating was set to kTRUE too early in TCanvas::Update in case of Windows
or multiple threads.
2005-01-28 17:56 brun
* base/src/TBuffer3D.cxx:
Protect TBuffer3D in case a TView does not exist in the pad.
2005-01-28 17:33 rdm
* proof/src/TPacketizer.cxx:
correct some error and info messages (use the proper method name in
which they are called).
2005-01-28 17:32 rdm
* rpdutils/src/rpdutils.cxx:
From Gerri:
make debug output conditional on gDebug.
2005-01-28 16:07 brun
* gui/src/TGButton.cxx:
From Valeriy Onuchin:
Fix a problem with shutters.
2005-01-28 15:49 brun
* hist/src/TH1.cxx:
In TH1::Copy copy also the buffer array if it is filled.
2005-01-28 15:46 rdm
* asimage/: Module.mk, src/libAfterImage.tar.gz:
latest libAfterImage and force in Module.mk the usage of the builtin libungif.
2005-01-28 14:54 rdm
* configure:
in the --help the options for python, qt ruby and xml were missing.
2005-01-28 14:53 brun
* tree/src/TLeaf.cxx:
Improve TLeaf::GetLeafCounter such that a class with a dynamic array
with the size declared in the comment field with [size] will work
when the class is the top level branch of a Tree and the branch name
has "." as last character.
2005-01-28 11:01 brun
* geom/inc/TGeoCone.h, geom/inc/TGeoPgon.h, geom/inc/TGeoShape.h,
geom/inc/TGeoTube.h, geom/src/TGeoBBox.cxx, geom/src/TGeoCone.cxx,
geom/src/TGeoPcon.cxx, geom/src/TGeoPgon.cxx,
geom/src/TGeoShape.cxx, geom/src/TGeoSphere.cxx,
geom/src/TGeoTorus.cxx, geom/src/TGeoTrd1.cxx,
geom/src/TGeoTrd2.cxx, geom/src/TGeoTube.cxx,
geom/src/TGeoXtru.cxx, geompainter/src/TGeoPainter.cxx:
From Andrei:
I attached the first big chunk of changes.
The methods changed are mostly the implementations of TGeoShape::DistFromInside/DistFromOutside for some specific shapes. The new algorithms are boundary error tolerant, giving the correct distance even if the point is on the wrong side of the boundary. The calling sequence remains un-changed. The affected shapes for now are: box, trd1, trd2, tube, tube seg, cone, cone seg, pcon, pgon. I will complete few remaining for the full description of ALICE next week (para + arb8 family: trap,gtra).
2005-01-28 06:45 brun
* base/inc/TProcessID.h, base/src/TObject.cxx,
base/src/TProcessID.cxx, base/src/TRef.cxx,
meta/src/TStreamerInfoReadBuffer.cxx,
meta/src/TStreamerInfoWriteBuffer.cxx:
From Philippe:
This patch solved a problem due to the fact that TObject's fUniqueID can
only hold a 8 bits ProccessID identifier (in addition to storing a 24 bits
object ID). However we support 65535 distinct ProcsssID identifiers per
file. Before this patch, for a file containing more than 255 distcint
ProcessID, the
TRef using the later ProcessID would be unable to find their references.
Specifically, fUniqueID can now store the ProcessID indentifier 0 through
254. When more identifiers
are used, then instead of store the identifier in the 8 higher bit of
fUniqueID we store in a table (TProcessID::fgObjPIDs) linking addresses to
pids.
2005-01-27 21:43 brun
* treeplayer/src/TTreePlayer.cxx:
From Maarten:
The attached patch seems correct, and fixes a problem for the Phobos
tree when generating selectors. But the code is difficult to understand
from scratch as a lot of internal Tree/Branch/Leaf details are involved.
2005-01-27 21:36 brun
* base/src/TSystem.cxx:
From Philippe:
This patch downgrades a few ACLiC messages from Warning to Info.
2005-01-27 21:34 brun
* gpad/: inc/TCanvas.h, src/TCanvas.cxx:
Add a new transient member fUpdating in class TCanvas.
This member is set to kTRUE while TCanvas::Update executes.
This is to prevent recursive calls to this function.
2005-01-27 21:14 brun
* base/src/TRandom.cxx:
Fix a wrong comment in TRandom::BreitWigner
2005-01-27 19:55 brun
* hist/src/TMultiDimFit.cxx:
Fix a typo in the code generator
2005-01-27 18:09 rdm
* build/package/rpm/root-rootd.spec.in:
From Gerri:
some versions of rpm compress the man page files. Handle correctly these .gz
files.
2005-01-27 18:07 rdm
* proofd/src/proofd.cxx, rootd/src/rootd.cxx:
From Gerri:
These are the cleanups of all direct fprintf(stderr,...) in rootd
and proofd.
Now everything should be printed consistently on only one stream.
2005-01-27 15:51 brun
* base/inc/TVirtualGL.h, gl/inc/TGLKernel.h, gl/src/TGLKernel.cxx,
gl/src/TViewerOpenGL.cxx, win32gdk/inc/TGWin32VirtualGLProxy.h,
win32gdk/src/TGWin32VirtualGLProxy.cxx:
From Olivier & Bertrand:
- From Bertrand: gl2ps accessed via gVirtualGL in order to work on windows.
- From Olivier: GL scenes can be printed in low quality (fast) or high
quality (slow).
2005-01-27 07:16 brun
* treeplayer/: inc/LinkDef.h, inc/TBranchProxy.h,
src/TTreeProxyGenerator.cxx:
From Philippe:
This add support for a few additional cases in MakeProxy (namely
TClonesArray in a TBranchObject, non-split top level objects when library is
loaded).
2005-01-26 20:59 brun
* utils/src/rootcint.cxx:
From Philippe:
This patch insures that the linkdef file is NOT included by the dictionary
header file when using the -p option.
2005-01-26 18:04 brun
* meta/src/TStreamerElement.cxx:
From Philippe:
In the attached patch, I simply fix up the TStreamerElement when it is read
from the file so that the old Bool_t/11 and set them to Bool_t/18.
2005-01-26 11:51 brun
* hist/src/TSpectrum.cxx:
Take into account the current bin range in TSpectrum::Search
2005-01-26 10:57 brun
* cont/src/TExMap.cxx:
From Olivier:
Fix a problem with VC++6: - Loop index declared twice
2005-01-26 10:43 rdm
* asimage/Module.mk:
reverting to previous version. Take system installed libungif otherwise
fallback to builtin.
2005-01-26 07:42 brun
* cont/: inc/TExMap.h, src/TExMap.cxx:
From Maarten:
This new implementation results in a 30% performance improvement
in reading complex trees. (e.g with Event). I replaced the separately
allocated (hash,key,value) structs with an array, using the lowest bit
of the hash as a flag for indicating if a slot is free or not.
(This also means a 25% memory reduction.) The general hashing behaviour
should not be affected as we use the hash value modulo a (large) prime.
2005-01-25 23:14 brun
* hist/src/TFormula.cxx, test/dt_DrawTest.C, test/dt_MakeRef.C:
From Philippe:
This patch insures that TFormula does modify the 'strings' that are embedded
in an expression.
2005-01-25 20:58 brun
* tree/: inc/TTree.h, src/ManualTree2Body.h, src/TTree.cxx:
From Philippe,
Fix for a bug introduced in a recent version of TTree::Branch.
Thanks Sue Kasahara.
2005-01-25 18:05 brun
* tree/src/TChain.cxx:
From Marco van Leeuwen:
I've made some small modifications (see attachment) to TChain::LoadTree(), which enables a TChain to skip corrupted files while looping to a chain. My modifications are in fact a simple extension of Philippe Canals fix for empty files,.
2005-01-25 17:57 brun
* base/src/ManualBase4Body.h:
From Pere Mato:
The CVS head version was still not working for classes in a
namespace. To make it work I have made change Name() by Fullname() in
the file base/src/ManualBase4Body.h.
2005-01-25 17:00 brun
* asimage/Module.mk, asimage/src/TASImage.cxx, gui/src/TGFrame.cxx:
From Ilka & Valeriy
fix the problem with the canvas deletion reported by Philippe.
2005-01-25 08:36 brun
* hist/src/: TH1.cxx, TH2.cxx, TH3.cxx, TProfile.cxx,
TProfile2D.cxx:
In TH1::RebinAxis always double the current range (instead of adding range/4).
Modify the Merge functions accordingly.
2005-01-25 08:24 brun
* base/src/TROOT.cxx, meta/src/TDataType.cxx, tree/src/TTree.cxx:
From Philippe:
There was a missing TDataType object (needed by the new
TTree::CheckBranchAddress).
2005-01-23 23:11 rdm
* base/inc/: LinkDef1.h, Rtypes.h:
From Maarten:
add additional constants describing the basic types?
Useful for test cases among other things.
2005-01-22 10:29 brun
* treeplayer/src/: TBranchProxyClassDescriptor.cxx,
TBranchProxyDescriptor.cxx, TTreeProxyGenerator.cxx:
From Philippe:
This patch prevents error message issue when looking at an empty string and
add support for the newer support for base classes in TTree.
2005-01-21 19:38 rdm
* gui/src/TGFileDialog.cxx:
From Ilka:
The warning message about the file existing should not be activated if
the file selection dialog is used for file opening.
2005-01-21 16:19 rdm
* test/guitest.cxx, tutorials/guitest.C:
delete fContainer to avoid memory leak.
2005-01-20 22:58 brun
* hist/src/: TH1.cxx, TH2.cxx, TH3.cxx, TProfile.cxx,
TProfile2D.cxx:
In the Mere functions add support for the case where the destination histogram is not empty.
2005-01-20 18:28 brun
* gl/: Module.mk, inc/TViewerOpenGL.h, inc/gl2ps.h,
src/TViewerOpenGL.cxx, src/gl2ps.c:
From Olivier:
- TViewerOpenGL now uses the tool "gl2ps" from Christophe Geuzaine
<geuz@geuz.org> to produce vector PostScript and PDF outputs. Jeff
Kallenbach did the interface to this tool.
2005-01-20 18:19 brun
* cint/src/struct.c:
From Philippe:
Valgrind discovered a couple of additional uninitialized memory.
They are solved by the attached patches (compared to ciont 5.15.161).
2005-01-20 18:19 rdm
* README/CREDITS:
Ilka was missing !!! Sorry.
2005-01-20 17:39 rdm
* meta/src/TStreamerElement.cxx:
From Philippe:
This patch should solve intermittent problem seen on windows and MacOs when
reloading libraries.
TClass::ReplaceWith is looping over the GetListOfClasses using an iterator.
In order to avoid problems, we need to insure that the iterator is not
invalided by insuring that the hash list is not modified during the looping.
2005-01-20 16:37 rdm
* gui/src/TGCanvas.cxx:
don't delete the container in the TGCanvas dtor. The container is set in
the TGCanvas but not adopted by the TGCanvas, so it may never be deleted
by the TGCanvas. This fixes the canvas crashes.
2005-01-20 16:28 brun
* graf/src/: TGraphAsymmErrors.cxx, TGraphErrors.cxx:
Fix a problem in the Constructurs with TVector in argument.
One must call TGraph::CrtAllocate to allocate the TGraph arrays.
2005-01-20 10:26 brun
* g3d/src/TTUBS.cxx:
From Timur:
Fix to get shapes.C operational.
2005-01-20 08:49 brun
* tutorials/h1analysis.h:
From Philippe:
Fix incorrect type definitions in the header file.
Some variables were declared UInt_t instead of UChar_t.
2005-01-20 02:28 rdm
* build/package/rpm/root-rootd.spec.in, config/rootrc.in:
fix in spec file to reference the new rootd.rc.d file in rootd/misc.
2005-01-20 02:27 rdm
* rootd/misc/rootd.rc.d:
script to have rootd started at system startup (RedHat version).
2005-01-20 02:14 rdm
* asimage/src/libAfterImage.tar.gz:
using updated config.guess that also works for PPC64.
2005-01-20 02:10 rdm
* tree/: inc/LinkDef.h, inc/TLeafO.h, src/TBranch.cxx,
src/TLeafO.cxx, src/TTree.cxx:
From Philippe:
This last update should fix all bool issues on MacOS by adding a new class
TLeafO (for bOOL).
2005-01-19 23:03 brun
* meta/src/TStreamerInfo.cxx:
From Philippe:
This patch fix a problem due to the fact that TObjArray::At and
TObjArray::UncheckedAt do not take the same exact argument (range
difference).
2005-01-19 21:18 brun
* base/src/TMapFile.cxx:
By mistake I checked in a development version of TMapFile. Going back.
2005-01-19 21:00 brun
* base/src/TMapFile.cxx, table/inc/TTableSorter.h:
Previous change by Philippe had a side-effect in table. Now fixed by Philippe.
2005-01-19 19:30 brun
* cont/src/TEmulatedCollectionProxy.cxx,
cont/src/TEmulatedMapProxy.cxx,
cont/src/TGenCollectionStreamer.cxx, meta/inc/TDataType.h,
meta/inc/TStreamerInfo.h, meta/src/TDataType.cxx,
meta/src/TStreamerInfo.cxx, meta/src/TStreamerInfoReadBuffer.cxx,
meta/src/TStreamerInfoWriteBuffer.cxx, table/inc/TTable.h,
table/src/TTable.cxx, table/src/TTableSorter.cxx,
tree/src/TBranchElement.cxx, tree/src/TTree.cxx,
treeplayer/inc/TBranchProxy.h, treeplayer/src/TFormLeafInfo.cxx,
treeplayer/src/TTreeProxyGenerator.cxx, xml/src/TXMLPlayer.cxx:
From Philippe:
This patch implement support for bool of various in memory size. They are
always written using only 1 bytes. This solves problem on MacOS where
sizeof(bool)==4 instead of 1.
Note that there should still be a problem with the old-style splitted branch
(tested in Event.old.split.root.
A fix for this will come later on.
2005-01-19 19:28 brun
* utils/src/rootcint.cxx:
From Philippe:
This patch prevents rootcint from trying to look at class that have only:
class XYZ;
#pragma link C++ class XYZ;
In these cases, there is not enough information to do anything.
2005-01-19 18:43 rdm
* proof/utils/crypt:
small script that can be used to generate passwd to be used with UsrPwd
authentication method. Store the generated passwd in ~/.rootdpass.
2005-01-19 18:00 rdm
* hist/src/TFormula.cxx:
fix typo in error message.
2005-01-19 17:09 rdm
* gui/src/: TGCanvas.cxx, TGListBox.cxx:
From Valeriy:
- fix silly bug in TGCamvas dtor.
- add setting focus on button press in TGContainer, TGLBContainer.
That fixes key handling activation problem under win32.
2005-01-19 16:53 rdm
* build/unix/compiledata.sh:
add case for macosxxlc.
2005-01-19 14:19 brun
* geom/inc/TGeoTube.h, geom/src/TGeoCone.cxx,
geom/src/TGeoPcon.cxx, geom/src/TGeoTube.cxx,
gl/inc/TGLSceneObject.h, gl/src/TGLSceneObject.cxx,
gl/src/TViewerOpenGL.cxx:
From Timur:
1. TGLTube replaced by TGLCylinder - generic class for tubes, cones,
segments and cuts (in theory, for polycones too). Tubes are drawn now as
strips (quad and triangle), real normals for tubes are calculated.
gl vertex arrays are used.
2. For each type of tube, I know the exact size of vertices arrays I need
- I don't need to use nsegments (because of real normals, we don't need
large tube segmentation to get smooth surfaces).
2005-01-19 13:14 rdm
* configure:
only check for dc_lseek64 when libdcap has been found.
2005-01-19 08:52 brun
* test/Event.cxx, test/Event.h, test/dt_DrawTest.C,
test/dt_MakeRef.C, treeplayer/src/TFormLeafInfo.cxx,
treeplayer/src/TTreeFormula.cxx:
From Philippe:
The following patch
insure a bool (UChar_t) is considered as an integer by TTreeFormula
add a test for Bool.
Remove a warning on linux for TFormLeafInfo
2005-01-18 22:07 brun
* gui/src/TGCanvas.cxx, gui/src/TGColorDialog.cxx,
gui/src/TGMenu.cxx, test/guitest.cxx, tutorials/guitest.C,
x11/src/GX11Gui.cxx:
From Valeriy Onuchin
- an example of usage "hierarchical cleaning" added to guitest tutorial.
- add protection to TGMenuBar dtor. for case of hierarchical cleaning.
- TGCanvas. Cleanup container in case of hierarchical cleaning.
- RootX11ErrorHandler - ignore errors for "pseudo-windows" with win ID = 0.
2005-01-18 22:05 brun
* treeplayer/src/TFormLeafInfo.cxx:
From Philippe:
This patch solves a problem with trying to draw a variable size array within
a collection.
2005-01-18 22:04 brun
* base/src/TROOT.cxx, meta/inc/TCint.h, meta/inc/TClass.h,
meta/inc/TInterpreter.h, meta/src/TCint.cxx, meta/src/TClass.cxx,
win32gdk/inc/TGWin32InterpreterProxy.h,
win32gdk/src/TGWin32InterpreterProxy.cxx:
From Philippe:
This patch resolve a few issues when loading a library implementing an STL
container after opening a file containing an instance of this STL container.
Depending of the circunstances this lead to either an infinite recursion or
an incorrect collecton proxy.
This patch also resolves completely the issue related to using namespace
statement. Aka you can now properly do:
using namespace MySpace;
gROOT->GetClass("ClassWithingMySpace");
2005-01-18 18:59 brun
* meta/src/TClass.cxx:
do not split classes deriving from TVectorF or TVectorD
2005-01-18 17:58 rdm
* thread/src/TThread.cxx:
remove some unused variables.
2005-01-18 16:17 brun
* gpad/src/TPad.cxx:
From Otto Schaile:
Changes to get TCurlyArc to work with the graphics editor in case
of pads with different scales in X and Y.
2005-01-18 16:08 brun
* gui/src/TGListTree.cxx:
From Valeriy Onuchin:
- fix refreshing list tree bug found under win32.
2005-01-18 12:53 brun
* qt/src/GQtGUI.cxx:
Add some protections against a window id=0.
More protections of the same type are required
2005-01-18 12:48 rdm
* configure:
fix in check_symbol.
2005-01-18 12:23 brun
* gui/src/TGListTree.cxx:
From Valeriy Onuchin:
- implemented optimized TGListTree drawing
(draw only those items which are "projected" to viewport).
It's possible to draw and scroll more than 20000 items
2005-01-18 12:21 rdm
* configure:
check for correct version of libdcap which must have dc_lseek64.
If you don't have this version download it from www.dcache.org.
2005-01-18 12:06 rdm
* gpad/src/TInspectCanvas.cxx, meta/src/TClass.cxx:
fBits is UInt_t printf format was still %lx -> %x.
2005-01-17 20:37 rdm
* base/src/TObject.cxx, gpad/src/TInspectCanvas.cxx,
meta/src/TClass.cxx:
another small correction in printing fBits in hex (add leading 0's).
2005-01-17 17:26 brun
* gpad/src/TInspectCanvas.cxx, meta/src/TClass.cxx:
From Olivier:
- The hexadecimal value printed in Inspect and Dump for fBits was not the
correct one. (Fixed by Otto Schaile)
2005-01-17 17:11 rdm
* cint/: inc/vc7strm.h, src/vc7strm.cxx:
Version which should fix problems with cin of shorts.
2005-01-17 16:33 brun
* gui/src/TGListBox.cxx:
From Valeriy Onuchin:
- update/redraw list box container on TGListBox::Layout
Thanks to Christian Stratova
reported this at http://root.cern.ch/phpBB2/viewtopic.php?t=1485
2005-01-16 17:08 brun
* hist/src/TH3.cxx:
Fix a problem with the algorithm taking into account the underflow/overflows
in TH3::Project3D
2005-01-15 23:04 brun
* cint/src/g__cfunc.c:
From Philippe:
Fix a problem (VC++7 specific) due to a problem when calling strcat
and optimized code.
2005-01-14 19:12 brun
* meta/src/TCint.cxx:
From Philippe:
This patch allows the loading of class nested in a namespace that is known
to CINT but not to ROOT. This usually happens when there is
#pragma link C++ class SomeSpace::SomeClass;
But there is __not__ a
#pragma link C++ namespace SomeSpace;
2005-01-14 19:10 brun
* gui/src/TRootCanvas.cxx:
From Ilka:
fix in TRootCanvas::Close() method to protect the
case when the canvas is deleted via cint. Thanks to Otto Schaile.
2005-01-14 18:11 rdm
* rpdutils/src/rpdutils.cxx:
From Gerri:
- move globus credential acquisition after definition of variables
X509_USER_CERT, etc.
2005-01-14 18:10 rdm
* globusauth/src/GlobusAuth.cxx:
From Gerri:
- add debug statement.
2005-01-14 18:09 rdm
* rootd/src/rootd.cxx:
From Gerri:
- correctly define variable daemonrc from command line argument.
2005-01-14 18:05 rdm
* README/README.GLOBUS:
From Gerri:
updates.
2005-01-14 16:10 brun
* geom/src/TGeoMatrix.cxx:
From Andrei Gheata:
The constructor TGeoHMatrix(name) was creating a matrix with the rotation bit set. Affected matrix multiplication optimization during navigation.
2005-01-14 16:08 brun
* gpad/src/TInspectCanvas.cxx, meta/src/TClass.cxx:
From Olivier:
- The TObject's data member "fBits" is now printed in hexadecimal mode by
Inspect() and Dump().
2005-01-14 13:13 brun
* geom/src/TGeoMatrix.cxx:
From Andrei,
Fix a problem reported by Ivana:
"However, I think that introducing these functions
also for TGeoTranslation has not a good sense,
as the result of R * T should not be anymore
TGeoTranslation but TGeoCombiTrans, so you go out
from the "scope" of your object ...
I'd just disable these functions in this case
and give a warning instead."
2005-01-14 13:10 brun
* geom/src/TGeoManager.cxx:
From Andrei,
Fix a problem in TGeoManager::CloseGeometry
2005-01-14 11:21 rdm
* dcache/: inc/TDCacheFile.h, src/TDCacheFile.cxx:
From Tigran Mkrtchyan:
support for large files is now available in dcap. Make use of it in
TDCacheFile. This needs the latest dcache.tgz file from
http://www.dcache.org/downloads.
2005-01-13 22:39 brun
* graf/src/: TArc.cxx, TCrown.cxx, TEllipse.cxx:
From Olivier:
- Take into account the flag NoEdges in SavePrimitive
2005-01-13 22:35 brun
* hist/inc/TH1I.h:
Fix a typo (thanks to Robert Hatcher)
2005-01-13 22:24 brun
* ged/src/: TArrowEditor.cxx, TCurlyArcEditor.cxx,
TCurlyLineEditor.cxx:
From Ilka:
Fix typos in:
ged/src/TArrowEditor.cxx
ged/src/TCurlyArcEditor.cxx
ged/src/TCurlyLineEditor.cxx
These editors were added to the TAttLine::Class() because of code
copy/paste errors with very bad side effect.
2005-01-13 21:07 brun
* hist/src/TH1.cxx, tree/src/TBranchElement.cxx,
tree/src/TTree.cxx, treeplayer/src/TTreeFormula.cxx,
treeplayer/src/TTreePlayer.cxx:
From Philippe:
TBranchElement: Insure that fSTLtype is always positive (was preventing the
reading of sets and maps in some case of split mode).
TTree, TTreePlayer: fix to TTree::Draw documentation
TTreeFormula: insures that TTree::Draw properly reads strings within a
collection
2005-01-13 21:04 brun
* rint/src/TRint.cxx:
From Philippe:
This patch insures that the temporary object created by a script given as an
argument are deleted immediately (instead of __after__ the execution of the
user's first command).
2005-01-13 21:03 brun
* gui/src/TGListBox.cxx, gui/src/TGWindow.cxx,
win32gdk/gdk/src/gdk/win32/gdkwindow-win32.c:
From Valeriy Onuchin:
- final fix for limitation on number of list_box entries for win32
2005-01-13 13:07 brun
* geom/: inc/TGeoMatrix.h, src/TGeoMatrix.cxx:
From Andrei Gheata:
According to Ivana's observations/patch, RotateX,Y,Z methods of TGeoMatrix derived classes
perform the corresponding rotations with respect with the master frame. Works now for
TGeoTranslation, TGeoRotation, TGeoCombiTrans and TGeoHMatrix.
2005-01-13 11:24 brun
* graf/: inc/TText.h, src/TLatex.cxx, src/TText.cxx:
From Olivier:
- New function GetTextAscentDescent returning the correct text ascent and
descent ("Dessus" and "Dessous" in TLatex code). This gives a better
adjustment of the bar above text.
2005-01-13 11:10 brun
* tree/src/TTree.cxx:
Remove a return statement in the second function TTree::SetBranchAddress
2005-01-12 23:28 brun
* cint/src/tmplt.c:
From Philippe:
the bug fix CINT 1487 has not been propagated to the
template registration part of CINT.
2005-01-12 21:59 brun
* test/stress.cxx:
From Philippe:
Fix compilation problems on MAC (reported by Eddy).
2005-01-12 21:04 brun
* meta/: inc/TDataType.h, src/TDataType.cxx:
From Philippe:
Fix compilation warnings on MAC (reported by Eddy)
2005-01-12 20:18 brun
* meta/src/TMethodCall.cxx:
From Philippe:
This patch enables TMethodCall to return the value of functions/methods
which return an enum.
This is in particular usefull for TTreeFormula.
2005-01-12 19:56 brun
* tree/src/: ManualTree2Body.h, TTree.cxx:
From Philippe:
This patch removes a spurrious error messages in SetBranchAddress and
correct a few code typos in ManualTree2Body.h
2005-01-12 19:48 brun
* graf/src/TLatex.cxx:
From Olivier:
- Remove 4 useless include files.
2005-01-12 19:46 brun
* gpad/src/TPad.cxx:
From Olivier:
- The line width and line style should be 1 to draw the new line hatches.
2005-01-12 19:39 brun
* gui/inc/TGCanvas.h, gui/inc/TGFrame.h, gui/inc/TGScrollBar.h,
gui/inc/TGWindow.h, gui/src/TGCanvas.cxx, gui/src/TGComboBox.cxx,
gui/src/TGDockableFrame.cxx, gui/src/TGDoubleSlider.cxx,
gui/src/TGFSComboBox.cxx, gui/src/TGFSContainer.cxx,
gui/src/TGFrame.cxx, gui/src/TGImageMap.cxx, gui/src/TGLabel.cxx,
gui/src/TGListBox.cxx, gui/src/TGListTree.cxx,
gui/src/TGListView.cxx, gui/src/TGMdiDecorFrame.cxx,
gui/src/TGMdiFrame.cxx, gui/src/TGMdiMainFrame.cxx,
gui/src/TGWindow.cxx, win32gdk/src/TGWin32.cxx,
x11/src/GX11Gui.cxx:
From Valeriy Onuchin:
- new concept of "pseudo-window" introduced.
pseudo-window - is an object inherited from TGWindow which
is not created by window system (X11 or M$ Windows).
It does not consume window system resouces.
The main use-case of pseudo-windows is GUI containers
with very large number of items. For example, listviews, listboxes,
where listview/listbox items/entries are pseudo-windows.
Pseudo-window has "window id" equal to zero.
In order to "activate pseudo-window concept" the parent should
have fIsMapSubwindows dat member to be kFALSE.
So, it's backward compatible, setting fIsMapSubwindows=kTRUE in parent window
will activate normal behavior, i.e. will be created in window system.
Introduction of "pseudo-window concept" forced the changes in
TGX11, TGWin32 classes to avoid TVirtualX methods execution when
"window id" is NULL (the case of pseudo-window).
Introduction of pseudo-windows which do not consume window system resouces
greately improved performance of TGListView, TGListBox, TGComboBox objects.
Now it's possible to have these containers with more than 10000 items.
- some optimization in TGLBContainer drawing
- add SetWindowName to most GUI classes. It's very usefull for GUI debugging.
2005-01-12 19:06 brun
* tree/: inc/TTree.h, src/TTree.cxx:
From Philippe:
Repair the build on MSVC6 by removing the (obsolete) version of TTree::Branch specific to TClonesArrays.
2005-01-12 19:02 brun
* base/src/TDirectory.cxx, test/stress.cxx,
tree/src/TChainElement.cxx, tree/src/TTree.cxx,
treeplayer/src/TTreeFormula.cxx:
From Philippe:
TDirectory:
update TDirectory::GetObject to be able to retrieve TObject from
the in-memory list (to match the behavior of TObject::Get).
stress:
update to use TDirectory new object retrieval interface. This will
allow testing of their availability in interpreted code.
TChainElement:
Insure the proper default initialization of new data members
TTree:
slight warning message fix
TTreeFormula:
Update to a problem in case of splitted top level STL container
Fix for TTree::Scan of strings when they are inside a collection
(the first element __was__ repeated instead of the sub-sequent elements).
2005-01-12 18:59 brun
* base/src/ManualBase4.cxx, base/src/ManualBase4.h,
base/src/ManualBase4Body.h, cint/src/newlink.c,
tree/src/ManualTree2.cxx, tree/src/ManualTree2Body.h:
From Philippe:
The problem was in the dictionary generation used for ManualBase4 and ManualTree2 where for those dictionary the G__init_cint was not completely cleaning up the dictionary's static global variable.
In newlink.c G__cpplink_linked_taging had an incomplete patch for G__OLDIMPLEMENTATION1730.
This is all fixed by the patches attached.
2005-01-12 15:05 rdm
* pyroot/Module.mk:
don't define a global MacOS compile option. This is now done properly
in Makefile.macosx.
2005-01-12 11:51 brun
* hbook/inc/THbookTree.h, hbook/src/THbookTree.cxx,
tree/inc/TTree.h, tree/src/TTree.cxx:
Change the API of TTree::SetEntries from
void SetEntries(Long64_t n)
to
Long64_t SetEntries(Long64_t n=-1)
// if n >= 0 Set number of entries in the Tree = n.
//
// if (n < 0) Set number of entries in the Tree to match the
// number of entries in each branch. (default for n is -1)
// This function should be called only when one fills each branch
// independently via TBranch::Fill without calling TTree::Fill
// Calling TTree::SetEntries() make sense only if the number of entries
// in each branch is identical. A Warning is issued otherwise.
// The function returns the number of entries.
2005-01-12 08:50 brun
* cint/src/init.c, meta/inc/TDataType.h, meta/src/TClass.cxx,
meta/src/TDataType.cxx, meta/src/TStreamerElement.cxx,
meta/src/TStreamerInfo.cxx, test/MainEvent.cxx, test/stress.cxx,
tree/Module.mk, tree/inc/LinkDef2.h, tree/inc/TBranchElement.h,
tree/inc/TChain.h, tree/inc/TChainElement.h, tree/inc/TTree.h,
tree/src/ManualTree2.cxx, tree/src/ManualTree2.h,
tree/src/ManualTree2Body.h, tree/src/TBranchElement.cxx,
tree/src/TBranchObject.cxx, tree/src/TChain.cxx,
tree/src/TTree.cxx, treeplayer/src/TTreeFormula.cxx,
tutorials/tree0.C, tutorials/tree2a.C, tutorials/tree3.C,
tutorials/tree4.C:
From Philippe:
A) Support for top level STL Containers. You can now do
list<int> *ptr = new list<int>;
tree->Branch("mystl","list<int>",&ptr);
B) Autodetection of the pointer type passed to the branch constructor.
So you can now do:
list<int> *ptr = new list<int>;
tree->Branch("mystl",&ptr);
C) Check of the type of the pointer type passed to the branch constructor.
So that you now get an error:
list<int> *ptr = new list<int>;
tree->Branch("mystl","list<float>",&ptr);
Error in <TTree::Branch>: The class requested (list<float>) for the branch
"mystl" is different from the type of the pointer passed (list<int>)
D) TTree's SetBranchAddress now also check its input address (unless the
user explicitly specify (char*) or (void*).
Test/Event and the tree tutorials have been updated to take advantage of the
new syntax.
2005-01-12 04:02 rdm
* proof/src/TStatus.cxx:
Fix VC++ 7.1 compiler warning.
2005-01-12 04:01 rdm
* win32gdk/inc/Win32Constants.h, winnt/inc/Win32Constants.h:
Move Win32Constants.h to winnt directory where it is used first.
2005-01-11 14:29 brun
* test/RootShower/: MyEvent.cxx, RSVersion.h:
From Bertrand:
Avoid creation of Quarks secondaries.
2005-01-11 14:15 brun
* tree/src/TTree.cxx:
Fix a problem in TTree::ReadFile. One extra entry was read.
2005-01-11 14:06 brun
* treeplayer/src/TTreePlayer.cxx:
Add a comment in TTreePlayer::Scan indicating that the return value
is the number of selected rows
2005-01-10 12:00 brun
* html/src/THtml.cxx:
From Matevz Tadel:
While building auto-generated documentation for gled classes i came
across an error in ClassDef specification in a nested class which,
coupled with gled's documentation building script, resulted in feeding
THtml a class-name list with entries that were not present in the
dictionary. Thus root crashed ...
I've attached a patch with added protections against such cases. I'm not
exactly sure if it's the right way to do it ... perhaps an error and an
immediate exit from the processing loop would be more appropriate.
2005-01-08 17:09 brun
* hist/src/TF1.cxx:
In TF1::GetRandom fix a problem in case the parabola used to interpolate
inside one bin is very close to a straight line. In this case the previous
algorithm was facing a numerical precision problem.
2005-01-07 01:15 rdm
* utils/src/rootcint.cxx:
From Philippe:
Rootcint was not properly handling CINT's positional options (+P,+STUB,+V).
Note that when using the preprocessor, those positional options will be
applied to all the header file (even for something like -p +STUB header1.h
-STUB header2.h linkdef.h).
This patch also reduces the number of call to the preprocessor from 4 to 1
(when using the -p option).
2005-01-07 00:18 rdm
* base/src/TSystem.cxx:
From Philippe:
this patch corrects the handling of shared library extensions
introduced in the previous patch.
2005-01-06 22:32 brun
* matrix/src/TMatrixDSparse.cxx:
From Olivier
- irowc was defined twice
2005-01-06 22:27 brun
* base/src/TSystem.cxx, meta/src/TCint.cxx,
unix/src/TUnixSystem.cxx, winnt/src/TWinNTSystem.cxx:
From Philippe,
Fix for a problem reported by Jacek Holeczek
I finally understood and solved the problem.
First the loading was considered successful is any loaded library has the
name of the requested library embedded in its full pathname (which is the
wrong behavior and is fixed by the attached patch).
In addition any loaded files with the string '.a','.so','.sl' embedded in
their full pathname was considered a library (which is the wrong behavior
and is fixed by the attached patch).
Hence in you case:
/.automount/p2a00/root/exports/home/holeczek/test_subdir_name_must_contain_G
4_string/./x.cxx
Was considered a library (because of the second and third character) and was
considered to be equivalent to the library 'G4/G4' because of the 'G4'
string in the directory name.
The attached patch solves this problem and modify the search behavior for
existing library.
Now we have
Once a file named XXX.[a|so|sl|dl] has been loaded, gSystem->Load will
consider that file matching [/*/][lib]XXX.[a|so|sl|dl].
In other word you can not load 2 libraries whose full pathname differs only
by the pathname and/or the last extension.
2005-01-06 14:16 rdm
* test/: Makefile, Makefile.arch:
check for thread support, if not there don't build "threads".
2005-01-06 08:03 brun
* base/src/TSystem.cxx:
From Philippe:
This patch fix the Info message when ACLiC regenerate a loaded library
because the script is newer.
2005-01-06 07:37 brun
* matrix/inc/TMatrixD.h, matrix/inc/TMatrixDSparse.h,
matrix/inc/TMatrixDSym.h, matrix/inc/TMatrixF.h,
matrix/inc/TMatrixFSym.h, matrix/src/TMatrixD.cxx,
matrix/src/TMatrixDCramerInv.cxx, matrix/src/TMatrixDSparse.cxx,
matrix/src/TMatrixDSym.cxx, matrix/src/TMatrixF.cxx,
matrix/src/TMatrixFCramerInv.cxx, matrix/src/TMatrixFSym.cxx,
test/stressLinear.cxx:
From Eddy:
- completed the set of binary logical matrix operations for TMatrixF
and TMatrixD
classes:
> TMatrixD operator&& (const TMatrixD &source1,const TMatrixD
&source2);
> TMatrixD operator&& (const TMatrixD &source1,const TMatrixDSym
&source2);
> TMatrixD operator&& (const TMatrixDSym &source1,const TMatrixD
&source2);
> TMatrixD operator|| (const TMatrixD &source1,const TMatrixD
&source2);
> TMatrixD operator|| (const TMatrixD &source1,const TMatrixDSym
&source2);
> TMatrixD operator|| (const TMatrixDSym &source1,const TMatrixD
&source2);
> TMatrixD operator> (const TMatrixD &source1,const TMatrixD
&source2);
> TMatrixD operator> (const TMatrixD &source1,const TMatrixDSym
&source2);
> TMatrixD operator> (const TMatrixDSym &source1,const TMatrixD
&source2);
> TMatrixD operator>= (const TMatrixD &source1,const TMatrixD
&source2);
> TMatrixD operator>= (const TMatrixD &source1,const TMatrixDSym
&source2);
> TMatrixD operator>= (const TMatrixDSym &source1,const TMatrixD
&source2);
> TMatrixD operator<= (const TMatrixD &source1,const TMatrixD
&source2);
> TMatrixD operator<= (const TMatrixD &source1,const TMatrixDSym
&source2);
> TMatrixD operator<= (const TMatrixDSym &source1,const TMatrixD
&source2);
> TMatrixD operator< (const TMatrixD &source1,const TMatrixD
&source2);
> TMatrixD operator< (const TMatrixD &source1,const TMatrixDSym
&source2);
> TMatrixD operator< (const TMatrixDSym &source1,const TMatrixD
&source2);
> TMatrixD operator!= (const TMatrixD &source1,const TMatrixD
&source2);
> TMatrixD operator!= (const TMatrixD &source1,const TMatrixDSym
&source2);
> TMatrixD operator!= (const TMatrixDSym &source1,const TMatrixD
> TMatrixDSym operator&& (const TMatrixDSym &source1,const TMatrixDSym
&source2);
> TMatrixDSym operator|| (const TMatrixDSym &source1,const TMatrixDSym
&source2);
> TMatrixDSym operator> (const TMatrixDSym &source1,const TMatrixDSym
&source2);
> TMatrixDSym operator>= (const TMatrixDSym &source1,const TMatrixDSym
&source2);
> TMatrixDSym operator<= (const TMatrixDSym &source1,const TMatrixDSym
&source2);
> TMatrixDSym operator< (const TMatrixDSym &source1,const TMatrixDSym
&source2);
- corrected some error messages
- removed a bug in TMatrixDCramerInv and TMatrixFCramerInv for the
inversion of (2x) and (3x3) matrices : instead of A^-1 (A-1)^T was calculated
- improved in stressLinear the test procedure of TMatrixDCramerInv
2005-01-05 23:22 brun
* treeplayer/src/: TBranchProxyClassDescriptor.cxx,
TBranchProxyDescriptor.cxx, TTreeProxyGenerator.cxx:
From Philippe:
This patch insure the proper generation of variable names when the top level
branch name ends in '.'.
It also fixes some spurrious duplication of proxy classes.
It also avoid duplicating top level variable names and warns:
Warning in <TTreeProxyGenerator>: The branch name "baseB<void>" is
duplicated. Only the first instance
will be available directly. The other instance(s) might be available
via their complete name
(including the name of their mother branche's name).
2005-01-05 17:51 rdm
* proof/src/TPacketizer.cxx:
From Maarten:
fix in range determination in packetizer, PROOF works again.
2005-01-05 17:48 brun
* cont/inc/TCollectionProxy.h:
From Philippe:
Fix for a problem on VC++6 preventing to build the test/bench example.
2005-01-05 17:27 rdm
* Makefile:
add xml to the list of modules that will always be build since this module
does not depend anymore on libxml2.
2005-01-05 16:55 rdm
* netx/src/TXInputBuffer.cxx:
TimedWaitRelative(0 should wait for 2 seconds -> 2000 ms, not 2 ms.
2005-01-05 16:03 brun
* treeplayer/src/TTreePlayer.cxx:
Fix a problem in TTreePlayer::MakeClass in case of a branch with a name
finishing with "."
2005-01-05 10:50 brun
* hist/src/TH1.cxx:
In TH1::KolmogorovTest, in case one of the two histograms has weights
use the number of equivalent entries instead of the sum of weights
as it was done in hbook::hdiff
2005-01-05 10:27 brun
* asimage/src/TASImage.cxx, gui/src/TGFrame.cxx,
gui/src/TGListBox.cxx, gui/src/TGWindow.cxx, x11/src/GX11Gui.cxx:
From Valeriy Onuchin:
- add "tree" option to TGWindow::Print method. Calling TGWindow::Print("tree")
prints all parents/ascended windows for this window.
- add printing ascended windows to x11 error handler.
- several fixes for listbox and combobox classes
(drawing and highliting combobox/listbox entries on pointer motion, etc. )
Thanks to Andrea Bulgarelli.
- fix in drawing, resizing TASImage reported by Reiner Rohlfs
2005-01-05 02:55 rdm
* netx/src/TXInputBuffer.cxx, netx/src/TXPhyConnection.cxx,
thread/inc/TCondition.h, thread/src/TCondition.cxx,
thread/src/TThread.cxx:
change TCondition::TimedWait(ULong_t ms), the relative time version,
to TimedWaitRelative(ULong_t ms) to avoid confusion with the absolute
time version TimedWait(ULong absSec, ULong_t absNanoSec).
2005-01-05 02:35 rdm
* xrootd/src/xrootd-20041124-0752.src.tgz:
added changes in ARCH file to allow building in SLC3 with Intel icc.
Also changed "#if XrdDEBUG" to "#ifdef XrdDEBUG".
2005-01-05 02:28 rdm
* gui/src/TGApplication.cxx, rint/src/TRint.cxx:
also enable autoloading in TGApplication.
2005-01-05 02:26 rdm
* proof/src/TProofServ.cxx:
remove two calls that are already made in the TApplication ctor.
2005-01-05 02:25 rdm
* thread/src/TPosixThread.cxx:
From Gerri:
the Info message in TPosixThread::CleanUp should be
printed only if some debug is requested ...
2005-01-05 02:20 rdm
* netx/: inc/TXPhyConnection.h, src/TXInputBuffer.cxx,
src/TXNetConn.cxx, src/TXPhyConnection.cxx:
From Gerri:
The last minute change in the convention for
the first argument of TCondition::TimedWait(), i.e. from this
Int_t TimedWait(ULong_t secs, ULong_t nanoSecs = 0);
to this
Int_t TimedWait(ULong_t secs, ULong_t nanoSecs);
Int_t TimedWait(ULong_t ms);
had some nasty effect on the behaviour of TXNetFile in
asynchronous mode, showing up dramatically only on SLC3 and
Solaris (for some reason not really understood, on RH73 and
MacOSx things continued to work ... and, needless to say, the
first check I did after the commit has been on these two machines).
The patch fixes the related problem in TXInputBuffer.cxx and
also an additional bug found by Fabrizio in TXNetConn.cxx just
before Xmas.
There are also an additional protection and a couple of cosmetic
changes in TXPhyConnection.
2005-01-04 20:54 brun
* meta/src/: TClass.cxx, TStreamerInfo.cxx:
From Philippe:
This patches prevents an infinite recursion when calling
TStreamerInfo::BuildOld on an emulated class which contains a pointer to
itself (For example Tleaf when the Tree library is not loaded).
2005-01-04 17:22 brun
* hist/src/TH1.cxx:
By mistake I checked in a dev version of TH1. Going back to previous version.
2005-01-04 17:21 brun
* gui/src/TRootBrowser.cxx, hist/src/TH1.cxx:
From Valeriy Onuchin:
Fix for a problem reported by Eddy:
TRootBrowser::fListLevel is not clean-up when the TFile is deleted.
2005-01-04 15:38 brun
* gl/: inc/TGLSceneObject.h, src/TGLSceneObject.cxx,
src/TViewerOpenGL.cxx:
From Timur;
Fix for a problem when running tutorial nucleus.C
The problem is that display list is a "part of" gl context, wich is
destroyed each time viewer is destroyed.
2005-01-04 12:36 brun
* hist/src/TF1.cxx:
Add more comments and examples in the class description
2005-01-04 11:33 brun
* gl/: inc/TGLRender.h, inc/TGLSceneObject.h, src/TGLRender.cxx,
src/TGLSceneObject.cxx, src/TViewerOpenGL.cxx:
From Timur:
some small fixes and mods.
---
TGLSceneObject.cxx
---
1. Removed "pushes_back" from TGLSceneObject constructor
2. Removed redundant points in poly descryption (and redundant tesselation)
---
TGLRender.cxx
---
3. Fixed problem with PrintNumber - old pre-standard ostrstrem works
incorrectly - now simple TString used
---
TViewerOpenGL.cxx
---
4. Fixed UpdateRange
---
TGLSceneObject.cxx
---
5. TGLSphere modified - I use display list for all spheres now, for
example, at my PC nucleus.C(1000, 1000) works smoothly (I'm not shure
about yours laptop), and even (5000,5000) works almost smoothly.
2005-01-04 11:25 brun
* base/inc/TStyle.h, base/src/TStyle.cxx,
histpainter/src/THistPainter.cxx:
From Olivier:
- New function TStyle::SetTitleAlign() (and corresponding Get) to define
the histogram title alignment with the same convention as the text
alignment (a 2 digits integer): hv
where "h" is the horizontal alignment and "v" is the vertical alignment.
"h" can get the values 1 2 3 for left, center, and right
"v" can get the values 1 2 3 for bottom, middle and top
for instance the default alignment is: 13 (left top)
Example:
gStyle->SetTitleAlign(31)
hpx->Draw()
2005-01-04 11:18 brun
* geom/src/TGeoMatrix.cxx:
From Andrei Gheata:
patch preventing copied matrices to get the <registered>
bit set.
2005-01-03 22:58 brun
* tree/src/TBranchElement.cxx:
From Philippe:
This patch insures that splittable nested STL containers which are nested
inside another splitted STL container are NOT split (We currently only
support for one level of splitting for nested containers).
2005-01-03 17:42 brun
* meta/src/TCint.cxx:
In TCint::UpdateListOfGlobalFunctions do not call TFunction::InterfaceMethod
if G__MethodInfo::InterfaceMethod() is null.
This eliminates a warning message like
"Error: non class,struct,union object $bench used with . or ->"
that may get printed in case of some user function definition.
2005-01-03 11:49 brun
* graf/src/TPolyLine.cxx, hist/inc/TPolyMarker.h,
hist/src/TPolyMarker.cxx:
Add support for lin/log scales in TPolyLine and TPolyMarker.
Implement TPolyMarker::DistancetoPrimitive.
2005-01-03 10:50 brun
* graf/src/TLegend.cxx:
In TLegend::PaintPrimitives simplify the logic by using a dynamic_cast
instead of interpreted CINT code (thanks Alessandro Thea)
2005-01-03 09:58 brun
* graf/inc/TGraph.h:
Add the two following virtual (and dummy) functions in TGraph:
virtual Double_t* GetEX() const {return 0;}
virtual Double_t* GetEY() const {return 0;}
2005-01-01 12:29 rdm
* base/src/TApplication.cxx:
protect ProcessLine() and ProcessFile() against 0 line and file arguments.
2004-12-31 10:21 brun
* cint/: inc/Method.h, src/Method.cxx:
From Philippe:
This patch insures that G__MethodInfo (and Hence the tab completion) see the
function that have been inserted into the global namespace by a using
statement.
2004-12-29 03:07 rdm
* test/RootShower/: RSHelpText.cxx, RSHelptext.cxx:
small fix in capatalization of the file name.
2004-12-29 03:05 rdm
* test/RootShower/: MyDetector.h, MyEvent.cxx:
From Bertrand:
Reset total energy loss into detector before starting simulation.
2004-12-29 02:58 rdm
* configure:
still check for libxml2 and libiconv, which will only be used by the
soon to be introduced libxml2 parser interface classes. They are not
needed anymore for the ROOT XML I/O which now contains its own minimal
smaller and faster parser.
2004-12-29 02:54 rdm
* build/: unix/makedist.sh, win/makedist.sh:
new xpm's mditestbg.xpm and fore.xpm were not included.
2004-12-28 21:51 brun
* proof/: inc/TProofDebug.h, src/TPacketizer.cxx,
src/TPacketizer2.cxx, src/TProofDraw.cxx, src/TProofPlayer.cxx:
From Maarten:
- Fix handling of non zero first event in TProof::Process()
- Fix TDSet range check
- Cleanup TProofDraw() debug output
2004-12-27 18:16 brun
* base/src/TAttFill.cxx:
Fix a problem in TAttFill::Modify.
With the new hatch styles (3100->3999) the line color must also be set.
2004-12-27 18:15 brun
* gpad/src/TPad.cxx:
Fix a memory leak in the TPad::PaintFillArea functions introduce
with the new hatch styles 3100->3999
2004-12-27 16:42 brun
* graf/src/: TGraph.cxx, TMultiGraph.cxx:
From Allesandro Thea
Fix in TMultiGraph::SavePrimitive to correctly save the option
specified in TMultiGraph::Add
2004-12-22 23:20 brun
* graf/src/TBox.cxx:
a TBox is now correctly paint in lin or/and log scales
2004-12-22 22:23 brun
* base/src/TDirectory.cxx:
Change text in two Warning messages
2004-12-22 18:06 brun
* tree/src/TTree.cxx:
In TTree::ChangeFile add support for objects other than TH1 and TTree.
This is necessary to avoid an endless loop.
2004-12-22 17:50 rdm
* xml/: inc/TXMLEngine.h, src/TXMLEngine.cxx:
Reintroduce proper cvs tokens.
2004-12-22 16:16 brun
* proof/src/TProofPlayer.cxx, test/ProofBench/Run_Simple_Test.C,
test/ProofBench/make_event_trees.C:
From Maarten:
- fixes a significant memory leak in the PROOF feedback code. (only some
small leaks in CINT left)
- Enhance the simple PROOF test script
2004-12-21 20:44 brun
* x11/src/GX11Gui.cxx:
From Valeriy Onuchin:
- small improvement in X11 error handling.
Now handler reports the class name of window which generated X11 error.
2004-12-21 18:52 brun
* base/src/TAttPad.cxx:
In the Setter functions, change the comment
in per cent of the pad heigth
to
in fraction of the pad height
(thanks to Axel)
2004-12-21 18:16 brun
* config/rootrc.in:
From Valeriy Onuchin:
- fix for TTF font path under win32. Whithout it rose_image.C doesn't display
text.
2004-12-21 14:52 brun
* hist/src/TH2.cxx:
Fix redefinition of loop index variables in TH2::Rebin2D (fatal with VC++6)
2004-12-20 18:15 brun
* xml/src/: TXMLFile.cxx, TXMLPlayer.cxx:
Remove obsolete comments referencing libxml2
2004-12-20 18:07 brun
* configure:
XML is now enabled by default. The new XML classes do not depend anymore
on the external library libxml2.
2004-12-20 18:04 brun
* xml/: Module.mk, inc/TXMLEngine.h, src/TXMLEngine.cxx:
From Sergei Linev:
I implemented my own xml parser, which is capable to read and write xml files,
produced by ROOT XML I/O.
A lot of xml features are skipped, therefore it is 2.5 times faster and 4.5
times smaller in memory compared to libxml2.
The new implementation is backward compatible.
2004-12-20 11:01 brun
* hist/: inc/TH1.h, inc/TProfile.h, inc/TProfile2D.h, src/TH1.cxx,
src/TH2.cxx, src/TProfile.cxx, src/TProfile2D.cxx:
From Gero Flucke:
I implemented the rebinning for histograms with variable bin sizes for
1-D, 2-D and 1D-profile hist.
The main task was to implement
TH1::SetBins(Int_t nx, const Axis_t *xBins);
and
TH1::SetBins(Int_t nx, const Axis_t *xBins, Int_t ny, const Axis_t *yBins);
analog to SetBins(Int_t nx, Axis_t xmin, Axis_t xmin ...) and to overwrite
the methods in TProfile(2D).
For 2-D hists I decided not to distinguish between hists that are variable
bin sized in only one or both dimensions, for simplicity.
For concistency I changed the TProfile::SetBins(...Double_t...) to
SetBins(...Axis_t...) since this is their signature in the bas class.
I fixed usage of strlen without checking for NULL-pointers. :-)
Note that I also removed a check in TH2::Rebin2D that I consider not to be
needed.
2004-12-18 00:09 brun
* test/ProofBench/Run_Simple_Test.C:
From Maarten Ballintijn
Simple script to run full proof test
2004-12-18 00:04 brun
* proof/src/TDrawFeedback.cxx:
From Maarten Ballintijn
Make Info() conditional on gDebug
2004-12-17 23:34 brun
* mlp/: inc/TMLPAnalyzer.h, src/TMLPAnalyzer.cxx,
src/TMultiLayerPerceptron.cxx:
From Axel Naumann:
As you pointed out, MSVC found a real problem. Your quick correction
still left the underlying logic problem. Fixed now, see attachment. I
also renamed the vars.
On the mlpHiggs result: the result is (within the randomization
variations) unchanged - I did not touch any of the internals of the MLP
algorithm. Only DrawNetwork didn't manage to display the stack of
histos. This looks like a problem with THStack, its side effect shows up
in mlpHiggs. I replaced the THStack->Draw by sigh->Draw(),
bgh->Draw("same") for now, leaving a reminder comment that this needs to
be fixed. I'll look into that later.
My new methods don't work on the mlpHiggs example (they do work on my
private use case, though). There is a problem creating the TProfile
histos for the mlpHiggs tutorial which I didn't find after chasing it
down for hours. I need more time for that.
I forgot one deletion, now the legends are only created if options
doesn't contain "goff". The profiles are now filled with O-T:T, not
(O-T)/T:T (O: output value, T: truth value), to avoid div by 0. One
THStack had an invalid Form()'ed title.
TMLP::Train now tells how many test and train events are used.
2004-12-17 23:24 brun
* base/src/TSystem.cxx:
From Philippe
patch to insure that Tsystem::Load properly find the library
dependency even if the library is passed using a full pathname (as it is
done when using the plugin manager).
2004-12-17 23:22 brun
* base/inc/RVersion.h, build/version_number:
Start development version 4.03/01
ROOT page - Class index - Class Hierarchy - Top of the page
This page has been automatically generated. If you have any comments or suggestions about the page layout send a mail to ROOT support, or contact the developers with any questions or problems regarding ROOT.